mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: David Howells <dhowells@redhat.com>
Cc: rusty@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] MODSIGN: Add -s <signature> option to sign-file
Date: Fri, 25 Jan 2013 22:30:13 +0100	[thread overview]
Message-ID: <61d756c7-caf1-4856-a384-703946f3d503@email.android.com> (raw)
In-Reply-To: <9497.1359072618@warthog.procyon.org.uk>

David Howells <dhowells@redhat.com> wrote:

>Michal Marek <mmarek@suse.cz> wrote:
>
>> This option allows to append an externally computed singature to the
>> module. This is needed in setups, where the private key is not
>directly
>> available, but a service exists that returns signatures for given
>files.
>> 
>> Signed-off-by: Michal Marek <mmarek@suse.cz>
>> ---
>> v2: Use two-argument version of getopts to avoid global variables
>>     Use parentheses in EXPR if (...) constructs
>
>Feel free to add:
>
>Acked-by: David Howells <dhowells@redhat.com>
>
>to your patches.

Thanks for your review.

Michal


      parent reply	other threads:[~2013-01-25 21:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-24 21:20 [PATCH v2 1/4] MODSIGN: Simplify Makefile with a Kconfig helper Michal Marek
2013-01-24 21:20 ` [PATCH v2 2/4] MODSIGN: Specify the hash algorithm on sign-file command line Michal Marek
2013-01-24 21:20 ` [PATCH v2 3/4] MODSIGN: Add -s <signature> option to sign-file Michal Marek
2013-01-24 21:20 ` [PATCH v2 4/4] MODSIGN: Add option to not sign modules during modules_install Michal Marek
2013-01-25  0:10 ` [PATCH v2 3/4] MODSIGN: Add -s <signature> option to sign-file David Howells
2013-01-25  3:12   ` Rusty Russell
2013-01-25 21:30   ` Michal Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61d756c7-caf1-4856-a384-703946f3d503@email.android.com \
    --to=mmarek@suse.cz \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®