From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 1/3] regulator: max14577: Add proper dt-compatible strings
Date: Mon, 24 Feb 2020 15:08:05 +0100 [thread overview]
Message-ID: <61dc8192-e313-021f-9e23-928257a66984@samsung.com> (raw)
In-Reply-To: <20200221171342.GI5546@sirena.org.uk>
Hi Mark,
On 21.02.2020 18:13, Mark Brown wrote:
> On Fri, Feb 21, 2020 at 02:23:57PM +0100, Marek Szyprowski wrote:
>> On 21.02.2020 13:38, Mark Brown wrote:
>>> We could just remove the compatible strings from the binding
>>> documentation, they won't do any harm if we don't use them.
>> Frankly I have no strong opinion on this. I've just wanted to fix the
>> broken autoloading of the drivers compiled as modules.
> Shouldn't adding the relevant module table for the platform devices work
> just as well for that? Possibly also deleting the of_compatible bits in
> the MFD as well, ISTR that's needed to make the platform device work.
Right. This will work too. MFD cells will match to their drivers by the
name and modalias strings will be correct. The question is which
approach is preffered? Krzysztof? I've checked other mfd drivers, but I
cannot find any pattern in this area.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2020-02-24 14:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200220145134eucas1p288ae1910d3e8d12dc12f010ed0b07b45@eucas1p2.samsung.com>
2020-02-20 14:51 ` Marek Szyprowski
[not found] ` <CGME20200220145135eucas1p123c4e4523e7e6eb86b64e728d6931cee@eucas1p1.samsung.com>
2020-02-20 14:51 ` [PATCH 2/3] extcon: " Marek Szyprowski
2020-03-14 18:45 ` Krzysztof Kozlowski
[not found] ` <CGME20200220145135eucas1p1ba181cef65c7a4f91a254ee35e022f08@eucas1p1.samsung.com>
2020-02-20 14:51 ` [PATCH 3/3] power: charger: " Marek Szyprowski
2020-03-14 18:45 ` Krzysztof Kozlowski
2020-05-10 16:54 ` Sebastian Reichel
2020-02-20 16:56 ` [PATCH 1/3] regulator: " Mark Brown
2020-02-21 10:44 ` Marek Szyprowski
2020-02-21 12:38 ` Mark Brown
2020-02-21 13:23 ` Marek Szyprowski
2020-02-21 17:13 ` Mark Brown
2020-02-24 14:08 ` Marek Szyprowski [this message]
2020-02-24 20:12 ` Krzysztof Kozlowski
2020-03-06 13:51 ` Marek Szyprowski
2020-03-14 18:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61dc8192-e313-021f-9e23-928257a66984@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®