From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Patrick Williams <patrick@stwcx.xyz>
Cc: "Delphine CC Chiu" <Delphine_CC_Chiu@wiwynn.com>,
"Avi Fishman" <avifishman70@gmail.com>,
"Tomer Maimon" <tmaimon77@gmail.com>,
"Tali Perry" <tali.perry1@gmail.com>,
"Patrick Venture" <venture@google.com>,
"Nancy Yuen" <yuenn@google.com>,
"Benjamin Fair" <benjaminfair@google.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
openbmc@lists.ozlabs.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: arm: nuvoton: add Facebook Yosemite 4 board
Date: Fri, 12 Jan 2024 18:46:13 +0100 [thread overview]
Message-ID: <61df52a3-860f-4813-9a71-72ab6be2d559@linaro.org> (raw)
In-Reply-To: <ZaF56lwEi1MES89Q@heinlein.vulture-banana.ts.net>
On 12/01/2024 18:42, Patrick Williams wrote:
> On Fri, Jan 12, 2024 at 06:14:26PM +0100, Krzysztof Kozlowski wrote:
>> On 12/01/2024 18:10, Patrick Williams wrote:
>>> On Fri, Jan 12, 2024 at 08:10:25AM +0100, Krzysztof Kozlowski wrote:
>>>> On 12/01/2024 02:36, Delphine CC Chiu wrote:
>>>>> Document the new compatibles used on Facebook Yosemite 4.
>>>>
>>>> There is Yosemite4 board already supported. What is this for?
>>>> https://lore.kernel.org/all/20240109072053.3980855-5-Delphine_CC_Chiu@wiwynn.com/
>>>
>>> Yosemite4 is a server chassis which is managed by a BMC. The BMC is on
>>> a pluggable module card. Typically we've used Aspeed chips for this,
>>> but we are building an alternative BMC module using Nuvoton BMC chips.
>>
>> There are few ways to solve this, like having different compatibles or
>> having some shared compatibles to note common part of hardware. However
>> usually the final compatible represents the final device, which here you
>> use for two entirely different products. This works only for the cases
>> of carrier boards, where that compatible indeed represents the same
>> hardware.
>>
>> Not your case. This needs fixing.
>
> This patch:
> + model = "Facebook Yosemite 4 BMC";
> + compatible = "facebook,yosemite4-n-bmc", "nuvoton,npcm845";
>
> Aspeed patch:
> + model = "Facebook Yosemite 4 BMC";
> + compatible = "facebook,yosemite4-bmc", "aspeed,ast2600";
>
> These have different compatibles already ('-n' for Nuvoton). Do we just
> need the model to be clearly different also? Maybe there is something
> else I'm not understanding.
Ah, no, it's fine. It is just a bit confusing.
However commit msg for sure misses a lot of this explanation. Please
write something useful to avoid such discussions...
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-12 17:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 1:36 [PATCH v1 0/2] dts: nuvoton: Add initial yosemitev4 device Delphine CC Chiu
2024-01-12 1:36 ` [PATCH v1 1/2] dt-bindings: arm: nuvoton: add Facebook Yosemite 4 board Delphine CC Chiu
2024-01-12 7:10 ` Krzysztof Kozlowski
2024-01-12 17:10 ` Patrick Williams
2024-01-12 17:14 ` Krzysztof Kozlowski
2024-01-12 17:42 ` Patrick Williams
2024-01-12 17:46 ` Krzysztof Kozlowski [this message]
2024-01-12 1:36 ` [PATCH v1 2/2] ARM64: dts: nuvoton: Add initial yosemitev4 device tree Delphine CC Chiu
2024-01-12 7:12 ` Krzysztof Kozlowski
2024-01-13 1:17 ` kernel test robot
2024-01-13 10:27 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61df52a3-860f-4813-9a71-72ab6be2d559@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Delphine_CC_Chiu@wiwynn.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=patrick@stwcx.xyz \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®