From: "Ming Qian(OSS)" <ming.qian@oss.nxp.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-media@vger.kernel.org, mchehab@kernel.org,
hverkuil-cisco@xs4all.nl, nicolas@ndufresne.ca,
benjamin.gaignard@collabora.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de,
sebastian.fricke@collabora.com, shawnguo@kernel.org,
ulf.hansson@linaro.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, m.felsch@pengutronix.de,
fra.schnyder@gmail.com, linux-imx@nxp.com,
l.stach@pengutronix.de, Frank.li@nxp.com, peng.fan@nxp.com,
eagle.zhou@nxp.com, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] media: verisilicon: Fix kernel panic due to __initconst misuse
Date: Fri, 6 Mar 2026 10:47:02 +0800 [thread overview]
Message-ID: <61e260e0-4544-4c51-99bf-c4815367fa94@oss.nxp.com> (raw)
In-Reply-To: <CAOMZO5BP2aLD+a1r7hVd3F4Qvfovxb8PgQfzcVRKknBHWYBmtg@mail.gmail.com>
Hi Fabio,
On 3/6/2026 10:38 AM, Fabio Estevam wrote:
> On Thu, Mar 5, 2026 at 11:26 PM <ming.qian@oss.nxp.com> wrote:
>
>> - { /* sentinel */ }
>> + { /* sentinel */ },
>
> Drop this change. It is unrelated.
But without this, the checkpatch.pl will report error:
ERROR: missing sentinel in ID array
#50: FILE: drivers/media/platform/verisilicon/imx8m_vpu_hw.c:346:
+static const struct of_device_id imx8mq_vpu_shared_resources[] = {
{ .compatible = "XXXXXXXXXXXXXXXXX", },
{ .compatible = "XXXXXXXXXXXXXXXXX", },
{ }
total: 1 errors, 0 warnings, 8 lines checked
====checkpatch ERROR, please correct it====
I've found two methods to fix this error.
- Add commas
- Remove "/* sentinel */"
Regards,
Ming
next prev parent reply other threads:[~2026-03-06 2:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 2:24 ming.qian
2026-03-06 2:38 ` Fabio Estevam
2026-03-06 2:47 ` Ming Qian(OSS) [this message]
2026-03-06 2:50 ` Fabio Estevam
2026-03-06 2:52 ` Ming Qian(OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61e260e0-4544-4c51-99bf-c4815367fa94@oss.nxp.com \
--to=ming.qian@oss.nxp.com \
--cc=Frank.li@nxp.com \
--cc=benjamin.gaignard@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eagle.zhou@nxp.com \
--cc=festevam@gmail.com \
--cc=fra.schnyder@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.fricke@collabora.com \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®