From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14471EB64DA for ; Tue, 18 Jul 2023 16:00:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233105AbjGRQAF (ORCPT ); Tue, 18 Jul 2023 12:00:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230358AbjGRQAC (ORCPT ); Tue, 18 Jul 2023 12:00:02 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9570BA9; Tue, 18 Jul 2023 09:00:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=dJdVI+HJD2/UVgoLMR8qdH9UF1GM2w8otTeZ/dU1gw8=; b=F/Po9REBvbRL8oamvsvOjdMTa+ /5gQ/eSypeh4nzLeD+6rPz2aNgis9Y4MDFKRVvj8E4eF1JdgRg8HW8+wjzCdn+eMSrpGhtQKyWz3z 4/+z1JrFiJY4Yo4dfZ8dD4+4hlGo0fJQN0f9udkULxqujJf+GNpXpSZ8Opp29jtKE1hk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qLn75-001dXJ-Ef; Tue, 18 Jul 2023 17:59:47 +0200 Date: Tue, 18 Jul 2023 17:59:47 +0200 From: Andrew Lunn To: Ante Knezic Cc: olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, f.fainelli@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com Subject: Re: [PATCH net-next v2] net: dsa: mv88e6xxx: Add erratum 3.14 for 88E6390X and 88E6190X Message-ID: <61e40941-5e2b-48b5-bbc4-fdd94967aaf1@lunn.ch> References: <20230718150133.4wpnmtks46yxg5lz@skbuf> <20230718152512.6848-1-ante.knezic@helmholz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230718152512.6848-1-ante.knezic@helmholz.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I don't think so. The erratum from the patch needs to be applied on each > SERDES reconfiguration or reset. For example, when replugging different > SFPs (sgmii - 10g - sgmii interface). Erratum 4_6 is done only once? > My guess is to put it in mv88e639x_sgmii_pcs_post_config but still I > need the device product number You might be able to read the product number from the ID registers of the SERDES, registers 2 and 3 ? That is kind of cleaner. It is the SERDES which needs the workaround, so look at the SERDES ID ... - maybe embedding a pointer to the > mv88e6xxx_chip chip inside the mv88e639x_pcs struct would be the cleanest way. That would also work. Andrew