From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753010AbcISVLU (ORCPT ); Mon, 19 Sep 2016 17:11:20 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:34141 "EHLO mail-io0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752151AbcISVLT (ORCPT ); Mon, 19 Sep 2016 17:11:19 -0400 Subject: Re: [PATCH] blk-throttle: fix infinite throttling caused by non-cascading timer wheel To: Vivek Goyal References: <1473662730-184701-1-git-send-email-houtao1@huawei.com> <20160913134646.GA19320@redhat.com> <20160919210645.GE12537@redhat.com> Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo , Thomas Gleixner , Hou Tao From: Jens Axboe Message-ID: <61ec807a-96ed-5363-7e0c-0ee46c3b70f4@kernel.dk> Date: Mon, 19 Sep 2016 15:11:10 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160919210645.GE12537@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/19/2016 03:06 PM, Vivek Goyal wrote: > On Tue, Sep 13, 2016 at 09:46:46AM -0400, Vivek Goyal wrote: >> >> Hi Hou Tao, >> >> [ CC Tejun and Thomas ] >> >> Thanks for the patch. I can reproduce it. I am wondering that why are you >> doing so many checks. Can't we just check if throttle group is empty or >> not. If it is empty and slice has expired, then start a new slice. If >> throttle group is not empty, then we know slice has to be an active slice >> and should be extended (despite the fact that it might have expired >> because timer function got called later than we expected it to be). >> >> Can you please try following patch. It seems to resolve the issue for me. >> >> Vivek > > Hi Jens, > > Can you please pick this patch. It seems to fix the reported issued. > Please let me know if you prefer a separate posting. I'll apply it, thanks Vivek. -- Jens Axboe