From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D374322ACEB for ; Fri, 13 Feb 2026 16:46:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771001217; cv=none; b=HUVMhcFzniVLWasuf6vQGfHXW3Y328XhTCrdq18S8pxoSskju75A3AMrtFmvz7dU0CxyrypMsYVw6QQHKXd35JysIo3hVMv/iPTuImR9eLSy/rKY8KGQnESov3sEwzt4xNdm1pe2zIG1MRXxiplhgc4TcU7tAO3X227TAtQHYjI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771001217; c=relaxed/simple; bh=TEDdPlaEpnW7WaNXhFAsw4ldmvR29Oedig7dlA21uFw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ohPN8N4QycyYkiXGEz2iJLHyhAw6gZjshaHxtNNo+HaZbYYTHHdkjQ3Y7z0xCUgZuTeh611jmTbREJ8q9RBQBRds+XQqOb0iZ3+y2rO8dzCxrYXMJCC9ki3wqtKmThmDvbaSqAyTs4qLVW9hAf50HXYTk5jVkRyB13D+0fWI6nU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V5gX8JfU; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V5gX8JfU" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48372efa020so6808615e9.2 for ; Fri, 13 Feb 2026 08:46:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771001214; x=1771606014; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=TuMWoNcNJvwge2oM1K5CKUPuWI2oL9A2iyuZQ+8bSTk=; b=V5gX8JfUqgRJdyMSycwBm4aAcYbm5s0oPdlrIdS5PNuj7zhK1EBMZYGwkph4LsFmrU RqlbI7kXjpu5WLSrFCLAy3n4lo2CH36/AHPdowI9Ti9d1N2y/T1jOxoM/R6ssvLEMycv dGGZLS3h5mLFZwvk3JsqVHaGAAkcNaPOjVHIlEqnonR7emyqrEfwgPtLnd/Wv1mNg4yE CLUx+X7UeUEK1rU/YX4RCA4kbv1RblShxLlEo/hMtgXpOpdQskbEz0OuqHeSHXogJLDE N/D7DJGxpWcZcb7apkcKay19jHHaQmsG099xpYqBzVatTX1W6FhBj2b1s2FZUe94VKF1 ySSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771001214; x=1771606014; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TuMWoNcNJvwge2oM1K5CKUPuWI2oL9A2iyuZQ+8bSTk=; b=XlF00XBlOJMw+hpulMQDXUORAWGIEJ4y5YblSb8Ul1pxBJaRcLp3OXB5wtIHAqA+3E 0b89UZh6qvVtpVgaCP61+V8BWjBy1HlzSlTrlNy/wY9FUkel/kqreiXlt/APzpNVHEF+ i1qlyIpwFO1L+1bOT6/bZ0po0k/7zzYNOTzTIZX31YF6uX5F9vRRiq9deoUQ/EMC0o8a FhViAN1PIa1w3+zM8AkSi+/tzq3ZeJDHXEzwa5WprxQzD/pnqwgytRX6bxNFlDZbiuxs P/qux3CRUs4yPbahnl8s1CyX49GduzeBqIlUX3mkSf6LmuWqkz1XBVpiB85IUeeqShx1 eZ1w== X-Forwarded-Encrypted: i=1; AJvYcCUGvp3o7qc4QoTj8oIcLBwKErGVg7hcoVQ9TEDkE6H1DUjL5rlogvXqCYObcgPGMwAmYmstU//0asfL89o=@vger.kernel.org X-Gm-Message-State: AOJu0YwsxWnbaBYDntzh8Nw46sKK6dbxFBSn0wvGZ/0KC9toqQIK4f0H MGuOf5CMiU1CK2M8BqJVNZGVEXmoSw3wh7dWZN+vsCs55eEVVxiYP5Gu X-Gm-Gg: AZuq6aLrK8Wt3LJ2aE5RYWrVOqxhzly149DAEnSzEZqrIQpaVQKOQJHkUjvfm4ByAkG BiJWW18hlenSAo7PJ5nhqLmatiB85rxq23HTmX+Sl3ct67bSbG/4DKULQgaucUJyrphlfxkbUZg WPT/DEQiDVDSTbdUo0qKaypsRda4cMTBVkabx26T0MaIWLOrMH2sj0QWoox+kfujKdEqoelp3hp VWmV0BsVvOT0f+1tOs7oqfEJ4nncfQ/FM3LvCoyuSMRvMe9zHUplv1zJPbaVoxDoxYv6OlLZPWX hVDQwZIPhGbV79mutz3tCLORjxpcsJplVeims6NYVGH3ThpQxzzE2wbIHuJm1CGRqm+Ac+NBsDq WbrYfsKhKObdhXVLjJagApjywLDjU6jC/ZXpZrFHzW2ZMd2n5GD9060eDcpM56oNSdZqT0H9pC/ jQjVBe5uQw85IhQp44IZrxgGmitAuVc/c= X-Received: by 2002:a05:600c:4753:b0:477:561f:6fc8 with SMTP id 5b1f17b1804b1-48373a15e72mr43771295e9.5.1771001214115; Fri, 13 Feb 2026 08:46:54 -0800 (PST) Received: from [192.168.1.187] ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48371a34d66sm24238785e9.20.2026.02.13.08.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 08:46:53 -0800 (PST) Message-ID: <61edeb390553a8e7419a8cce6d92af53123b9960.camel@gmail.com> Subject: Re: [PATCH] iio: adc: ad7768-1: Fix ERR_PTR dereference in ad7768_fill_scale_tbl From: Nuno =?ISO-8859-1?Q?S=E1?= To: Ethan Tidmore , Jonathan Cameron , Jonathan Santos Cc: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 13 Feb 2026 16:47:36 +0000 In-Reply-To: <20260213031207.21291-1-ethantidmore06@gmail.com> References: <20260213031207.21291-1-ethantidmore06@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2026-02-12 at 21:12 -0600, Ethan Tidmore wrote: > The function iio_get_current_scan_type() can return ERR_PTR, the return > value scan_type is not checked for this and immediately dereferenced > which can cause a kernel panic. >=20 > Add check for IS_ERR() and return early to avoid crash. >=20 > Fixes: ff085189cb17 ("iio: adc: ad7768-1: add support for ADAQ776x-1 ADC = Family") > Signed-off-by: Ethan Tidmore > --- > =C2=A0drivers/iio/adc/ad7768-1.c | 5 +++++ > =C2=A01 file changed, 5 insertions(+) >=20 > diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c > index fcd8aea7152e..f45a09e39367 100644 > --- a/drivers/iio/adc/ad7768-1.c > +++ b/drivers/iio/adc/ad7768-1.c > @@ -541,6 +541,11 @@ static void ad7768_fill_scale_tbl(struct iio_dev *de= v) > =C2=A0 u64 tmp2; > =C2=A0 > =C2=A0 scan_type =3D iio_get_current_scan_type(dev, &dev->channels[0]); > + if (IS_ERR(scan_type)) { > + dev_err(&st->spi->dev, "Failed to get scan type.\n"); > + return; > + } > + With the above, it could make sense to change the function to propagate the= error back... - Nuno S=C3=A1 > =C2=A0 if (scan_type->sign =3D=3D 's') > =C2=A0 val2 =3D scan_type->realbits - 1; > =C2=A0 else