From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDBC02FD1B3 for ; Fri, 13 Mar 2026 12:16:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773404199; cv=none; b=dE4DJCwGt/Kht/xs4TGEXNitTOWlmMNgWtD2N1UoKexDMvWTWlZlr3mAwy2X6MZaZFj9YTVcFQQZFSkAk+ViSGFzguU3GAa28X1YDn/qoUnBH5lYtcU1AYGiS+jVZevpUkibix+XIoc4TIeePH123kbnTE++NEwz2rUn3SPxBZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773404199; c=relaxed/simple; bh=xEfIqwAvCrIzypzvqBGix1qsgoiR+HtZqXThTD/h2uU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WZwgiGt/u6JXYy4lUWRRId1+lvueT2X1NOe8nmqbExRrdXinIThRD9iZOyA4vcjdStFbQpe/5h9UJkFiKT+iExz6swJLuLDXnE60s2+slkH0rauLQtOzbrUQbIIZmwp+n7MDjZ2l+4VtlP1fYsUSie8PO+Kj19tTbOpvGwXoyGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fm4GDGgT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jJ7RVREI; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fm4GDGgT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jJ7RVREI" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62DAseMU530519 for ; Fri, 13 Mar 2026 12:16:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NNUJ5IqCd3Oqw2HL5xxF4SqfTaOfSP4PBNslwEEXpYU=; b=fm4GDGgToa6BwCsg LD53b8aNpBwPg58vBnnMM4I3WVWBL72R0fmGc6nOIijaBetaoQ0qC4O4xpmk5JYu He8F/9eCAiO9sPgMDYGRgMIQ8UZ8USgiYz9pG7OHY/S4sX92GqLYnkJQDoJaPiBT ZSdkWxiEa7xqOCNUoNpM2Fp0f8LYm+k10WA8vBiCP2eQWb/ugT2qI2oBfdX5sHTH O+24EZGo0KLtbbAHBn+1+JIM+VTiKsLINsoG6ov6akxgVLH5beQsJhAX/GaIQQsf /g8gRyTa41lcJwtnLOXUoB+H+diHMKR23HFif4B9FNPQmcFXf4wuyWfu5/NMUVsC 9cNndw== Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvh84r7bu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 12:16:36 +0000 (GMT) Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-7d7510702e6so19173454a34.3 for ; Fri, 13 Mar 2026 05:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773404196; x=1774008996; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NNUJ5IqCd3Oqw2HL5xxF4SqfTaOfSP4PBNslwEEXpYU=; b=jJ7RVREItRU7hV4o/O11BP8sRP9aELG8qgVn8JigFhBKCwcIX4/x/QuP+hCAO6B41p Hd7JXCJanJMogrCj/zzFSOKxQYaxjSHusf1SuMvg5baxsWhVtUwgr8HE8nx5SmiWe3+S B8il6TJScEkoJKpZUQKDbYYSpXwnuVKVPO1hU0yDbA1DAS6mbrydOaA+kLQiPA0kpcoM Xr0ZbacyuWbp8rauntCbo3+FhPJ19R1lV/S0xhdR2ImZ53bKtyBtaAEe/0+MMe7KDj4x jBXmo21/4Uitj0lE+4p0ttwQrXxeexxzUyQzFrtbhR8PtFVdV/fAfvYG3f5FG+MHq27Z nyoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773404196; x=1774008996; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NNUJ5IqCd3Oqw2HL5xxF4SqfTaOfSP4PBNslwEEXpYU=; b=Ic36JCnkxsOFa0//CytmcQnNZlerKRRl4DHmI2xOflp4zlPjDeIiHEptj1usDz66Ds voi+Ab8OH24tpjUDRyf1POJ/GdehsARWaJzVogcedcsj5ZB7PtqJQXAO3utXrfmBfZHb FpYpHNaPFHzDHM4cm50OxlldcyCjg/CaC3fG815PdPl9yB9J1+Vo8epAbmQMkrB9Cemw f2TmweFHmj1c4CSHs4xfl2VwrVG3iG4orptupLNr9bzUc92Adph4DlAhCl/gXBoiLGsW JKGUOYq8Qf+VT0NJNftAgmlRqVN2xs6ywH95W+hatswIDXZSscZexSMBClmWKIc1Dk8V /BpA== X-Gm-Message-State: AOJu0YyMGpsI4V0H978h8Ba7a6WYRjV+vkkrE9H1eLlafMbUumLKNHbW 9age0QLPQV5B7EdWWZux4PD3QNBqb9gmRSqTEL/1+YVphqyEqGD9CyqUPk+P5iFLsxT5gWGo/Hg hWs4nGX9Iz5ww1ESNqGBircwcMurBHZnn5nNxj4vUYqEFW6aI2+37LQAP1Yi1J4YEZXU= X-Gm-Gg: ATEYQzw9RFD3nkOWFu/6Kzdi887O1LW5roWmgVfa/jp9kf9dIzplhv3Iqect9Sn8J+4 fp/T7dX96VViZVwAIQEdHSUc8Eu02Xrl2S9lcFWiqxmC5JSR+fTr966H0Pi46p4GGm1x8OWMner wSCe0Q0TjyzKcs41XhNb14GtxfB0qPRhIehw8JzokrHZ5MmwmGM/cnGToR/lc9wLcrXRWxxGwDP WwdE8xLYhPBB8vX5CpN9Y3EsGG6wknP4rUtj25Y/Vpjr2eilBsaffKnAyRVAo6keIfk0+XNGd8B qsGJbLfE14Oa53FD5DrhXEPDDmo5mbNuWqChOhVCGjG60/4YmLzKSRozqKIqvIhj56YLty3+bQ+ DJHldcWp9Oa+rZjWfUcCrrl8ppCLGNr3oZNkHjEEDKHeNq0I= X-Received: by 2002:a05:6830:710f:b0:7d7:57c4:365e with SMTP id 46e09a7af769-7d78251bf42mr2068136a34.18.1773404196352; Fri, 13 Mar 2026 05:16:36 -0700 (PDT) X-Received: by 2002:a05:6830:710f:b0:7d7:57c4:365e with SMTP id 46e09a7af769-7d78251bf42mr2068106a34.18.1773404195995; Fri, 13 Mar 2026 05:16:35 -0700 (PDT) Received: from [10.239.97.158] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d76ac8975csm6132745a34.8.2026.03.13.05.16.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 05:16:35 -0700 (PDT) Message-ID: <61eea507-1cdc-45f2-b688-a4719e79107e@oss.qualcomm.com> Date: Fri, 13 Mar 2026 20:16:29 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] Bluetooth: btusb: Allow firmware re-download when version matches To: Marcel Holtmann , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, cheng.jiang@oss.qualcomm.com, quic_chezhou@quicinc.com, wei.deng@oss.qualcomm.com, jinwang.li@oss.qualcomm.com, mengshi.wu@oss.qualcomm.com References: <20260108074353.1027877-1-shuai.zhang@oss.qualcomm.com> Content-Language: en-US From: Shuai Zhang In-Reply-To: <20260108074353.1027877-1-shuai.zhang@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=OMoqHCaB c=1 sm=1 tr=0 ts=69b40024 cx=c_pps a=z9lCQkyTxNhZyzAvolXo/A==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=XLcW7MSiMK0kOx3OsRAA:9 a=QEXdDO2ut3YA:10 a=EyFUmsFV_t8cxB2kMr4A:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA5NyBTYWx0ZWRfX+SjeGln/jVU6 /0ERg3c20jaSKTs9dMAxqB8zT4zQnc0pO3aoGQ73dohZ7aH0uHZJMp8s9rs0h2QgabCCjxLJ/Ev RD5Iy82PNER0jKzlWlnjfKhjgIFJm7ALog7qysgJICtlWUb2GPX5FjQfscOY94c8FBBWvZ6tZX5 gDIbBoUDgPVgQ8q02I9hvkO8O7JZrEt/POkA4+rPZfQUXKMTjZEBmu6zow5lciAnefSA5ooe/Hy 9K9R8Nup7OLErIiLQhc3Pf48Q9wv5c0V63XpeQSE6+PAka83nuotiJZvtLpwVJK8FlAis8Q9wPi xx44LsvHonYSaKRhy4OLykAal3X/DeQSb6ZAZ2WyuP4VHYSC2LL1JF/QdMe9x8KeHZrql2WKjks Ce3X5ux+Xb9N514PFR017nCTqBlCDcK0Bg/ACXddfW3cEEdhNWqkAp+mbF0foTOx+mtIhU63Y16 wystkqYgEmoY9KjZqvg== X-Proofpoint-ORIG-GUID: 0LRyP5-roeBBH87Kd-DMMpyseABFmkAJ X-Proofpoint-GUID: 0LRyP5-roeBBH87Kd-DMMpyseABFmkAJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_02,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130097 Hi reviewer, On 1/8/2026 3:43 PM, Shuai Zhang wrote: > Since USB can disconnect at any time, if it disconnects during > the BT firmware download, the BT controller firmware version may still > be updated even without completing the download. > > When USB reconnects, the BT host detects the same version as in the > firmware file, which prevents the firmware from being downloaded again. > > Therefore, remove the equality check to ensure that after > USB reconnection, the BT host can still download the firmware. > > Signed-off-by: Shuai Zhang > --- > drivers/bluetooth/btusb.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index 646de80c7..991064a25 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -3503,7 +3503,10 @@ static int btusb_setup_qca_load_rampatch(struct hci_dev *hdev, > "firmware rome 0x%x build 0x%x", > rver_rom, rver_patch, ver_rom, ver_patch); > > - if (rver_rom != ver_rom || rver_patch <= ver_patch) { > + /* Allow rampatch if version is greater than or equal to firmware version. > + * Equal versions are acceptable for re-flashing or recovery scenarios. > + */ > + if (rver_rom != ver_rom || rver_patch < ver_patch) { > bt_dev_err(hdev, "rampatch file version did not match with firmware"); > err = -EINVAL; > goto done; If there are any updates, please let me know. Thanks, Shuai