From: Paolo Bonzini <pbonzini@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Mao Wenan <maowenan@huawei.com>,
rkrcmar@redhat.com, sean.j.christopherson@intel.com,
wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] KVM: x86: remove set but not used variable 'called'
Date: Thu, 21 Nov 2019 10:13:23 +0100 [thread overview]
Message-ID: <61f534ca-7575-6716-10ec-ac5c92258452@redhat.com> (raw)
In-Reply-To: <20191119121423.GB5604@kadam>
On 19/11/19 13:14, Dan Carpenter wrote:
>> Better expressed as
>>
>> Fixes: 7ee30bc132c6 ("KVM: x86: deliver KVM IOAPIC scan request to target vCPUs")
>
> There is sort of a debate about this whether the Fixes tag should be
> used if it's only a cleanup.
The other debate is whether this is a cleanup, since the build is broken
with -Werror. I agree that code cleanups generally don't deserve Fixes
tags, but this patch IMHO does.
Paolo
next prev parent reply other threads:[~2019-11-21 9:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 3:06 Mao Wenan
2019-11-19 11:58 ` Vitaly Kuznetsov
2019-11-19 12:14 ` Dan Carpenter
2019-11-19 12:28 ` Vitaly Kuznetsov
2019-11-19 12:39 ` Dan Carpenter
2019-11-19 13:25 ` Vitaly Kuznetsov
2019-11-22 11:58 ` Nitesh Narayan Lal
2019-11-22 12:25 ` Dan Carpenter
2019-11-22 12:45 ` Nitesh Narayan Lal
2019-11-21 9:13 ` Paolo Bonzini [this message]
2019-11-22 0:48 ` maowenan
2019-11-22 2:39 ` [PATCH -next v2] " Mao Wenan
2019-11-19 12:42 ` [PATCH -next] " maowenan
2019-11-19 13:27 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61f534ca-7575-6716-10ec-ac5c92258452@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=dan.carpenter@oracle.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maowenan@huawei.com \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®