From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E6AE4503B for ; Thu, 20 Nov 2025 08:14:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763626490; cv=none; b=tRmAXU0iyPXQPiqVRNEQCCAVGA77LLvmKIk8d+1nzGcpaUf7OxAhw59/bn1HHP0Fhea/ZaZJkDLBJLVTg9a/FbMcRxxg9DN3bYkkEh5Ds39Y1RgVnUYnIkbXlFLK/V1p9m8A1s5w3JpS668VCIjiVEROEj1ZUXnCpQ1jIR/ZOcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763626490; c=relaxed/simple; bh=4M3rIlDgfGY2KP0GGEpH34NIuXvhKUUboZiFUNvEWSA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P13LGCNhDoKBaSkOoG/+0PJhXoc5I/bmCx7CVhaW8VT5qDt+O9+e7eqpBIlHdx5MOorQdj2ceUByz0pfp+pWQAfXoL/jKaPa+iWWtvqSviV8/b2Am2vxv9l/hiaR+BOTiQs+aeaJC+pD3LX+6/x1nw5y0MkwaurNxXtK+Hr/Bj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=zO53s/w0; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="zO53s/w0" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 654AB4E417DD; Thu, 20 Nov 2025 08:14:44 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 2888D6068C; Thu, 20 Nov 2025 08:14:44 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 2463810371BE5; Thu, 20 Nov 2025 09:14:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1763626483; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=04pEPH5W1KZzvKj2XXuseVAsQtkSJz6OArHi5Tto5KU=; b=zO53s/w0VCdf+TA3nqmIBY3AO6g2hAcIA8DYJg+Ur8lzFILy38/OMfKYSQ+ZWW4du3nKeG TaIzz/Lc8SeReN6qrxdnf52ZQqv8Styxa8pscrO72QV9f0PKjdMWJsxF8dHVlTD+0AMOnX vs1Bdl3BLh5uSif2yxUad37+pzs0McyAq9JMmw6audHClyPHRmRJkFDnD3EYimer8auZhK pme+Y01qHFkt3vlfXUqplZ2pvegrCpRugViRQTqsIVXvmORw8N1mWZsglY+BAaozClZoKG d5DoLtYlP73V22dpwdFeNsQ07vPVl4hhxer5xnFxmeFSlwzUHiE9ZbIVxpWCbQ== Message-ID: <61f73cda-b3d8-44da-a210-34ea15888d24@bootlin.com> Date: Thu, 20 Nov 2025 09:14:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v17 03/15] net: phy: Introduce PHY ports representation To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?Q?K=C3=B6ry_Maincent?= , =?UTF-8?Q?Marek_Beh=C3=BAn?= , Oleksij Rempel , =?UTF-8?Q?Nicol=C3=B2_Veronese?= , Simon Horman , mwojtas@chromium.org, Antoine Tenart , devicetree@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski , Rob Herring , Romain Gantois , Daniel Golle , Dimitri Fedrau References: <20251119195920.442860-1-maxime.chevallier@bootlin.com> <20251119195920.442860-4-maxime.chevallier@bootlin.com> <20251119195400.1bf0cc68@kernel.org> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <20251119195400.1bf0cc68@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 20/11/2025 04:54, Jakub Kicinski wrote: > On Wed, 19 Nov 2025 20:59:04 +0100 Maxime Chevallier wrote: >> diff --git a/net/ethtool/common.c b/net/ethtool/common.c >> index 2f4b70f104e8..8216e4ada58e 100644 >> --- a/net/ethtool/common.c >> +++ b/net/ethtool/common.c >> @@ -460,6 +460,21 @@ const struct link_mode_info link_mode_params[] = { >> static_assert(ARRAY_SIZE(link_mode_params) == __ETHTOOL_LINK_MODE_MASK_NBITS); >> EXPORT_SYMBOL_GPL(link_mode_params); >> >> +const char ethtool_link_medium_names[][ETH_GSTRING_LEN] = { >> + [ETHTOOL_LINK_MEDIUM_BASET] = "BaseT", >> + [ETHTOOL_LINK_MEDIUM_BASEK] = "BaseK", >> + [ETHTOOL_LINK_MEDIUM_BASES] = "BaseS", >> + [ETHTOOL_LINK_MEDIUM_BASEC] = "BaseC", >> + [ETHTOOL_LINK_MEDIUM_BASEL] = "BaseL", >> + [ETHTOOL_LINK_MEDIUM_BASED] = "BaseD", >> + [ETHTOOL_LINK_MEDIUM_BASEE] = "BaseE", >> + [ETHTOOL_LINK_MEDIUM_BASEF] = "BaseF", >> + [ETHTOOL_LINK_MEDIUM_BASEV] = "BaseV", >> + [ETHTOOL_LINK_MEDIUM_BASEMLD] = "BaseMLD", >> + [ETHTOOL_LINK_MEDIUM_NONE] = "None", >> +}; >> +static_assert(ARRAY_SIZE(ethtool_link_medium_names) == __ETHTOOL_LINK_MEDIUM_LAST); > > Thanks for reshuffling things, this one needs a static tho: > > net/ethtool/common.c:463:12: warning: symbol 'ethtool_link_medium_names' was not declared. Should it be static? hmpf I hesistated for some dumb reason... I'll respin after the usual cooldown. I'll keep Christophe's review tag though, as this is just adding the static keyword :) Maxime