From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2874CC43334 for ; Fri, 1 Jul 2022 11:54:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235892AbiGALys (ORCPT ); Fri, 1 Jul 2022 07:54:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233327AbiGALyp (ORCPT ); Fri, 1 Jul 2022 07:54:45 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1914583F06; Fri, 1 Jul 2022 04:54:44 -0700 (PDT) Received: from fraeml739-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LZD8G6YYHz6H6nM; Fri, 1 Jul 2022 19:52:14 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml739-chm.china.huawei.com (10.206.15.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 1 Jul 2022 13:54:41 +0200 Received: from [10.126.173.51] (10.126.173.51) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 1 Jul 2022 12:54:40 +0100 Message-ID: <61fbd71b-9c36-345c-7aed-561b81c34259@huawei.com> Date: Fri, 1 Jul 2022 12:54:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 From: John Garry Subject: Re: [PATCH v3] hisi_lpc: Use acpi_dev_for_each_child() To: Andy Shevchenko CC: "Rafael J. Wysocki" , Linux ACPI , LKML , "Andy Shevchenko" , Greg Kroah-Hartman , Yang Yingliang References: <12026357.O9o76ZdvQC@kreacher> <2657553.mvXUDI8C0e@kreacher> <5606189.DvuYhMxLoT@kreacher> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.173.51] X-ClientProxiedBy: lhreml712-chm.china.huawei.com (10.201.108.63) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/07/2022 12:07, Andy Shevchenko wrote: > On Fri, Jul 1, 2022 at 1:06 PM Andy Shevchenko > wrote: >> On Fri, Jul 1, 2022 at 1:04 PM John Garry wrote: >>> On 30/06/2022 19:13, Rafael J. Wysocki wrote: >> >> ... >> >>> However Yang Yingliang spotted a pre-existing bug in the ACPI probe and >>> sent a fix today (coincidence?): >>> >>> https://lore.kernel.org/lkml/20220701094352.2104998-1-yangyingliang@huawei.com/T/#u >>> >>> And they conflict. This code has been this way for years, so I just >>> suggest Yang Yingliang resends the fix on top off Rafael's change. >> >> Wondering if Yang can actually switch that to use >> platform_device_register_full(). Maybe that would work and simplify things. Let me check it. BTW, when we originally upstreamed this driver there was some ACPI platform device registration code which you/we thought could be factored out later. I can't remember it. I was looking through lore but couldn't find it. I don't remember it being so important, though. > > And for the record, I think the Fixes even for very rare bug hits > should go first. > ok, I have to admit that I was going to feel awkward asking Rafael to deal with this fix by having a v4 on top of it. Thanks, John