From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751825AbcFFNmy (ORCPT ); Mon, 6 Jun 2016 09:42:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49699 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320AbcFFNmx (ORCPT ); Mon, 6 Jun 2016 09:42:53 -0400 Subject: Re: [PATCH v3] sched/cputime: add steal time support to full dynticks CPU time accounting To: Ingo Molnar , Wanpeng Li References: <1463574454-3587-1-git-send-email-wanpeng.li@hotmail.com> <20160603071656.GA7466@gmail.com> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Wanpeng Li , "Peter Zijlstra (Intel)" , Rik van Riel , Thomas Gleixner , Frederic Weisbecker , Radim From: Paolo Bonzini Message-ID: <6205abed-bfe5-6e50-f5f9-31e85f2686e1@redhat.com> Date: Mon, 6 Jun 2016 15:42:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160603071656.GA7466@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 06 Jun 2016 13:42:53 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/06/2016 09:16, Ingo Molnar wrote: > > But I'm very annoyed that this was in v3 and still has so many trivial problems: > incredibly bad and confusing spelling, totally bad, fragile, apparently write-only > code - and I counted like three acks from 3 other people who should really know > better ... > > This is core scheduler code! I actually want to fix this in arch/x86/kernel/kvm.c. Please do not apply this patch. Thanks, Paolo