mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tom Lendacky <thomas.lendacky@amd.com>
To: Pavel Machek <pavel@denx.de>, "Allen, John" <John.Allen@amd.com>,
	"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: ccp - fix error handling
Date: Tue, 22 Sep 2020 08:41:06 -0500	[thread overview]
Message-ID: <620833c5-a2bf-852e-16f1-f8ed04bf8fea@amd.com> (raw)
In-Reply-To: <20200921113435.GA20450@duo.ucw.cz>

On 9/21/20 6:34 AM, Pavel Machek wrote:
> Fix resource leak in error handling.

Does it need a Fixes: tag?

Thanks,
Tom

> 
> Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
> 
> diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
> index bd270e66185e..40869ea1ed20 100644
> --- a/drivers/crypto/ccp/ccp-ops.c
> +++ b/drivers/crypto/ccp/ccp-ops.c
> @@ -1744,7 +1744,7 @@ ccp_run_sha_cmd(struct ccp_cmd_queue *cmd_q, struct ccp_cmd *cmd)
>  			break;
>  		default:
>  			ret = -EINVAL;
> -			goto e_ctx;
> +			goto e_data;
>  		}
>  	} else {
>  		/* Stash the context */
> 

  parent reply	other threads:[~2020-09-22 13:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21 11:34 Pavel Machek
2020-09-22 12:59 ` John Allen
2020-09-22 13:41 ` Tom Lendacky [this message]
2020-10-02 11:54 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=620833c5-a2bf-852e-16f1-f8ed04bf8fea@amd.com \
    --to=thomas.lendacky@amd.com \
    --cc=John.Allen@amd.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®