From: Shannon Nelson <sln@onemain.com>
To: Dawei Feng <dawei.feng@seu.edu.cn>
Cc: aleksandr.loktionov@intel.com, anthony.l.nguyen@intel.com,
przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jianhao.xu@seu.edu.cn, zilin@seu.edu.cn
Subject: Re: [PATCH net] i40e: fix netdev leak in i40e_vsi_setup() error paths
Date: Wed, 3 Jun 2026 08:37:31 -0700 [thread overview]
Message-ID: <620a9c51-604b-4622-a9a3-40f6a54e7aa6@onemain.com> (raw)
In-Reply-To: <20260603032822.763195-1-dawei.feng@seu.edu.cn>
On 6/2/26 20:28, Dawei Feng wrote:
> Hi Shannon,
>
> Thanks for the suggestion. I took a closer look at the cleanup paths, and
> I think the localized v1 fix is safer here.
>
> In particular, i40e_vsi_reinit_setup() has early failure paths that can
> reach i40e_vsi_clear() before unregister_netdev() is called. Moving
> free_netdev() into i40e_vsi_clear() could therefore free a
> still-registered netdev.
>
> So I plan to keep the current v1 approach for this fix, rather than moving
> free_netdev() into the common VSI teardown path.
>
> Best regards,
> Dawei
That sounds fine, thanks for looking.
sln
next prev parent reply other threads:[~2026-06-03 15:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 11:02 Dawei Feng
2026-05-28 8:49 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-05-28 17:57 ` Shannon Nelson
2026-05-30 2:30 ` Dawei Feng
2026-06-03 3:28 ` Dawei Feng
2026-06-03 15:37 ` Shannon Nelson [this message]
2026-06-01 9:19 ` [Intel-wired-lan] " Marcin Szycik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=620a9c51-604b-4622-a9a3-40f6a54e7aa6@onemain.com \
--to=sln@onemain.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=dawei.feng@seu.edu.cn \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jianhao.xu@seu.edu.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=zilin@seu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®