mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Lizhi Hou <lizhi.hou@amd.com>,
	ogabbay@kernel.org, quic_jhugo@quicinc.com,
	dri-devel@lists.freedesktop.org,
	maciej.falkowski@linux.intel.com
Cc: linux-kernel@vger.kernel.org, max.zhen@amd.com,
	sonal.santan@amd.com, Dan Carpenter <error27@gmail.com>,
	Wendy Liang <wendy.liang@amd.com>
Subject: Re: [PATCH V1] accel/amdxdna: Fix iommu_map_sgtable() return value handling
Date: Mon, 13 Apr 2026 13:27:20 -0500	[thread overview]
Message-ID: <620d8ae0-f219-4698-b8c3-72143e7cd30c@amd.com> (raw)
In-Reply-To: <20260413180238.668441-1-lizhi.hou@amd.com>



On 4/13/26 13:02, Lizhi Hou wrote:
> iommu_map_sgtable() returns negative error codes on failure, but the
> result is stored in an unsigned variable. This prevents proper error
> detection.
> 
> Change the variable type to ssize_t so negative error values can be
> handled correctly.
> 
> Fixes: ece3e8980907 ("accel/amdxdna: Allow forcing IOVA-based DMA via module parameter")
> Reported-by: Dan Carpenter <error27@gmail.com>
> Closes: https://lore.kernel.org/all/adk7kOUBwIyYnX1M@stanley.mountain/
> Signed-off-by: Wendy Liang <wendy.liang@amd.com>
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
> ---
>   drivers/accel/amdxdna/amdxdna_iommu.c | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/accel/amdxdna/amdxdna_iommu.c b/drivers/accel/amdxdna/amdxdna_iommu.c
> index 4626434d4180..2676cfcfabee 100644
> --- a/drivers/accel/amdxdna/amdxdna_iommu.c
> +++ b/drivers/accel/amdxdna/amdxdna_iommu.c
> @@ -40,7 +40,7 @@ int amdxdna_iommu_map_bo(struct amdxdna_dev *xdna, struct amdxdna_gem_obj *abo)
>   	struct sg_table *sgt;
>   	dma_addr_t dma_addr;
>   	struct iova *iova;
> -	size_t size;
> +	ssize_t size;
>   
>   	if (abo->type != AMDXDNA_BO_DEV_HEAP && abo->type != AMDXDNA_BO_SHMEM)
>   		return 0;
> @@ -65,7 +65,14 @@ int amdxdna_iommu_map_bo(struct amdxdna_dev *xdna, struct amdxdna_gem_obj *abo)
>   
>   	size = iommu_map_sgtable(xdna->domain, dma_addr, sgt,
>   				 IOMMU_READ | IOMMU_WRITE);
> +	if (size < 0) {
> +		XDNA_ERR(xdna, "iommu_map_sgtable failed: %zd", size);
> +		__free_iova(&xdna->iovad, iova);
> +		return size;
> +	}
> +
>   	if (size < abo->mem.size) {
> +		iommu_unmap(xdna->domain, dma_addr, size);
>   		__free_iova(&xdna->iovad, iova);
>   		return -ENXIO;
>   	}


  reply	other threads:[~2026-04-13 18:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13 18:02 Lizhi Hou
2026-04-13 18:27 ` Mario Limonciello [this message]
2026-04-14 16:16   ` Lizhi Hou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=620d8ae0-f219-4698-b8c3-72143e7cd30c@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=error27@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizhi.hou@amd.com \
    --cc=maciej.falkowski@linux.intel.com \
    --cc=max.zhen@amd.com \
    --cc=ogabbay@kernel.org \
    --cc=quic_jhugo@quicinc.com \
    --cc=sonal.santan@amd.com \
    --cc=wendy.liang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®