From: <Tudor.Ambarus@microchip.com>
To: <dan.carpenter@oracle.com>, <kbuild@lists.01.org>
Cc: <lkp@intel.com>, <kbuild-all@lists.01.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [ambarus:spi-nor/next-clean-v5 20/25] drivers/mtd/spi-nor/core.c:2720 spi_nor_init_params_deprecated() warn: should this be a bitwise op?
Date: Tue, 7 Dec 2021 07:52:05 +0000 [thread overview]
Message-ID: <620ec5c9-16c1-e29b-fb19-3006fc543151@microchip.com> (raw)
In-Reply-To: <202112062341.u7kBv9Hp-lkp@intel.com>
On 12/7/21 9:46 AM, Dan Carpenter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> tree: https://github.com/ambarus/linux-0day spi-nor/next-clean-v5
> head: d643e0f7de527f4ccf909025478949a961440ac8
> commit: d3c97258de8777fd69e982ff804b97a4fc3372a9 [20/25] mtd: spi-nor: core: Init all flash parameters based on SFDP where possible
> config: i386-randconfig-m021-20211206 (https://download.01.org/0day-ci/archive/20211206/202112062341.u7kBv9Hp-lkp@intel.com/config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> New smatch warnings:
> drivers/mtd/spi-nor/core.c:2720 spi_nor_init_params_deprecated() warn: should this be a bitwise op?
>
> vim +2720 drivers/mtd/spi-nor/core.c
>
> d3c97258de8777 Tudor Ambarus 2021-11-22 2714 static void spi_nor_init_params_deprecated(struct spi_nor *nor)
> d3c97258de8777 Tudor Ambarus 2021-11-22 2715 {
> d3c97258de8777 Tudor Ambarus 2021-11-22 2716 spi_nor_no_sfdp_init_params(nor);
> d3c97258de8777 Tudor Ambarus 2021-11-22 2717
> d3c97258de8777 Tudor Ambarus 2021-11-22 2718 spi_nor_manufacturer_init_params(nor);
> d3c97258de8777 Tudor Ambarus 2021-11-22 2719
> d3c97258de8777 Tudor Ambarus 2021-11-22 @2720 if ((SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_OCTAL_READ |
> d3c97258de8777 Tudor Ambarus 2021-11-22 2721 SPI_NOR_OCTAL_DTR_READ) &&
>
> Missing variable?
yes, indeed, thanks!
This branch is on my personal developing repo, it has not yet reached
linux-next. Will fix it locally.
Cheers!
ta
>
> d3c97258de8777 Tudor Ambarus 2021-11-22 2722 !(nor->info->no_sfdp_flags & SPI_NOR_SKIP_SFDP))
> d3c97258de8777 Tudor Ambarus 2021-11-22 2723 spi_nor_sfdp_init_params_deprecated(nor);
> d3c97258de8777 Tudor Ambarus 2021-11-22 2724 }
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>
prev parent reply other threads:[~2021-12-07 7:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 7:46 Dan Carpenter
2021-12-07 7:52 ` Tudor.Ambarus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=620ec5c9-16c1-e29b-fb19-3006fc543151@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=dan.carpenter@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®