mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Jeffrin Jose T <ahiliation@yahoo.co.in>,
	gregkh@linuxfoundation.org, daniel.diaz@linaro.org,
	thomas@m3y3r.de, pombredanne@nexb.com
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jeffrin Jose T <jeffrin@rajagiritech.edu.in>,
	Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] selftests: intel_pstate: Fixes for the testing script for Intel P-State driver
Date: Thu, 24 May 2018 10:41:06 -0600	[thread overview]
Message-ID: <620f060d-afab-e79c-43a6-3024d728157a@kernel.org> (raw)
In-Reply-To: <20180522170505.5846-1-ahiliation@yahoo.co.in>

Hi Jeffrin,

On 05/22/2018 11:05 AM, Jeffrin Jose T wrote:
> fix for notification of permission requirement to run test.
> fix for exit status value for test skipped.
> 
> Signed-off-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in>

The commit log doesn't match the commit summary. Please rephrase both the
commit summary and log to indicate why this fix is necessary.

Odd. I don't see your patch posted on the linux-kselftest patchwork and not
even on lkml archive. 

You signed off doesn't match your from. Are you using git send-email to send
patches?

thanks,
-- Shuah

  reply	other threads:[~2018-05-24 16:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22 17:05 Jeffrin Jose T
2018-05-24 16:41 ` Shuah Khan [this message]
2018-05-24 20:23   ` Jeffrin Thalakkottoor
  -- strict thread matches above, loose matches on Subject: below --
2018-05-10 18:49 Jeffrin Jose T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=620f060d-afab-e79c-43a6-3024d728157a@kernel.org \
    --to=shuah@kernel.org \
    --cc=ahiliation@yahoo.co.in \
    --cc=daniel.diaz@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeffrin@rajagiritech.edu.in \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=thomas@m3y3r.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome