From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755183Ab3BVCPO (ORCPT ); Thu, 21 Feb 2013 21:15:14 -0500 Received: from hydra.sisk.pl ([212.160.235.94]:41139 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753086Ab3BVCPM (ORCPT ); Thu, 21 Feb 2013 21:15:12 -0500 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com, linaro-dev@lists.linaro.org, francescolavra.fl@gmail.com, toddpoynor@google.com Subject: Re: [PATCH V2 1/4] cpufreq: Add per policy governor-init/exit infrastructure Date: Fri, 22 Feb 2013 03:21:51 +0100 Message-ID: <6210802.HjCYHcMl5j@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.8.0; KDE/4.9.5; x86_64; ; ) In-Reply-To: References: <3793606.bilcxohA80@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, February 22, 2013 07:38:12 AM Viresh Kumar wrote: > On 22 February 2013 05:05, Rafael J. Wysocki wrote: > > On Monday, February 11, 2013 01:20:00 PM Viresh Kumar wrote: > > >> This patch is inclined towards providing this infrastructure. Because we are > >> required to allocate governor's resources dynamically now, we must do it at > >> policy creation and end. And so got CPUFREQ_GOV_POLICY_INIT/EXIT. > > > > Are those new events NOPs now? > > No. These are used atleast for ondemand & conservative. They will be after the next patch, you mean? :-) > >> +#define CPUFREQ_GOV_POLICY_INIT 4 > >> +#define CPUFREQ_GOV_POLICY_EXIT 4 > > > > Why don't you use different values here? > > > > If you need only one value, one #define should be sufficient. > > Naah, something happened... I got fixed this locally but couldn't > get that into the commit somehow. EXIT should have 5 here. Well, it appeared so from the next patch ... Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.