From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757178Ab0IHAqN (ORCPT ); Tue, 7 Sep 2010 20:46:13 -0400 Received: from n10.bullet.mail.ac4.yahoo.com ([76.13.13.238]:38527 "HELO n10.bullet.mail.ac4.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755480Ab0IHAqI (ORCPT ); Tue, 7 Sep 2010 20:46:08 -0400 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 742157.2643.bm@omp132.mail.gq1.yahoo.com DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=pacbell.net; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:MIME-Version:Content-Type; b=LLjo6HfJUpZYEBzhAi33a7WnfbihxHZHgKfVWdandi3T1PsqKiznQHFSea3MHoYRd2gNAzAUKnTFeYdjqftRJ+hWnBq2QLIX291H+5/tMmVVq2y1juV5rGEpxMdMxKt8vFezEE216dtSkjlxng31A4q46OMuiehc1OHCXax9vI0=; Message-ID: <621591.67832.qm@web180301.mail.gq1.yahoo.com> X-YMail-OSG: fEEuyHkVM1mL2blN7_9JYc7fIAvpnKjahD_QJ63I62AAt0e .UHWA7IovLJMUPeraCDAeOpNvzOR0to5QpXlIDLm0SLogl9IFlYiOuKaD128 ViqAjLaLyjBPDUzNX9RADdKmCgZxWC8BrelTgtbSE3QysLHdpMm7JDRGyVVE 3OUZRhG7AM_7zVgnKDlqFaI61I.Ogu9XV4kpPvyE12uvXQrRDvWcknrHPkV8 V3aPnnCo79lmfr7BhwAgL5J9m0XTa9WVd4jeDgjv4KhKAYmXOXbKyKZmvn.V sEtz2Da_uhwOAve9Us6XZYvqA6eAsUbYrvHShqNVUfBkmuUkkw.H2CJ15hzF cEacdmK_Q3IaNnPOWtTIcphlsPgpc32ynr.Qs3CsPdqZfOh._8OA_YzxMkQ- - X-Mailer: YahooMailClassic/11.3.2 YahooMailWebService/0.8.105.279950 Date: Tue, 7 Sep 2010 17:46:04 -0700 (PDT) From: David Brownell Subject: Re: [PATCH] usbnet: allow rx_process() to ignore packets To: Ondrej Zary Cc: David Brownell , netdev@vger.kernel.org, Kernel development list MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="0-14384708-1283906764=:67832" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0-14384708-1283906764=:67832 Content-Type: text/plain; charset=us-ascii --- On Tue, 9/7/10, Ondrej Zary wrote: > > It's not a garbage, just a packet that is not yet > complete. Sorry, I guess I was being dense. I thought packets were by definition complete... :) I think you're saying this is one of N fragments which the minidriver will be re-assembling into a bigger packet, before somehow passing it up the stack... I attach my doc update patch. (should be the same as what I sent before. Consider my apology for using an attachment as repeated here; my email setup remains partly broken). Can you send a version of your defrag-enabling patch which applies on top of it, and documents your new calling convention (with a third return case for rx_process() too? --0-14384708-1283906764=:67832 Content-Type: application/octet-stream; name=rxfix Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=rxfix U2lnbmVkLW9mZi1ieTogRGF2aWQgQnJvd25lbGwgPGRicm93bmVsbEB1c2Vy cy5zb3VyY2Vmb3JnZS5uZXQ+ClN1YmplY3Q6IHVzYm5ldDogZG9jIHVwZGF0 ZXMKClByb3ZpZGUgbW9yZSBkb2N1bWVudGF0aW9uIGFib3V0IHRoZSByeF9m aXh1cCgpIGNhbGxpbmcgY29udmVudGlvbiwKdG8gaGVscCByZWR1Y2Ugc29t ZSByZWNlbnRseS1vYnNlcnZlZCBjb25mdXNpb24uCgpBbHNvIHN1bW1hcml6 ZSB0aGUgZXF1aXZhbGVuY2Ugb2YgVVNCIGFuZCBuZXR3b3JrIFRYL1JYIHF1 ZXVlcywgdG8KaGVscCBoaWdobGlnaHQgdGhlIHJvbGVzIG9mIHRoZSBmaXh1 cCgpIHJvdXRpbmVzIHdpdGggbGluayBwcm90b2NvbHMKdXNpbmcgdGhlIENQ VS1pbnRlbnNpdmUgcGFja2V0IGJhdGNoaW5nIG1vZGVscy4KClNpZ25lZC1v ZmYtYnk6IERhdmlkIEJyb3duZWxsIDxkYnJvd25lbGxAdXNlcnMuc291cmNl Zm9yZ2UubmV0PgotLS0KCgogaW5jbHVkZS9saW51eC91c2IvdXNibmV0Lmgg fCAgIDMxICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0KIDEgZmls ZSBjaGFuZ2VkLCAyOSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoK LS0tIGEvaW5jbHVkZS9saW51eC91c2IvdXNibmV0LmgKKysrIGIvaW5jbHVk ZS9saW51eC91c2IvdXNibmV0LmgKQEAgLTIyLDggKzIyLDIyIEBACiAjaWZu ZGVmCV9fTElOVVhfVVNCX1VTQk5FVF9ICiAjZGVmaW5lCV9fTElOVVhfVVNC X1VTQk5FVF9ICiAKLS8qIGludGVyZmFjZSBmcm9tIHVzYm5ldCBjb3JlIHRv IGVhY2ggVVNCIG5ldHdvcmtpbmcgbGluayB3ZSBoYW5kbGUgKi8KKy8qKiBp bnRlcmZhY2UgZnJvbSB1c2JuZXQgY29yZSB0byBlYWNoIFVTQiBuZXR3b3Jr aW5nIGxpbmsgd2UgaGFuZGxlLgorICoKKyAqIE5vdGUgdGhhdCB0aGUgZGVz aWduIGNlbnRlciBmb3IgdXNibmV0IGhhcyBvbmUgSUVFRSBwYWNrZXQgcGVy IFVSQiwKKyAqIGFuZCBtYXBzIG5ldHdvcmsgVFggYW5kIFJYIHF1ZXVlcyBk aXJlY3RseSB0byB0aGUKKyAqIFVTQiBoYXJkd2FyZSBUWC9SWCBxdWV1ZXMs IG1pbmltaXppbmcgc29mdHdhcmUgYW5kIGhhcmR3YXJlIG92ZXJoZWFkLgor ICogU29tZSBsaW5rIHByb3RvY29scyAobGlrZSBSTkRJUyBhbmQgQ0RDIE5D TSkgcHJvbW90ZSAgbGVzcyBlZmZpY2llbnQKKyAqIGRlc2lnbnMgd2hpY2gg aW52b2x2ZSBiYXRjaGluZyBtdWx0aXBsZSBJRUVFIHBhY2tldHMgaW4gZWFj aCBVUkIsCisgKiB3aXRoIGluY3JlYXNlZCBUWCBvdmVyaGVhZCB0byBjb3B5 IElFRUUgcGFja2V0cyBpbnRvIFRYIFVSQnMnIGRhdGEKKyAqIGJ1ZmZlcnMg aW4gdHhfZml4dXAoKSByb3V0aW5lcywgcGx1cyB1bmJhdGNoaW5nIHdvcmsg aW4gcnhfZml4dXAoKSB0b28uCisgKiBTb21ldGltZXMgdGhlIFRYIG92ZXJo ZWFkIGNhbiBiZSBtaW5pbWl6ZWQgb24gTGludXggYnkgbm90IGJhdGNoaW5n LCBidXQKKyAqIHRoaXMgdXN1YWxseSB3b24ndCB3b3JrIGZvciBSWCBiZWNh dXNlIG9mIHRoZSBuZWVkIHRvIGludGVyb3BlcmF0ZSB3aXRoCisgKiBpbXBs ZW1lbnRhdGlvbnMgd2hpY2ggYmF0Y2ggb24gVFguCisgKi8KKwogc3RydWN0 IHVzYm5ldCB7CisKIAkvKiBob3VzZWtlZXBpbmcgKi8KIAlzdHJ1Y3QgdXNi X2RldmljZQkqdWRldjsKIAlzdHJ1Y3QgdXNiX2ludGVyZmFjZQkqaW50ZjsK QEAgLTExMyw3ICsxMjcsMjAgQEAgc3RydWN0IGRyaXZlcl9pbmZvIHsKIAkv KiBsaW5rIHJlc2V0IGhhbmRsaW5nLCBjYWxsZWQgZnJvbSBkZWZlcl9rZXZl bnQgKi8KIAlpbnQJKCpsaW5rX3Jlc2V0KShzdHJ1Y3QgdXNibmV0ICopOwog Ci0JLyogZml4dXAgcnggcGFja2V0IChzdHJpcCBmcmFtaW5nKSAqLworCS8q IGZpeHVwIHJ4IHBhY2tldCAoIGJ5IHN0cmlwcGluZyBmcmFtaW5nIGZyb20g VVJCL1NLQi4KKwkgKgorCSAqIElmIFNLQiBiYXRjaGVzIG9uZSBvciBtb3Jl IHBhY2tldHMsIHBhc3MgYWxsIGJ1dCBvbmUgb2YgdGhlbQorCSAqIHVwIHRo ZSBzdGFjayAoY2xvbmUgU0tCIGFuZCBmaXh1cCBlYWNoIGNsb25lIGJlZm9y ZSBuZXRpZl9yeCkpLgorCSAqCisKKwkgKiBXaGVuIHlvdSBsZWF2ZSBvbmUg cGFja2V0IGluIFNLQiAoaW50ZW5kZWQgdXNhZ2UpLCByZXR1cm4KKwkgKiBu b256ZXJvIGFuZCBlbnN1cmUgc2tiLWxlbiBpcyBub256ZXJvLiAgdGhlIHBh Y2tldCB3aWxsIGJlCisJICogcGFzc2VkIHVwIHRoZSBuZXR3b3JrIHN0YWNr IGFuZCBhY2NvdW50ZWQgcHJvcGVybHkuCisJICoKKwkgKiByZXR1cm4gemVy byB0byBpbmRpY2F0ZSBlcnJvcnMgc3VjaCBhcyB0b28gbXVjaCBoZWFkZXIg b3IKKwkgKiBkYXRhLCBvciBhIGJhZCBjaGVja3N1bTsgdGhlIHBhY2tldCB3 aWxsIGJlIGRyb3BwZWQKKwkgKiBhbmQgYWNjb3VudGVkIGFzIGFuIGVycm9y LgorCSovCiAJaW50CSgqcnhfZml4dXApKHN0cnVjdCB1c2JuZXQgKmRldiwg c3RydWN0IHNrX2J1ZmYgKnNrYik7CiAKIAkvKiBmaXh1cCB0eCBwYWNrZXQg KGFkZCBmcmFtaW5nKSAqLwo= --0-14384708-1283906764=:67832--