From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCF6847ECFA for ; Tue, 5 May 2026 13:57:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777989445; cv=none; b=ErHVilW0olza9xOjaD5p69luKBWfWMCmHHvW8PzbA9mXCewEP00qTTfGYqMnDw3XBvo4bfrdkONLDEkvJzMSFlMtIGo5nveJ2ynzHTgBz7T/EZ7oE2VM8WDQEVzWO+mv2DymNTYIVi1SFLfV7WFx0+pg5Km5vBqAqnD99dIIv8s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777989445; c=relaxed/simple; bh=CZSj9ZWmQ5ooC/B9lWFk7QyttBbZH8/ZO1PvhsGrAXY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GUadXuL5zLhwPA04PmTJmtualf58ibO9wgY+3sf2eJcPQtDx6MIxyRFw9nBcYwuI/TDPwYWCEbb1S5UM4yCbc831MvxarFqNiNBm8lgaPRBAigJccDoCVH27yTvyPzN42L2w3wkWBNcybSTCcP3NfZ2H2ltgUQswQsRpn4DgDsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Tn8GXoMj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YUAXNznE; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Tn8GXoMj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YUAXNznE" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6457gYdZ1346173 for ; Tue, 5 May 2026 13:57:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= h0RVLE/qSnm/P09xzKEIzQY2p15aCFp93vrBJQ6M7zY=; b=Tn8GXoMj4m7fmcnO OWBAUFznqkPVw0GeGafLrUbyX4O7fAFIKI/nRzmorbY2qwT0+3l3gOtOZ67jl1n2 C5u2nYtv+V47IfR67l9Xkk5YqGfHJmCC9hdL+JdmsFNqRnBHvEB7CL6C/isw6zPE N5qN5+AqpxPDu4GfL43OwtlajZwGlRdjgVije1mrexJ9IIrXkDcpXEtY+kwd0n15 7sGrinXE5k6yySahlNSBDE8/Dkbx5LDRVnZO8C9NSzEDW4SRtffy60itHVH6tWd7 XM5MqkeoCCOwJLbUB2wiU0ClRqDA7pXMmFSwMoSQVBpIMpeOY60oPsZAup2IxqyZ leXscA== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxx2xcc5p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 13:57:21 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-2dd6fb4c867so3921663eec.0 for ; Tue, 05 May 2026 06:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777989441; x=1778594241; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=h0RVLE/qSnm/P09xzKEIzQY2p15aCFp93vrBJQ6M7zY=; b=YUAXNznE3XvOaoyHdEfM9puS/jEaLrIPoopjylmQCsQEZh7Vqs6SUdVMikJsXFOHYA uW3+8bsvCjQlZAADpKqKkEYVTap0a9ckJT7FpjrKKkoQWfLkPqZ+9K0CifGrZ5C20rpV qmSq5t7P1tPPNsnXlfp6e+bNBExo4q+1vRFfefgx+E1r2uBt5AWFn1yHEnM/+ELO9QPk B6802DFkGT4fvkdZ7ENREjTv6FbiGjhiD2UlQohvqGvPRK6WwqQwjVfm3DmQhO3t729D GH2MEg9CHq8d1kyqzXYQXSNQjdTusPM1fzTndDlo8Yp94O8ikKFzQ1XsmMJOJ2k1dMPI 48UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777989441; x=1778594241; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=h0RVLE/qSnm/P09xzKEIzQY2p15aCFp93vrBJQ6M7zY=; b=fohkzIKGfBYRU3WHIpqQkRfk3THg+QVTUOehK3q/Wykg/uMAnsYfD6I6NykR+mkcte LLDxoOTvJWoDJ+l/23dRZ6Ioa71xdBk6ATMQZRjCORk69019lkP5vh3+k2awVruMh5Cy zVql1NmuRa4K4Q3UXe83jlwxLyG4ocAsfW62oxr7S8CoRFSr0u9B04ojmy8sdS9tpeAQ PSV8U1ZIwVZXCyYcyTSaKEe9/ZVQdnlwJ54S1ceq9fl/wj51/831VQ9DfMFGNaNNzKXN aeHoJumHw5vuxTBLXWT/pkfinWD317zv3qaBq5tKA2vhe2gsYlaDivP0iuwOJjlND09t u8eA== X-Forwarded-Encrypted: i=1; AFNElJ/n5HbZFJOT/mZdPx1WwzLx6bkUZ5TsvPT6p2ZPH396IL+yKFEwAeXZNHh+N8f/42a626l7Sppx/iCQ3mg=@vger.kernel.org X-Gm-Message-State: AOJu0YysjrKp01aCmyFKQguZG/Dk9/HK8gt5KL/2rbklB8BjzjZlQxwc 92SvO0mMw8Zd+pOhuJqGap0If9QuPuVumpmihm+d9SisYpLzdz0hDvVfdGepsIrrgzFd33Z4wLc LRKgFa6Fje0Dd9zXkj7j37+Y0KNvqup3oE3sGN3whu04/VsDCqk2HCseRIO0wYFjp2uc= X-Gm-Gg: AeBDietsbP7rINQxB/Li8dK/pGDhhd5WY7jiGQuRw85FKd0NGFC8zm0dY1aMj41AoRx G1uZRu836nCJmzl82vneiYOLeX8EWjRzDOCei9a90Y7UzJ67+BuGuA4GRdCinyP8QBZbXvafDCy /TZnU3awPK/eTEtboD7GS6YHkKixJo1YU5glxw4JTgzOA6CrPMTwGfa7Yi+CUAvFwS3DaDidqFq MHMLNDMi5UST5Dy91PDcbTaGGf8EAHKRQWdn4JGyBAsN/dkK3TPb2Bmq3/k/b+bMKChvwu2xCKo i7wPqAFBGlIbUrmYx3Y7IsxcGU3o/8dsRmlxJ62TUNbpjuOTxuzks7JkeTLeNwonTvOb/Howp/X mZa/YHuoczBqvgz/rpSx8rjQ5erLPbFvZhY6AiFGfqwT0cAzmfFJrpt+BcC1TmTf84zlE6Q1SLy TIc0Jc253UKhlXtzQl/eJ0dn1y X-Received: by 2002:a05:7301:2a05:b0:2ed:e17:d50c with SMTP id 5a478bee46e88-2efba7b5047mr7274284eec.31.1777989440936; Tue, 05 May 2026 06:57:20 -0700 (PDT) X-Received: by 2002:a05:7301:2a05:b0:2ed:e17:d50c with SMTP id 5a478bee46e88-2efba7b5047mr7274258eec.31.1777989440393; Tue, 05 May 2026 06:57:20 -0700 (PDT) Received: from [192.168.1.2] ([122.177.242.135]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ee3bc6a79esm23836987eec.26.2026.05.05.06.57.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2026 06:57:20 -0700 (PDT) Message-ID: <62161822-2365-4ec7-80f7-8660bdadb177@oss.qualcomm.com> Date: Tue, 5 May 2026 19:27:11 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for Shikra To: Krzysztof Kozlowski Cc: Neil Armstrong , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Xiangxu Yin , Johan Hovold , Loic Poulain , Kathiravan Thirumoorthy , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260504170659.282532-1-krishna.kurapati@oss.qualcomm.com> <20260504170659.282532-3-krishna.kurapati@oss.qualcomm.com> <20260505-gifted-salamander-of-prowess-5107a6@quoll> <8cd564af-9646-40c5-a8ef-c7197fb3cfe9@kernel.org> <95b567cc-b83c-4154-9520-e624555f1882@oss.qualcomm.com> <29571bdd-23bf-42a7-a9e3-918a28c79700@kernel.org> Content-Language: en-US From: Krishna Kurapati In-Reply-To: <29571bdd-23bf-42a7-a9e3-918a28c79700@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=U9eiy+ru c=1 sm=1 tr=0 ts=69f9f741 cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=1ETSEvoV01wl5CnlN8iVEw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=kvxTIm3NsnwSdPV13ywA:9 a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-ORIG-GUID: FSnCwyQPzTdmWaNbTSzBrE_H7wjlLOSw X-Proofpoint-GUID: FSnCwyQPzTdmWaNbTSzBrE_H7wjlLOSw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDEzMyBTYWx0ZWRfX4FH4QeztKbIn 3kd1EQAgJP6JbMbCmnmlN55aqNF7XF+Luq7ArBrUw83MNFkSzSyd/+ZGoLxQmR4Te+mkedcKper BLmxkXleSXo8EQTEvO7/Bw7ZMp+iFWvm2Fvpp+KZ5TsiuVGU9ODPgBrTIHnxlxJvtoEqtxrQVym SVX2uZP07xG+TMFOo+wW3GP4v+Z1ETFGixjEn9ybZp9ZKuKJ2crxPwhgVeqUusbhYdbtVi353I6 X/yi9j25le3IL/1+kQTiUqIHbKtBY3mAtDE3UgkOxJyfYQauPIU3GFUejRn0tA99Ph2d2tt2EIu Cwh6hfVBZuU3Ct5R959E0mejq6insVLgMC/0VxO1Uohw9sb4xjtwpt6c6fddMP9S6KnJxSz9dYs Gkt/vbQVUxGe1DVLsFXD0J6U7KGp8TCaaK06JW/WhlbvzhE9zRJWsuDMN/kLRq3qZOudw4xVZsj /OoBBnYBnXPYTq6s+jA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-05_02,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050133 On 5/5/2026 6:59 PM, Krzysztof Kozlowski wrote: > On 05/05/2026 15:27, Krishna Kurapati wrote: >> >> >> On 5/5/2026 4:22 PM, Krzysztof Kozlowski wrote: >>> On 05/05/2026 12:49, Krzysztof Kozlowski wrote: >>>> On Mon, May 04, 2026 at 10:36:57PM +0530, Krishna Kurapati wrote: >>>>> Declare the USB-C QMP PHY present on the Qualcomm Shikra platform. >>>>> >>>>> Signed-off-by: Krishna Kurapati >>>>> --- >>>>> .../devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>> >>>> Reviewed-by: Krzysztof Kozlowski >>> >>> ... and then I looked at the driver. So un-reviewed. Devices are clearly >>> compatible. If not, explain what is not compatible. >>> >> Talos uses GCC_USB3_PRIM_PHY_AUX_CLK. >> >> In Shikra, we are using GCC_USB3_PRIM_PHY_COM_AUX_CLK. We don't have >> GCC_USB3_PRIM_PHY_AUX_CLK. >> >> Hence, I didn't use a fallback compatible. > > This still explains nothing. How different clock makes interface for SW > incompatible exactly? > So I went by the naming. AUX vs COM_AUX. Can I use a fallback compatible and in DT vote for "COM_AUX" clock with clock-names mentioning "aux" ? Regards, Krishna,