From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-serial@vger.kernel.org,
"Greg KH" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Lukas Wunner" <lukas@wunner.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] serial: RS485 termination is supported if DT provides one
Date: Tue, 5 Jul 2022 12:27:32 +0200 [thread overview]
Message-ID: <6216fed3-3a68-3de5-5cbf-9c2aebe68727@gmx.de> (raw)
In-Reply-To: <20220704094515.6831-3-ilpo.jarvinen@linux.intel.com>
On 04.07.22 11:45, Ilpo Järvinen wrote:
> When DT provides rs485-term, set termination flag as supported.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> drivers/tty/serial/serial_core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index a9cf1044a9fa..1db44cde76f6 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -3409,6 +3409,8 @@ int uart_get_rs485_mode(struct uart_port *port)
> port->rs485_term_gpio = NULL;
> return dev_err_probe(dev, ret, "Cannot get rs485-term-gpios\n");
> }
> + if (port->rs485_term_gpio)
> + port->rs485_supported.flags |= SER_RS485_TERMINATE_BUS;
>
> return 0;
> }
FWIW:
Reviewed-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
Regards,
Lino
prev parent reply other threads:[~2022-07-05 10:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 9:45 [PATCH 0/2] serial: RS485 termination improvements Ilpo Järvinen
2022-07-04 9:45 ` [PATCH 1/2] serial: Embed rs485_supported to uart_port Ilpo Järvinen
2022-07-05 10:41 ` Lino Sanfilippo
2022-07-04 9:45 ` [PATCH 2/2] serial: RS485 termination is supported if DT provides one Ilpo Järvinen
2022-07-05 10:27 ` Lino Sanfilippo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6216fed3-3a68-3de5-5cbf-9c2aebe68727@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®