From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=212.227.15.3 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792780225; b=LR38J6rQeeUjMgMY8k/MjhxP4LVcaXFXEC2qthLi9Qd/hmackDETkg62Ep/3N9mVcevV Ge5+Yf7w0g8/a7rSQQD2asbqvfxedP4l9IKw8q0T4JRvSu+/obPGrMBe7UvE9KLQ3UKBa BZCpISB8S2CTf4sJkhMv6gj4mEn/3Wf0YCPAxRAXNtrkKXNcRw5gkcmalIuHYE7cmODz0 OmEL0etUi9CCVSlSevozMvy8riF2O9FcaKl3LNY+AtGl/YtLHzefNNIhXOXtLxWweuJ6B KF3IhUADEKrCWfsjHfMu9pgql/SspiHAnb23bv6KTBJSf45cC3jMYIoKwHQn53wwvXA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792780225; h=DMARC-Filter:DKIM-Signature:X-UI-Sender-Class:Received:Message-ID: Date:MIME-Version:User-Agent:To:Cc:References:Subject: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Provags-ID:X-Spam-Flag:UI-OutboundReport; bh=fv/ppcHSQn3X5uWBPKwBqiyayuNUeNnKKoc/mFCU4r4=; b=YMVsm40HQtyA+hmPoshs8WnmAp32sH8uJGTdDi3yD5UThqaEucFM62C6UpfxB01/vJ7h Jwin2TK11uWGL8NQU9v5gsLEFik9aAMJkrrHxkyw5+aeYjQIBcj91uz6oedCUVroFtUrf TV5sStbI9Lgm/yW5T65aauAD28q4d0SnrpmmSX1RfXWrzJZljFX4sQSVGfqOax1xEKlhH aYwQERSinVEOyvva/L4vOfOYdKTLokjDUJp0B/ewJpkqFFWLQjNqDvgLBEGmdptrM7OJ2 k/n3AV2savQJqMdFZDdxFRSCKCb77U8Z+ol24fUDNtTv5Q7tkB5ss4NUgIsNE2zIEGw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass header.d=web.de header.i=markus.elfring@web.de header.a=rsa-sha256 header.s=s29768273 header.b=B39x3Kz8; arc=none smtp.remote-ip=212.227.15.3 Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B710C606A31F; Fri, 23 Oct 2026 18:30:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B710C606A31F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=web.de header.i=markus.elfring@web.de header.a=rsa-sha256 header.s=s29768273 header.b=B39x3Kz8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1792780216; x=1793385016; i=markus.elfring@web.de; bh=fv/ppcHSQn3X5uWBPKwBqiyayuNUeNnKKoc/mFCU4r4=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=B39x3Kz8SJwxUICTceZGJKb3M4bI9H8hVzp9gHYxzq8m/c6ONTSe+ahOHhZjcP7e Zy3oSAdPk11jzNUSP2QvxVkUUMdzhdFcH6PrwKAEp3P/+r5DNqWfWvwsHrA6hJTfd cSlXeyEvZ1zwZ8Fi2Yjd/BlfQjCcxDe+vRSKtev7eGpWJo228KDPXIPyxlp8mUpNX w+BDRmm9nXQDYNrFUDjF8VdSD8Lpj1Yt3DbUA5mCoMyTovZHlDdBv0vkruaZZReBi sbBjiSSBqxkifii5zoDtooLnyAt5aoUOnraDqhFLTb8kQVcO7qtm327VcDgXXupLn sWNbkC1/4N1ORC3XyQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from client.hidden.invalid by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MFs1z-1xMmSV1z1L-00HNNx; Fri, 23 Oct 2026 20:30:16 +0200 Message-ID: <6217c190-e8f1-4faa-b934-b1774501a3af@web.de> Date: Fri, 23 Oct 2026 20:30:13 +0200 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Chen Changcheng , linux-media@vger.kernel.org, Hans Verkuil , Mauro Carvalho Chehab Cc: LKML References: <20261022013811.27947-1-chenchangcheng@kylinos.cn> Subject: Re: [PATCH] media: dm1105: fix rc_dev leak on probe error paths Content-Language: en-GB, de-DE From: Markus Elfring In-Reply-To: <20261022013811.27947-1-chenchangcheng@kylinos.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:UwysyeXDS+vbf3ZHBbRzdTmYLAteeVoNqGHPz9/jgSdY49Y2S4t VQU6dE0mIQZFIlfH4uwuFLkGaqs3KmNk9OhO7d7c/Y1rdakHDgItC0jCpzRYAJlAgGZJ/gv xQCFFMG/BIwjmJIjG5jtTPPcss1LEy/kMqy34zQO1NQTDjBKqi1M7jh2NYI5V6CNKuNsTX/ kKM1bPLDraMvUPNfo3x3Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:9h+V79O/GkU=;bmCZ05odNueltmsEWPJbEsdly7P q8Zay6OkFlsROjis+igxxuYBtMdoR+yxV6sIP2VgEJBMEPAlAe2bOYVlRxyhRa4vXJfInxkJ5 1A+tEXGTE2SA/lQzPwX6PL3TnO8jWiMEsnAiKPcCrAgCn3zbRMQ/QM7kYjhJpvTf1bcQsJ87f fWiOetPX/fd3Z12ZrCJxsFGHzxqrnQOHNvOEwY2rBzuGjchdW5XurHUhnKPa0udHp8LXtd/Q7 xgtu2H4h0TPhFiaV4ejdt1aoy4tmkW7dC9JohUQ4jqUQ4IZJAH0SU57UGHOUUE5MajUoasoZM qfy7fITcc/r8jvlvNZZmoFh0faYCv6Ta57jGZeioNtIAXnFL8paRFiG6DfCqP0c+eluYa35Iu 14HjfFn30F3vcAp3sG9j3e4Ccd39z7EKamWYAkIu6OHMQoM0tw9xVl8DQiPR66oRWhmw0qm3p hxpw6y0y8wHqTLh685YizySI9m4fppYeAoxs/02c6XU3LM/Oesmf61C7Ekf1q8jauClKXbVTz ausRu1kdMZbHwisJfow2CnjTBsZ39X7On7Jj0EqPMpihHF8tAlFT4CtZxf5+Mu14DD1jxb4wm U1E2a3UV8SW7YymBGv8h+iYR+jMpg1M/sB9c26dOlyB7H2nBMOKtu9+m32ljdYM9elJn772U0 WdA98wTVUq864fEaRpXxKvOtHB+BIEZKf/gn6r851NmmJJJN7av4R/mGbcDwCtLhkkL2oxbvu vtOp+SrkXHBlHf9DUAu2DthUlCnWUJIqV/IRHCm8T3b0W85R4RSNcwd/Xw31pwPTkmEnE7kz7 igQkG3L43w17QIXZBsePosx28NbNsPcMMr6/YsjWHTY28uA1leEgpUEDKcFEFm4UVQSYBV67w dmSQcjKDZBdOHJtR4E1HOBiKGfTaSCqcix7XLiu7/KEe6jov6eekE1RB2AP40K0kZqcgMwOsJ jIzHH2W5QO8TtAMMAMjw9mjoxz4miCzgsu2krIg/Qgp7f3B+j55DTbUs8rw91AlvG9ooZYK4C 1BqLuThPvjm1HjuQ2IT5oByNeAmFD5TT64eVZCuYfoxJec1uylIFBO2OQKsnmInFVlGxBZLYn avcuXOYKZZYHlPq1iFMyoeRjOVLWapLkME8GuIVF6G892fNkKq34YOe5jgS1MY6xYMlW6zkwk N6TVjByZXdhR6oVaqDIKVKWPYJAC2Y+LasVPeg+MklObkrqCYM5Mru067z6HTg/UB8uzcLzbo njykcHCiszluoLlRQmXecFyoF6c88ElI/rVEo6P6cs7RtZk8QhY5xwP0RSsyk30iFZgDhcfb+ pkyNPNvSIeTlKSWXt72nzA198baIuBGQQmrF9hADIHrUxNATMx5RRinsxfqbYfjVkN2nyqPKK C2ZRpKRh8808jK1VAS8MqzzxcLrf2eWtpHad2rK2WjpODqMZxu1lAzW16dYY9Den2bSMiPaQQ lXdVZMBB2BEiN8zw07jHoPe8J768Hb+H7fenFSvfRroGEZUgxO7WANBB2CtO4jPb8M/3HLqEp zpZxKjttCXpqAw3O9QMkKBYGWi0431FXqyAoXqIktz/d+Mfwq2Qzb9LLGoxb7x9Eg+6oFemmN FK7VEyA5D+2tvZm9EgMZjDiXMMcIygmW1WmGNGuq4hvERGLVXwwEY7nmVg5aThGeX0ipbJwT8 iOOlQL0hK8kocHAKD2h/r21sPd/1SX17tUlHb3KFm3XNBLGe+VD3nFFlbcad5T3iwALACrIvW ddVyKNi8J8GkG+2JsiU4tGkJNPhMBzMKCGwNLMenVHoN5OIY9dO5EPeThuYU2l4sZqVGDrNMk 6I3rDpjIygjasXYMKot3r30yFAN4aTAWFk6AM6UKefJYFyLOcumZPo7vNUQLHLpXr/3qceYe0 WNe/ezG7Z+V/HtZxF+/LaUR2CiqaMmE+c9pFTibPuRG+AYZfS6qMzFi4GRxSjdgH5guz3SVCR XwnpZQZvWFu07d+iTpwYlAlwAilwkEbX2bCyVM9TRIzXzAULjBsodli81ryaHAGXd6AM6TyZv JOxZglu+laSEbhv7uUU5AlnTlvv+wd4b+Io3fkW9NAxADLlEGXRetgj9kSP+8gm/pEhSEns3/ IFYG440aZ2qdyeChoRFTSrIsvLXZ+EnFMqvxF+1RMh14WR/y+mSnEFTG6L3uniyzwyOvKVH0L MoKku8KtSOIW9y1MREEdXcaKahwujAkcqZ+693E5hK8lJTFDySk7RkhpjNyLTNuxNzB1lx1lx mI03UbYFBni6bwvaemjKOVKzN/Bat4LdlBbZ+9JFpxhdN6AAmcgRmo2CtdpaatKvZWihaKuIC 8buTGwCYfFiiwfYbPS7qPdcsDa0se32SYih9mOJCtop6S4OmcB1FIWvOcrkF6chtz5jTIEKsA II5NUGIqpJE7nRgEPREklKF94OAO+pURBaTPzEK+pkbAd0NId5REidoSM0zH8Jd0fZSiKHmcN O0bsLBYZ1tTu1jQf7HeQMTUU1qQWIERbEZef4LbJwLtKpw2t2rh4xYjWHUGm7mY7U0tj0OKuw RN1l9SndpwjUbQvstoWaDzEN98OtGFLDAX0yoOEyBcpbpSLb6KstqsjWWyJ/eggw7fKIII+Y7 5S79BOtDabfdmwHUxOqJHxVDKw47teWHVYW4aj7YKYgY8sgIwPb+TR6/XkP4qR9dSlmW02e+o /XOQ9sR3XG6NC5eGXVcQV8xR0ZyUboKwl1Rg6E2eULa2kgT1u5hhqwv98JwrQj0Cf8pevJEZI ZuTlLpchimF3Po4ae7Voo82H5e/3AQGZrDPRLcTbgZ5ksR7VHVoamiTz18kLWeSjPbYt7J6KE vGONHbvZ1m097Hnz19wNrifYvY3vlOf01GozfUyUbSFndPZ9eV9XZUeQeMQPjjp5+UYTgu0yC KOSbZFPxoofTCcwH2KL0nw6wX+mbciF1EH+/v7dzeyt36lymm6eQ1fFf/AnjwHZIgtkext8Hr Ih0LRG8laqVSOnq6wgVukK1mq73tqlvaZlFrBlu1NEGFzaVtHk70dGdxkBeJIh6IHdcRkHo6v 1L1i2kH8r9NHW3XvNk6qNfQEdiqNAMJbEZZ8qcyQZIevBiIPDTLXMZ1wwJ+lJQQItc7H58Xxj RWoJJbuycZ5mI9FNf3Sob62cFkANNr26V/Kw9IDxHRVzAcqxcQ5W0a7iKMcBmhy5F46wLffb4 /Vct+Q7qp7MT0RS8Lm+aPuQZnfsbXrZdH+DN2SdhVz1HqPFMVe4o1YnDtpIYOpTWyrJ3fBOeg uO7x8ByVJF1oE7uYvtRfYmBCfIPUm1o94d5SvlTEmjN0bbZ7t89zDzOHz7tjBcLMogsjEKo/2 ct/6ALFQ/X2EFHUNIGXj1udO9KSKdrnK+tdE4oEf0yK7avzmP1iIsTeB/sD1CjAsTd0dYOc00 869Q1FAqipkpvB13LV8eJ8Dv9AqVKuxjU2jLXQ9PzXadL/kHns+FFcO1La+wRG6xgS178bUcF JRwZ9MN98VDnPpMnBIHXlY1vOEWrZy3KgcifXeB/W2xnaea6BrSamSu3Jh4ct7lVcMi2nZhtN kf6cSUZcNW/ynjaUkXwG1KLZJpy7038vdMijoxoCXjcI+13KyGtCSWOScM/qviI/pG37ssv7g 2FWSbKZEEcl/QDgPA1sJIpkxzffQv4FL4x9g+R0lVuwWcVXkFTKKtNSOtccoKTydrCl7wuoZm 9MbyQkGGdyITMYIhC84c7WkiCa/Ppz75C5xUdKcetO2ifVDGXXEm941QZuW2sfIDQ75u5Awgd 4sZ48lXYY0IL6TMu9LFWKS7dkxlL+4Tef8muT90w4D3vc0/BnKDuLGu2BDPkmnrG+OK90r0Xa y0UK3fp9CUuVJtCs6c3Jyy13qM7YuihkDfEWp0VQ5ei8/WTesmeWB0OGomgDt6A8ucB1BHcA8 v31zbm+D24U0zajRopHxcAWHnymPAlFApisJfGBMqCNqmjgzxfzWGDhGxOU+6NgPlAYV7uQp9 i4Fuhkdhxn1+4P7bHpD8j9tt5oC0+sehaMDz8uZkLJf/3Yy2XDO4cJ+iDCLzJFZ/Tuq5JgTg+ kY6+/LLvX1pOEiIxuvtCUkWctMBwFbUKzhK3ikX+RvrsPvJQlABstXkrj7mNGvA2KGMN1O+dk C8kQ0OzRWrRGgu63URZbZDaBDG2GGXU/Vc8zQTsZcHif6CoR614WFc4OZ2cWpNDyUx60EED9J RdjgrapDgYNMQmUHnyNQsMDAjxzKCkNOI+wDgYMrXue9eFENyAqAiacTgdFPaM+6r8fyQYzPu H8mew+AIpUREBj7njsZVnzces6T4NzJNK9IikR3d61VwpM5rlNq5XXz3Zb5wOe8GOle8LGzA2 8970XwE1/Boj4PuMAgr4fsaoOQF4o+zwIVq4D9AyLuHjeC6ruIpgfsnU5mOla06OETORPBro/ GVEg3LMkAShwpd2zNCu8a8lCvDqorpb+2CtutsQEX7J694HOcgzXzTryVd/PZc/FfB+hm59Bn efQVr3vk7iRYwk7wWUTUb2CEJXqoO4nMjpN83u587p1U2s9A9J/YVk7O8IAAGftmTqjXlgKna sKD9M7wsLOfDf1msg0+0yDWmEoQHN+tUoTKhINsSYwZHUXVq2C9dOe9QxA6PXa2pTPg8Db3XD fal4G3NOvwuv8hs2rboh1syOI9a4ASTUOUyCt8aj+uf1ml18iw/0RqBzbdq5mTqdQ8jARzVpT EVyxdM+OouB3k6RyXmKVoEuG+IP0+QGq1eWgOegu/kbV8mp+nQkkjC8YB7BmhKZqpaoWCdGK3 vri5er7SLWuI6M5A5RvftxvYR6rev6XAN8GP7pv/Q/5hvjURrrfKeP/zetqnLoLV2uDf1B9E2 UHZHnX/AIaa1Yi07xNvmAd769oiaQleNOSLOn8RKqgjUI8wQLLThq8KRveEzHChU8ynMJT+FR jzQi0ZK+T6k9bgZNQLrinJHdjkGgYe0nmXZN/feXLDM1MX0EljXDdHeOeJhw292BUE1Xl0MFi tA3dhfU3Bo2Re75Hq8Dzzs5GMjjBPN6l43Kg0S41bkukR8ODupk8rq5G/PTLcTlE9X62nGxu6 s3rtGVGUtjw2jE/tgwf/FcNF1PuwsDWQuJMuUHGFxhOs09CIpCL+m5SZ1eiiNGze1KRNG4Jjh ovTrpAp8b7dX5cdv7/vqNmT3gCWT3NrmcsfPPBUEFY3y5KTQQdXrILpwMKY3idZAxEDjVks5c DtElxtiV6GGziZXWxnuHl48DDvYFAAtplxuuUwNns603BEGQkuPzc/adUXA7OXCYbwk4SAQXv pRm/UGDuglUR/3tU7h9ZcgnEZOFlpElEbyYHvnYUGi5J6CnKq2SlaOLQEiHCApUsHsEvkHFpf hj9fwzQ42tzHpRhWeL/jS9HUxMi+IofniMBdvOyphLhjTCVbOMXDpVnGiicWG0eeI1s1vgifQ Ry2xz3XcilY0WR8hnKNheshEuqqkLDB/tp1rfsrBnU2zN8VPcNDmmkqW4Qe2+hsUAabX2EgJB QH5/OumuARhRNekfUH4IjzZsnHxqWlvcqaRgNZzW36NQ92U2vE6Z+i1ZNWSECyJMpbH5F6zN0 pKIUPFzwHIhg2rXMBK98DxgwdLTs4DHpG6yPGLvKqZVZSVsBpNbdJRrcoBAEQsSE7+I850Qoj 6baBtHzfAqlldpULb3iqI4Se5Mhi2MICkumiHtwQ8QdYpXTFQIm+NiBMK3B70Vaoblr8YR80T yPQNCg4ZmNE1uUQ6RWpIJFHq8mtzSIJwFTWudDkybNITRtzuzslhzKJxyA8NO6GI+tKp7+poJ chWOVDa0I2CoUP3Icjh78QPxxwP0oVnO779sQ1Ch+GYPz85sJDiNxYdC6Kb3zHrKiDTCoW9hI Q1bk6c4sxKt4cYpaz7QrUH5KgYjCYwczMVAqUP1AR7oLp7aTuVTbg3gQo5rDqG05BTsLSRhrn 7gXXWEO7px2/nEJBMs7pd8l/+g2F4Mt3eqeQBsyIJaXuW2l3LZ5MOBUYP/3NIZeaEqAxzHbdV +QAgD9+nWFPAIv5OrXGxonKDxBbkAPp7nzXsXd5+gstHOmaerVCdFsXch8IHLHN+kySPEe7VA HSIaHic4KqOsRTtrEC5PGb3ZZC5SLM0o8yku+ph6I/xPfYftts/fTkj8ODblKkQwlwn46Vjs3 AFMFXz0/FtufUMPvYeH6/MgHQLrRnQfX3HuUi6pbYDFzyvc70mUzYMcFLSOxzfnCgUtWLrItM HJ7AkekZRcYoVptgst21K3Qb1Laa7JVqp9QW48LNSEe/tbdhk1M5zgx6igQzOsJor5ulRqeIy hYTicb4LJDdcw8biWV0kTgAk33pJpT0+jxc32ChwAgIMWqnI8sRO5bfNo5e3G2VnvtieomO4C OYiOiivbZ65oA8EL+42x2RUUB2jsaXlZTQPcxFGCxf8y/bC5p6v4xKsMVU3uJUKWwvZVCqlmq JD10WcgcC29V+EByzfqMku+29vixct5qwHE1S9/zjLlP6/9RaZBsQw24Et++KAQ65O2UxL0wD //n379UHIBCjfuYJhqL8dNrNzq06k4ezf596EBWVHWLjJXL/4/WCUWqBmbTb+CwL8JW2FtjOC IbvdbR11X1k8N+6FrWHAGRl0NQJ875C87KrSfIb7/H7FID0Fu36kJYI7WNSOyvFbNTOoj17f/ YbgDCbsdavSdFU5CGHBfVixv2fnnzk2eCvt4H9W9s > dm1105_ir_init() registers an rc_dev that must be cleaned up by > dm1105_ir_exit(). However, in dm1105_probe() the return value of > dm1105_ir_init() is ignored, and neither the workqueue nor the > request_irq error path calls dm1105_ir_exit(). If IR initialization > succeeds but a later step (create_singlethread_workqueue or > request_irq) fails, the registered rc_dev is leaked. How do you think about to add any tags (like =E2=80=9CFixes=E2=80=9D and = =E2=80=9CCc=E2=80=9D) accordingly? See also: * https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/= Documentation/process/submitting-patches.rst?h=3Dv7.3#n145 * https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/= Documentation/process/stable-kernel-rules.rst?h=3Dv7.3#n34 Regards, Markus