Re: octeontx2-af: Fix klockwork issues in AF driver

[Markus Elfring <Markus.Elfring@web.de>]

> I guess that there is a need to split different change possibilities
> into separate update steps.
…
> This is the first time I have submitted for klockwork fixes.
>
> Since these are similar klockwork fixes based on variable declaration and NULL checks.

Did this source code analysis tool present items according to different
development concerns (from selected categories)?


> I thought of combining the same.

Would you like to take the known advice “Solve only one problem per patch”
better into account?
Please take another look at further approaches for the presentation of
similar “change combinations”.


> Do you suggest 2 separate patch one for variable declaration and one for NULL checks?

Probably, yes.


> Or do I need to submit patch per file?

Maybe.

You can dare to offer software updates for each concern category
as patch series.
You can adapt then also better for constraints according to the selection of tags
(like “Fixes” and “Cc”), can't you?

Regards,
Markus