From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Devarsh Thakkar <devarsht@ti.com>,
andersson@kernel.org, mathieu.poirier@linaro.org,
p.zabel@pengutronix.de, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
s-anna@ti.com
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
hnagalla@ti.com, praneeth@ti.com, nm@ti.com, vigneshr@ti.com,
a-bhatia1@ti.com, j-luthra@ti.com
Subject: Re: [PATCH v2 1/2] Documentation: dt-bindings: k3-r5f-rproc: Add new compatible for AM62 SoC family
Date: Wed, 21 Dec 2022 18:17:30 +0100 [thread overview]
Message-ID: <621910a0-d851-409b-99e8-7bdf95dc539d@linaro.org> (raw)
In-Reply-To: <2c058ebf-c39c-9cb5-4a6f-afe88940104a@ti.com>
On 21/12/2022 17:29, Devarsh Thakkar wrote:
>>
>> Just look at your patch - it is clearly incorrect. You said in the patch
>> that for compatibles other than ti,am64-r5fss cluster mode is BOTH [0,
>> 1] AND false.
>
> cluster-mode is BOTH [0,1] and false only in case of AM62x as per below snippet
Yes, for that variant you have conflicting approach.
, but since it's under allOf the impact of latter will supersede, schema
validation will fail even if cluster-mode set to 0 or 1 for am62x due to
below snippet as shared in obesrvation log above [2].
Yeah, but the code is confusing. So again - you are saying with allOf
that both conditions are applicable. Your intentions of superseding do
not matter here - you said that allOf conditions must be taken into
account. These conditions can be reversed any time, don't you think?
>
> " - if:
> properties:
> compatible:
> enum:
> - ti,am62-r5fss
> then:
> properties:
> ti,cluster-mode: false"
>
> Sorry for the back and forth, I just thought to describe more clearly what I was up-to as I thought above should be functionally fine and it also saves us from having separate if blocks for each compatible, but I am open to adding separate if blocks as you earlier suggested if that seems more cleaner solution.
You need to fix your email client to properly wrap messages.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-21 17:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 13:40 [PATCH v2 0/2] Add single core R5F IPC " Devarsh Thakkar
2022-11-30 13:40 ` [PATCH v2 1/2] Documentation: dt-bindings: k3-r5f-rproc: Add new compatible " Devarsh Thakkar
2022-11-30 15:03 ` Krzysztof Kozlowski
2022-12-21 7:42 ` Devarsh Thakkar
2022-12-21 9:36 ` Krzysztof Kozlowski
2022-12-21 16:29 ` Devarsh Thakkar
2022-12-21 17:17 ` Krzysztof Kozlowski [this message]
2022-11-30 13:40 ` [PATCH v2 2/2] remoteproc: k3-r5: Use separate compatible string for TI " Devarsh Thakkar
2022-11-30 17:57 ` Tanmay Shah
2022-12-14 11:00 ` Devarsh Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=621910a0-d851-409b-99e8-7bdf95dc539d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a-bhatia1@ti.com \
--cc=andersson@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=j-luthra@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=nm@ti.com \
--cc=p.zabel@pengutronix.de \
--cc=praneeth@ti.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®