From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754252AbbJGNqq (ORCPT ); Wed, 7 Oct 2015 09:46:46 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:54415 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbbJGNqo (ORCPT ); Wed, 7 Oct 2015 09:46:44 -0400 From: Arnd Bergmann To: Sagi Grimberg Cc: Doug Ledford , Sean Hefty , Hal Rosenstock , Roland Dreier , linux-rdma@vger.kernel.org, Matan Barak , Or Gerlitz , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] IB/core: avoid 32-bit warning Date: Wed, 07 Oct 2015 15:46:35 +0200 Message-ID: <6219209.mJNClmP5Ym@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56151BDF.8010504@dev.mellanox.co.il> References: <17269152.DqJfCm1LOx@wuerfel> <56151BDF.8010504@dev.mellanox.co.il> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:K46XpezL508WbEM9YpjKHZQSgu14yN4UZ1XxJBRNuQkfDMI+UtR y1rSZFrBSKL0Mo40NPE4UV6hc7UZEuSZ4sSjojpjxJvgrAsNy5Foidk8XaY29SExGb0b3rq qROKjfO4RJiJAP9nvebgvsXyUBM2pZauzx92vmOOR/VdvqHu+IVzbIZIXUVbtKI0b9TfjsU +8SYjKoYC6Dud2SWP+zcQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:e8J2Lk03usw=:EZY/vGXKXezgwyfC5+NOhH tVj1AkQ6Dehc6hsFvsGyvOGaEfvACpHxudeI/D3LnyWTPxs6ay8Pe71V92nAWGyoYkmFpL6Dp j6uhcqi0/aXADPL8KngKVNhA3XTlf5nSPKya3ReIpBqfvI6t5vckU5RIxKTqomlc8Kp+Z9wE0 vYaRlDeuJWvHRi/dvfLXntusJsdfhmR7ScRPEaZy44jNwvOUHUJvkRN5Hq4HQLS8nOSaQqVw2 CLwwYV/ZypII6e9tPfbVR+nc/Jm7dO86KVxP+PO01Sk/ihm6qb2QBdTsf/5IEl8qCaBqhBT0L AVybpiLZsJ+BKPq/c6ZkR1/g3wF9j9W5/gGbDCEFJPKZf5jaLoipYCF/L9BqNoMgHtoxWRsed 8K5LNpavjze0xMt5sUPa+RBwjtK2qNF7LNR7eBItY6fgsHFv6oWeYmLXqgvN4E9uhZrt7eEaz 5PvXpENio8gTADcUqg4I5bW7m34783vdJ4i6YvEN/+v4/OL18/XfS0itKihlsnuwfPLHJz81Z sIHfvku03CB7S7GDKX77msAN41XSAp+86TKbj6PWq4zFtO7mIaBEAw76Wj8zh58v261uHsZgL n8ezBXLo+TKiU/c75ZAkp8R4rUNx+GOMEFENIdnoEhGOhQHSu35ljiy5reSUyY2eeCzSHEemm 6Dg1BodainFzwBD5NNNXaWD8AdUr8Mk1L6g67N0CHkiWk8TlJQBRj7UmQJJ4/g72I0vQK80fK UdDKfUZIS7YW3urV Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 07 October 2015 16:19:27 Sagi Grimberg wrote: > On 10/7/2015 3:29 PM, Arnd Bergmann wrote: > > The INIT_UDATA() macro requires a pointer or unsigned long argument for > > both input and output buffer, and all callers had a cast from when > > the code was merged until a recent restructuring, so now we get > > > > core/uverbs_cmd.c: In function 'ib_uverbs_create_cq': > > core/uverbs_cmd.c:1481:66: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > > > > This makes the code behave as before by adding back the cast to > > unsigned long. > > > > Signed-off-by: Arnd Bergmann > > Fixes: 565197dd8fb1 ("IB/core: Extend ib_uverbs_create_cq") > > > > diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c > > index be4cb9f04be3..88b3b78340f2 100644 > > --- a/drivers/infiniband/core/uverbs_cmd.c > > +++ b/drivers/infiniband/core/uverbs_cmd.c > > @@ -1478,7 +1478,7 @@ ssize_t ib_uverbs_create_cq(struct ib_uverbs_file *file, > > if (copy_from_user(&cmd, buf, sizeof(cmd))) > > return -EFAULT; > > > > - INIT_UDATA(&ucore, buf, cmd.response, sizeof(cmd), sizeof(resp)); > > + INIT_UDATA(&ucore, buf, (unsigned long)cmd.response, sizeof(cmd), sizeof(resp)); > > Would it make sense to cast inside INIT_UDATA() and not have callers > worry about it? If we want to do this properly, INIT_UDATA should be converted into a function call that has the right types. My patch doesn't try to do that here, it just restores the code to how it was for the past 10 years. Arnd