From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751090AbdHQFal (ORCPT ); Thu, 17 Aug 2017 01:30:41 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:10202 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812AbdHQFaj (ORCPT ); Thu, 17 Aug 2017 01:30:39 -0400 Subject: Re: [RFC PATCH 2/7] mmc: sdhci: Add quirk to indicate controller supports ADMA2 To: Adrian Hunter , Ulf Hansson , Tony Lindgren , Rob Herring References: <20170807160142.12134-1-kishon@ti.com> <20170807160142.12134-3-kishon@ti.com> CC: , , , , From: Kishon Vijay Abraham I Message-ID: <621be6ac-7670-1969-e133-3368f815c007@ti.com> Date: Thu, 17 Aug 2017 11:00:30 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 15 August 2017 01:03 PM, Adrian Hunter wrote: > On 07/08/17 19:01, Kishon Vijay Abraham I wrote: >> TI's implementation of sdhci controller used in DRA7 SoC's doesn't >> have SDHCI_CAN_DO_ADMA2 set in CAPA register though it supports >> ADMA2. Add quirk to support using ADMA2 even if the controller reports >> incorrect capability in CAPA. > > A quirk is not needed for this. Just call sdhci_read_caps() and change > host->caps before calling sdhci_add_host(). Okay, got it. Thanks Kishon > >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/mmc/host/sdhci.c | 3 ++- >> drivers/mmc/host/sdhci.h | 2 ++ >> 2 files changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c >> index ece3751d2a25..fff0baadbc3e 100644 >> --- a/drivers/mmc/host/sdhci.c >> +++ b/drivers/mmc/host/sdhci.c >> @@ -3264,7 +3264,8 @@ int sdhci_setup_host(struct sdhci_host *host) >> } >> >> if ((host->version >= SDHCI_SPEC_200) && >> - (host->caps & SDHCI_CAN_DO_ADMA2)) >> + ((host->caps & SDHCI_CAN_DO_ADMA2) || >> + (host->quirks2 & SDHCI_QUIRK2_FORCE_ADMA))) >> host->flags |= SDHCI_USE_ADMA; >> >> if ((host->quirks & SDHCI_QUIRK_BROKEN_ADMA) && >> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h >> index 6905131f603d..d778034e324d 100644 >> --- a/drivers/mmc/host/sdhci.h >> +++ b/drivers/mmc/host/sdhci.h >> @@ -437,6 +437,8 @@ struct sdhci_host { >> #define SDHCI_QUIRK2_CLOCK_DIV_ZERO_BROKEN (1<<15) >> /* Controller does not have CRC stripped in Command Response */ >> #define SDHCI_QUIRK2_NO_CRC_STRIPPING (1<<16) >> +/* Controller has bad caps bits, but really supports DMA */ >> +#define SDHCI_QUIRK2_FORCE_ADMA (1<<17) >> >> int irq; /* Device IRQ */ >> void __iomem *ioaddr; /* Mapped address */ >> >