From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BB6633A9D6 for ; Wed, 10 Jun 2026 15:18:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781104740; cv=none; b=S+kdhj3blLCdQZcpuLYNi5wIRdqQQAEWJR3dQKlxVhlONr6Qx+vHhJ5WiK1hlE8MjHDSrmIWYxrcefI0hgZBGEI7qbcMqMH9mifeADq4DvMDoDzHG5ZJC2QxRN0fSuQx0vAfY99EOoSwBuZmnSisaSkPr/vYLBlyYQk2RQaZ8oE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781104740; c=relaxed/simple; bh=Fh1qe/sr9qBRWbPCn+DqqqAhUInr0DiRhfFJgU3CiBA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SE5aiFYL+KEaMwMqc++Xo85/Q0iDqVQjTJhF2ZROVX4+3mTGxtQ14VNAMhu604WG13u681zYFdkgYVkbhW9Shqs8Fct/3L1V8yN2CzO50WBn4h8N+NexFjEzr+2ITWrXUGLJg7R6UF+thBeAr3iRdm09erkOccWEXJJR5gZmOrI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jJJFwOBH; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jJJFwOBH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F4051F00893; Wed, 10 Jun 2026 15:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781104739; bh=o9Ik1GACm73QYOyXh8LuD/Uz8CRsPYiYSxvMxY71LgY=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=jJJFwOBHDKNWsCAr82VQW4E3e7Stp0ystBa1ttDJ2Rl9mK/bkEW2WrztSNzzNy2GY lCSCIJCb+14R1WSKx3n+I7SldsjFvXVCU9fS0ptPO7pdJ3Ph0go+MeMJIz/JFjL5In YcCUhmWZyT0TnsCrbq6z6Ru4vD5lSm06xwGEXH6fmnUV9m5q1c/p7C2Wq0Wf5OoUqE 9FkvBGcJC4cti1aLONNp5DIUwMCk0UPyfavCU0sMkEDk96Q4l6d9c1c/DWALYu/mvP vw8uRJ85z4lOyzg5sKFFUP9f7XynnkPpJ7LsHm+RY8O9i9yA/CkZL6/E84WjRYtrqj NnJPh065VrUTA== Message-ID: <621cc992-5de2-455b-a488-f89ed2a9a91a@kernel.org> Date: Wed, 10 Jun 2026 10:18:57 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1] accel/amdxdna: Fix mm_struct reference leak in aie2_populate_range() Content-Language: en-US To: Lizhi Hou , ogabbay@kernel.org, quic_jhugo@quicinc.com, dri-devel@lists.freedesktop.org, karol.wachowski@linux.intel.com Cc: linux-kernel@vger.kernel.org, max.zhen@amd.com, sonal.santan@amd.com References: <20260610151127.2994185-1-lizhi.hou@amd.com> From: Mario Limonciello In-Reply-To: <20260610151127.2994185-1-lizhi.hou@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/10/26 10:11, Lizhi Hou wrote: > aie2_populate_range() jumps back to the again label without calling > mmput(mm), leaking a reference to the mm_struct. > > Add the missing mmput() before jumping to again. > > Fixes: e486147c912f ("accel/amdxdna: Add BO import and export") > Signed-off-by: Lizhi Hou Reviewed-by: Mario Limonciello (AMD) > --- > drivers/accel/amdxdna/aie2_ctx.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c > index 3e21e2dabe82..e0f30dbe0238 100644 > --- a/drivers/accel/amdxdna/aie2_ctx.c > +++ b/drivers/accel/amdxdna/aie2_ctx.c > @@ -1041,6 +1041,7 @@ static int aie2_populate_range(struct amdxdna_gem_obj *abo) > > if (ret == -EBUSY) { > amdxdna_umap_put(mapp); > + mmput(mm); > goto again; > } > > @@ -1051,11 +1052,13 @@ static int aie2_populate_range(struct amdxdna_gem_obj *abo) > if (mmu_interval_read_retry(&mapp->notifier, mapp->range.notifier_seq)) { > up_write(&xdna->notifier_lock); > amdxdna_umap_put(mapp); > + mmput(mm); > goto again; > } > mapp->invalid = false; > up_write(&xdna->notifier_lock); > amdxdna_umap_put(mapp); > + mmput(mm); > goto again; > > put_mm: