From: Kevin Cernekee <cernekee@gmail.com>
To: <joern@logfs.org>
Cc: <logfs@logfs.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] LogFS: Fix oops on failed mount
Date: Wed, 14 Apr 2010 17:56:10 -0700 [thread overview]
Message-ID: <621ed5fa50005b6ea02cff222037d3702a4d59b0@localhost.localdomain> (raw)
logfs_kill_sb() calls mempool_destroy() on super->s_alias_pool . But if
logfs_kill_sb() is being called because the mount failed (e.g.
__logfs_read_sb() returned -EIO) this pointer will still be NULL,
resulting in a kernel oops.
Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
---
fs/logfs/super.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/logfs/super.c b/fs/logfs/super.c
index b60bfac..f817713 100644
--- a/fs/logfs/super.c
+++ b/fs/logfs/super.c
@@ -517,7 +517,8 @@ static void logfs_kill_sb(struct super_block *sb)
__free_page(super->s_erase_page);
super->s_devops->put_device(sb);
mempool_destroy(super->s_btree_pool);
- mempool_destroy(super->s_alias_pool);
+ if (super->s_alias_pool)
+ mempool_destroy(super->s_alias_pool);
kfree(super);
log_super("LogFS: Finished unmounting\n");
}
--
1.6.3.1
next reply other threads:[~2010-04-15 1:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 0:56 Kevin Cernekee [this message]
2010-04-15 6:16 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=621ed5fa50005b6ea02cff222037d3702a4d59b0@localhost.localdomain \
--to=cernekee@gmail.com \
--cc=joern@logfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logfs@logfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®