From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBC65C46477 for ; Wed, 12 Jun 2019 09:43:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4B88207E0 for ; Wed, 12 Jun 2019 09:43:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437613AbfFLJnm (ORCPT ); Wed, 12 Jun 2019 05:43:42 -0400 Received: from foss.arm.com ([217.140.110.172]:48800 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726636AbfFLJnm (ORCPT ); Wed, 12 Jun 2019 05:43:42 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6609C337; Wed, 12 Jun 2019 02:43:41 -0700 (PDT) Received: from [10.1.196.93] (en101.cambridge.arm.com [10.1.196.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 574AB3F246; Wed, 12 Jun 2019 02:45:23 -0700 (PDT) Subject: Re: [PATCH 07/13] drivers: Add generic match helper by ACPI_COMPANION device To: rafael@kernel.org Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-spi@vger.kernel.org, broonie@kernel.org References: <1559747630-28065-1-git-send-email-suzuki.poulose@arm.com> <1559747630-28065-8-git-send-email-suzuki.poulose@arm.com> <1f230eb7-f4e3-ed4e-960d-c3bbb60f0a18@arm.com> From: Suzuki K Poulose Message-ID: <621f33db-d7d8-380e-fe50-effb27523068@arm.com> Date: Wed, 12 Jun 2019 10:43:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, On 06/06/2019 10:57, Rafael J. Wysocki wrote: > On Thu, Jun 6, 2019 at 11:28 AM Suzuki K Poulose wrote: >> >> >> >> On 06/06/2019 10:17, Rafael J. Wysocki wrote: >>> On Wed, Jun 5, 2019 at 5:14 PM Suzuki K Poulose wrote: >>>> >>>> Add a generic helper to match a device by the acpi device. >>> >>> "by its ACPI companion device object", please. >> >> Sure. >> >>> >>> Also, it would be good to combine this patch with the patch(es) that >>> cause device_match_acpi_dev() to be actually used. >>> >>> Helpers without any users are arguably not useful. >> >> Sure, the helpers will be part of the part2 of the whole series, >> which will actually have the individual subsystems consuming the >> new helpers. For your reference, it is available here : >> >> http://linux-arm.org/git?p=linux-skp.git;a=shortlog;h=refs/heads/driver-cleanup/v2 >> >> e.g: >> http://linux-arm.org/git?p=linux-skp.git;a=commit;h=59534e843e2f214f1f29659993f6e423bef16b28 >> >> I could simply pull those patches into this part, if you prefer that. > > Not really. > > I'd rather do it the other way around: push the introduction of the > helpers to part 2. Sure, I will do that. > >> However, that would be true for the other patches in the part2. >> I am open to suggestions, on how to split the series. > > You can introduce each helper along with its users in one patch. > > This way the total number of patches will be reduced and they will be > easier to review IMO. > Wouldn't it make the merging complicated ? I am still not clear how we plan to merge the part 2 ? Cheers Suzuki