From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933668AbdDEKpH convert rfc822-to-8bit (ORCPT ); Wed, 5 Apr 2017 06:45:07 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:49322 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933394AbdDEKoW (ORCPT ); Wed, 5 Apr 2017 06:44:22 -0400 X-AuditID: b6c32a2d-f792a6d0000055a1-33-58e4ca846290 From: Bartlomiej Zolnierkiewicz To: Ard Biesheuvel Cc: Ingo Molnar , "linux-efi@vger.kernel.org" , Thomas Gleixner , "H . Peter Anvin" , Leif Lindholm , Lorenzo Pieralisi , "linux-kernel@vger.kernel.org" , Eugene Cohen , Matt Fleming , Peter Jones Subject: Re: [GIT PULL 0/2] EFI fixes for v4.11 Date: Wed, 05 Apr 2017 12:44:17 +0200 Message-id: <6222690.3kM8OKJmde@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset=utf-8 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBKsWRmVeSWpSXmKPExsWy7bCmhm7LqScRBkuvCFr8/7Cb0aL18xsm i2kbxS0+7d7DYtH28BajxeVdc9gs3vx+wW7R/7LMYvW/U4wWXQtvsFts3jSV2YHbY828NYwe XRtmMXrs2raTyWPTqk42jzvX9rB5vDt3jt3j/b6rbB6fN8l5nGj5whrAGcVlk5Kak1mWWqRv l8CV0XhkN1PBAamKNcc/MjcwbhbtYuTkkBAwkbh95yYrhC0mceHeejYQW0hgKaPE/EtMXYxc QHY7k8Tyo/sYYRqWLD/EApGYwyixceIUKOcro8S+xj4mkCo2ASuJie2rgDo4OEQE9CRausxA wswCG5glbs72B7GFBfQltm1ayA5iswioSry8thyslVdAU2LRwp1gV4gKeEls2dcOFucUCJY4 d3MZM0SNoMSPyfdYIGZqSzx5d4EVwtaUePFlEtg9EgKP2CXWnvjGDHKDhICsxKYDzBAPuEh0 358H9YywxKvjW9ghbGmJv0tvQcWnM0ps/y0BMWczo8Sq3ROgiqwlDh+/CLWMT6L39xMmiPm8 Eh1tQhAlHhIr37WyQNiOEvev3WOGhM8RRonLE2cxT2CUn4Xkh1lIfpiF5IcFjMyrGMVSC4pz 01OLTQuM9IoTc4tL89L1kvNzNzGC05OW7g7GLwu8DzEKcDAq8fAmiD+JEGJNLCuuzD3EKMHB rCTCu+UEUIg3JbGyKrUoP76oNCe1+BCjNAeLkjiv+sprEUIC6YklqdmpqQWpRTBZJg5OqQbG jtcB+lyTnkYoTxQoYjX4EtUUuUszhnWD0qRGG8Oel+aLHp37cWPK4+7pbVEn9Lx/xK5+JK1k 5KIu0Vzo8ujeDr2IOY3BNVK5N55LcXLFRu2UFFfu4dni9OP0pAt9EwIXLdDjVrnP+2zhq12H rTT8KnUC3v95np4mk7hZ0cM35NdXGXdb729KLMUZiYZazEXFiQDJGPNXSwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFIsWRmVeSWpSXmKPExsVy+t9jQd3mU08iDH51qFv8/7Cb0aL18xsm i2kbxS0+7d7DYtH28BajxeVdc9gs3vx+wW7R/7LMYvW/U4wWXQtvsFts3jSV2YHbY828NYwe XRtmMXrs2raTyWPTqk42jzvX9rB5vDt3jt3j/b6rbB6fN8l5nGj5whrAGeVmk5GamJJapJCa l5yfkpmXbqsUGuKma6GkkJeYm2qrFKHrGxKkpFCWmFMK5BkZoAEH5wD3YCV9uwS3jMYju5kK DkhVrDn+kbmBcbNoFyMnh4SAicSS5YdYIGwxiQv31rN1MXJxCAnMYpS4/ukelPOVUeLZ5g9g VWwCVhIT21cxdjFycIgI6Em0dJmB1DALbGKWWHz/PCNIjbCAvsS2TQvZQWwWAVWJl9eWM4HY vAKaEosW7mQDsUUFvCS27GsHi3MKBEtcurKVCWLZMUaJB3vvQjUISvyYfA9sMbOAtsSTdxdY QRYzC6hLTJmSO4ER6EyEqllIqmYhVC1gZF7FKJFakFxQnJSea5SXWq5XnJhbXJqXrpecn7uJ ERyvz6R3MB7e5X6IUYCDUYmHt2La4wgh1sSy4srcQ4wSHMxKIrxbTjyJEOJNSaysSi3Kjy8q zUktPsRoCvTfRGYp0eR8YCrJK4k3NDE3MTc2sDC3tDQxUhLnbZz9LFxIID2xJDU7NbUgtQim j4mDU6qBcSeP/xHbGaXr5B8pFBkFefHMSP6wvWtVIOOrJd5brzI8irNb4etwwmM/r+3qF65a btujVqcb7HcSPbZkXR8/5++d8VdePVabyif0g2fJzi7bL59X691JCgvX65WVfBh3oyJPIL5h yUfJWysjfjyIv1kjamyo28K88fGUl33i9n+3b/G0ye7RU2Ipzkg01GIuKk4EANKkyYLtAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170405104419epcas5p3238c05da12517e346019eac0a3915ac8 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170405100833epcas1p4b5076679dc4f8644fa789b421a66f953 X-RootMTR: 20170405100833epcas1p4b5076679dc4f8644fa789b421a66f953 References: <5013223.ea6UCckGV3@amdc3058> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, April 05, 2017 11:14:06 AM Ard Biesheuvel wrote: > On 5 April 2017 at 11:08, Bartlomiej Zolnierkiewicz > wrote: > > > > Hi, > > > > On Tuesday, April 04, 2017 04:27:42 PM Ard Biesheuvel wrote: > >> Hello all, > >> > >> Please pull these fixes for EFI framebuffer support on ARM/arm64 systems. > >> > >> The following changes since commit 822f5845f710e57d7e2df1fd1ee00d6e19d334fe: > >> > >> efi/esrt: Cleanup bad memory map log messages (2017-03-17 18:53:12 +0000) > >> > >> are available in the git repository at: > >> > >> git://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git tags/efi-urgent > >> > >> for you to fetch changes up to e73c2811538bd36ec1340d01bafdc080af31914e: > >> > >> efifb: Avoid reconfiguration of BAR that covers the framebuffer (2017-04-04 15:56:43 +0100) > >> > >> ---------------------------------------------------------------- > >> Two fixes related to the EFI framebuffer driver: > >> - Ignore Graphics Output Protocol (GOP) implementations that are marked as > >> BLT-only -- the framebuffer base address is invalid in this case, and the > >> Blt() method is not accessible to the kernel. > >> - If the GOP framebuffer base address coincides with a memory BAR of a PCI > >> device that has memory decoding enabled, claim the memory resource so that > >> the PCI core will not attempt to move it later on. > >> > >> ---------------------------------------------------------------- > >> Ard Biesheuvel (1): > >> efifb: Avoid reconfiguration of BAR that covers the framebuffer > > > > This patch breaks build if PCI support is not enabled: > > > > drivers/video/fbdev/efifb.c: In function ‘claim_efifb_bar’: > > drivers/video/fbdev/efifb.c:386:2: error: implicit declaration of function ‘pci_claim_resource’ [-Werror=implicit-function-declaration] > > > > (x86 ifdefs are not enough, the patch should also check for PCI support) > > > > Also please cc: linux-fbdev mailing list & me on fbdev related patches. > > > > Thanks for the report. The patch was tested successfully on an > impressive list of configurations by kbuild test robot, but > apparently, none of those has PCI disabled. Well, it has been found by looking at the patch itself and since none of defconfigs contains such configuration currently the issue is rather minor one. [ Also sorry for the late report but this is the first time I see these patches. They were never posted to linux-fbdev or me. ] > Ingo, since you have queued this already, how would you like to > proceed? I don't think we need anything beyond I see that Ingo fixed the patch himself so it is all fine now, thanks! > diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c > index 758960b6aec9..b827a8113e26 100644 > --- a/drivers/video/fbdev/efifb.c > +++ b/drivers/video/fbdev/efifb.c > @@ -364,7 +364,7 @@ static struct platform_driver efifb_driver = { > > builtin_platform_driver(efifb_driver); > > -#ifndef CONFIG_X86 > +#if defined(CONFIG_PCI) && !defined(CONFIG_X86) > > static bool pci_bar_found; /* did we find a BAR matching the efifb base? */ Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics