Re: [PATCH v2 3/3] rust: bitmap: kunit: uncomment owned_bitmap_out_of_bounds panic case

[David Gow <david@davidgow.net>]

Le 30/10/2026 à 00:59, Nicolás Antinori via B4 Relay a écrit :
> From: Nicolás Antinori <nico.antinori.7@gmail.com>
> 
> Rust KUnit tests now support `#[should_panic]` attribute. Uncomment the
> test so it can be run when CONFIG_RUST_BITMAP_HARDENED=y.
> 
> Signed-off-by: Nicolás Antinori <nico.antinori.7@gmail.com>
> ---

This works well on architectures should_panic is working on (but we'll 
want to fix UML support first).

Acked-by: David Gow <david@davidgow.net>

Cheers,
-- David

>   rust/kernel/bitmap.rs | 21 ++++++++++-----------
>   1 file changed, 10 insertions(+), 11 deletions(-)
> 
> diff --git a/rust/kernel/bitmap.rs b/rust/kernel/bitmap.rs
> index 610d565535ccfba6af8f2ca4ac4028fa027a9644..8eecd669096713fc7f21431188959a921a1d5ca0 100644
> --- a/rust/kernel/bitmap.rs
> +++ b/rust/kernel/bitmap.rs
> @@ -762,11 +762,10 @@ fn bitmap_set_clear_find() -> Result<(), AllocError> {
>           Ok(())
>       }
>   
> -    #[test]
>       #[cfg(not(CONFIG_RUST_BITMAP_HARDENED))]
> +    #[test]
>       fn owned_bitmap_out_of_bounds() -> Result<(), AllocError> {
>           let mut b = BitmapVec::new(128, GFP_KERNEL)?;
> -
>           b.set_bit(2048);
>           b.set_bit_atomic(2048);
>           b.clear_bit(2048);
> @@ -777,15 +776,15 @@ fn owned_bitmap_out_of_bounds() -> Result<(), AllocError> {
>           Ok(())
>       }
>   
> -    // TODO: uncomment once kunit supports `#[should_panic]`.
> -    // #[cfg(CONFIG_RUST_BITMAP_HARDENED)]
> -    // #[test]
> -    // #[should_panic]
> -    // fn owned_bitmap_out_of_bounds() -> Result<(), AllocError> {
> -    //     let mut b = BitmapVec::new(128, GFP_KERNEL)?;
> -    //
> -    //     b.set_bit(2048);
> -    // }
> +    #[cfg(CONFIG_RUST_BITMAP_HARDENED)]
> +    #[test]
> +    #[should_panic]
> +    fn owned_bitmap_out_of_bounds() -> Result<(), AllocError> {
> +        let mut b = BitmapVec::new(128, GFP_KERNEL)?;
> +
> +        b.set_bit(2048);
> +        Ok(())
> +    }
>   
>       #[test]
>       fn bitmap_copy_and_extend() -> Result<(), AllocError> {
>