From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 436EFC433FE for ; Mon, 17 Oct 2022 08:42:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230020AbiJQImC (ORCPT ); Mon, 17 Oct 2022 04:42:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229778AbiJQIl7 (ORCPT ); Mon, 17 Oct 2022 04:41:59 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E77E42AC6D for ; Mon, 17 Oct 2022 01:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665996117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AYu+Olly91MbNGXLgDC9bc9k1FpmlocPO3fPhrKXidQ=; b=AbIq3M0+IoUec6z55v3sBwX+erl+zbGlM13b9yiinsumBVEN4yoWc2xSTwqMBYJGdH/p7i wBqndnnkpUIpVxYuofSL1jvTvnFBvZyjoR+CW5Pc9AGw1W2ezc/u2H17tKN21SzNvrAAsq W7YqvtLXdlJNfdAYhtyFtBD+/Wr1NZo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-237-PST2KcWCPz2R5AbXZS5nbg-1; Mon, 17 Oct 2022 04:41:55 -0400 X-MC-Unique: PST2KcWCPz2R5AbXZS5nbg-1 Received: by mail-wr1-f70.google.com with SMTP id g4-20020adfbc84000000b0022fc417f87cso3466781wrh.12 for ; Mon, 17 Oct 2022 01:41:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AYu+Olly91MbNGXLgDC9bc9k1FpmlocPO3fPhrKXidQ=; b=eV4vWdGhHK/5BgqncArse88lHNmpKOVSh+gqH+rnvpklT6SYJ/nIUud7Or8O0ADh82 PhNlBiNl+i2x3cU3LbwcjUrpUpEvwNA/riaz+wZxOr26DDmcsn/9gsmxxboqWhscRV5I kCi4acHB2KCXB3U+UsfN282cvPIAfaaaIPIBkgr2sTErb+YSHcOziSF589Le2pYJCdzg /6Af8g8SNnfGAUf0PZtFzdCY5VcS+RG4SNdvBHVhCqgU1L+rDsQP+qYx48o/Xh2P349k Tgebt6dh2bF9tCt5+W/FOHwOtwj3cUZ7CEaPeKP1Em/DL9iehtyqEWGbk5AWkur2cZdP 5ABg== X-Gm-Message-State: ACrzQf1AJA8UZhF4iS3JNeFhb3P56IV8pHHw/RtIWNvxdrqVqyCiOByG JitEZQgoqJ83J8ZIXZgaPHRF7OYfUwEyVm9HJFXbWSpPpGm7TyOqOkWb+Zw9dodGBJDxsBLx3RA KJP/mAA5ZMf+i8pYXOZrWUzqW X-Received: by 2002:a7b:c5c2:0:b0:3c4:fd96:fb68 with SMTP id n2-20020a7bc5c2000000b003c4fd96fb68mr6474795wmk.36.1665996114161; Mon, 17 Oct 2022 01:41:54 -0700 (PDT) X-Google-Smtp-Source: AMsMyM44s/3N3JjFxznWXGrQX+rdkuNXuUerrs1tO5v7ve4FrMytiiusaeyg5H7HECTjpmjok+oUpw== X-Received: by 2002:a7b:c5c2:0:b0:3c4:fd96:fb68 with SMTP id n2-20020a7bc5c2000000b003c4fd96fb68mr6474777wmk.36.1665996113848; Mon, 17 Oct 2022 01:41:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:2300:e5ce:21ba:1d93:4323? (p200300cbc7072300e5ce21ba1d934323.dip0.t-ipconnect.de. [2003:cb:c707:2300:e5ce:21ba:1d93:4323]) by smtp.gmail.com with ESMTPSA id v1-20020adfedc1000000b00228daaa84aesm7881318wro.25.2022.10.17.01.41.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Oct 2022 01:41:53 -0700 (PDT) Message-ID: <6227ba4c-9455-9652-7434-7842b2b3edcb@redhat.com> Date: Mon, 17 Oct 2022 10:41:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [RFC PATCH] mm: Introduce new MADV_NOMOVABLE behavior Content-Language: en-US To: Baolin Wang , akpm@linux-foundation.org Cc: arnd@arndb.de, jingshan@linux.alibaba.com, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.10.22 09:32, Baolin Wang wrote: > When creating a virtual machine, we will use memfd_create() to get > a file descriptor which can be used to create share memory mappings > using the mmap function, meanwhile the mmap() will set the MAP_POPULATE > flag to allocate physical pages for the virtual machine. > > When allocating physical pages for the guest, the host can fallback to > allocate some CMA pages for the guest when over half of the zone's free > memory is in the CMA area. > > In guest os, when the application wants to do some data transaction with > DMA, our QEMU will call VFIO_IOMMU_MAP_DMA ioctl to do longterm-pin and > create IOMMU mappings for the DMA pages. However, when calling > VFIO_IOMMU_MAP_DMA ioctl to pin the physical pages, we found it will be > failed to longterm-pin sometimes. > > After some invetigation, we found the pages used to do DMA mapping can > contain some CMA pages, and these CMA pages will cause a possible > failure of the longterm-pin, due to failed to migrate the CMA pages. > The reason of migration failure may be temporary reference count or > memory allocation failure. So that will cause the VFIO_IOMMU_MAP_DMA > ioctl returns error, which makes the application failed to start. > > To fix this issue, this patch introduces a new madvise behavior, named > as MADV_NOMOVABLE, to avoid allocating CMA pages and movable pages if > the users want to do longterm-pin, which can remove the possible failure > of movable or CMA pages migration. Sorry to say, but that sounds like a hack to work around a kernel implementation detail (how often we retry to migrate pages). If there are CMA/ZONE_MOVABLE issue, please fix them instead, and avoid leaking these details to user space. ALSO, with MAP_POPULATE as described by you this madvise flag doesn't make too much sense, because it will gets et after all memory already was allocated ... NAK -- Thanks, David / dhildenb