From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Shuai Zhang <quic_shuaz@quicinc.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_chejiang@quicinc.com,
quic_jiaymao@quicinc.com, quic_chezhou@quicinc.com
Subject: Re: [PATCH v1] Bluetooth: btqca: Add WCN6855 firmware priority selection feature
Date: Wed, 12 Nov 2025 14:30:43 +0100 [thread overview]
Message-ID: <622d407b-d04f-463d-bcbb-3543933d5fa1@oss.qualcomm.com> (raw)
In-Reply-To: <093749fb-5eee-4a1c-a29e-8232e0c9dd6d@quicinc.com>
On 11/12/25 12:29 PM, Shuai Zhang wrote:
> Hi Konrad
>
> Thank you for your review.
> On 11/12/2025 5:53 PM, Konrad Dybcio wrote:
>> On 11/12/25 8:46 AM, Shuai Zhang wrote:
>>> For WCN6855: download wcnhpbtfwxx.tlv and wcnhpnvxx.xxx;
>>> if they do not exist, download hpbtfwxx.tlv and hpnvxx.xxx instead.
>>>
>>> Signed-off-by: Shuai Zhang <quic_shuaz@quicinc.com>
>>> ---
>>
>> Would these files be fundamentally any different, or is it a workaround
>> for someone else being creative with filenames?
>>
>
> The prefix “wcn” corresponds to the WCN685x chip, while entries without
> the “wcn” prefix correspond to the QCA2066 chip. There are some feature
> differences between the two.
>
> However, due to historical reasons, the WCN685x chip has been using firmware
> without the “wcn” prefix. We are now correcting the mapping between the chip
> and its corresponding firmware.
>
> If it is necessary to add a comment to explain this, I will submit a new patch.
Yes, most definitely. Please add this both in the commit message and
a comment in the code
Konrad
prev parent reply other threads:[~2025-11-12 13:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 7:46 Shuai Zhang
2025-11-12 9:53 ` Konrad Dybcio
2025-11-12 11:29 ` Shuai Zhang
2025-11-12 13:30 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=622d407b-d04f-463d-bcbb-3543933d5fa1@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=brgl@bgdev.pl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=quic_chejiang@quicinc.com \
--cc=quic_chezhou@quicinc.com \
--cc=quic_jiaymao@quicinc.com \
--cc=quic_shuaz@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®