From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936478AbcKQO2z (ORCPT ); Thu, 17 Nov 2016 09:28:55 -0500 Received: from foss.arm.com ([217.140.101.70]:52154 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754900AbcKQO1V (ORCPT ); Thu, 17 Nov 2016 09:27:21 -0500 Subject: Re: [RFC PATCH] of: base: add support to get machine model name To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org References: <1479383450-19183-1-git-send-email-sudeep.holla@arm.com> <3670336.mMHByOpDl4@wuerfel> Cc: Sudeep Holla , linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, devicetree@vger.kernel.org, linux-sh@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Rob Herring , linuxppc-dev@lists.ozlabs.org From: Sudeep Holla Organization: ARM Message-ID: <622ddcbc-69b9-98f2-51f3-e256764ecb93@arm.com> Date: Thu, 17 Nov 2016 14:08:30 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <3670336.mMHByOpDl4@wuerfel> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/11/16 13:50, Arnd Bergmann wrote: > On Thursday, November 17, 2016 11:50:50 AM CET Sudeep Holla wrote: >> Currently platforms/drivers needing to get the machine model name are >> replicating the same snippet of code. In some case, the OF reference >> counting is either missing or incorrect. >> >> This patch adds support to read the machine model name either using >> the "model" or the "compatible" property in the device tree root node. >> >> Signed-off-by: Sudeep Holla > > I like the idea. One small comment: > Thanks. I prefer it as single patch but it can't be applied to any tree. Any suggestions on handling this patch to fix the warning in -next ? >> +int of_machine_get_model_name(const char **model) >> +{ >> + int error; >> + struct device_node *root; >> + >> + root = of_find_node_by_path("/"); >> + if (!root) >> + return -EINVAL; > > The global of_root variable points ot this already, and is defined > in the same file, so I think we can just skip the lookup. > Ah right, will fix it. -- Regards, Sudeep