mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Knox Chiou <knoxchiou@chromium.org>, LKML <linux-kernel@vger.kernel.org>
Cc: Evan Green <evgreen@chromium.org>
Subject: Re: [PATCH] nvmem: qfprom: Increase fuse blow timeout to prevent write fail.
Date: Tue, 22 Feb 2022 17:30:11 +0000	[thread overview]
Message-ID: <6230f480-a8cb-6807-35eb-b5ee407297f9@linaro.org> (raw)
In-Reply-To: <20220107103056.1.Ifc6ce6bb655ddb8ebbb0f340fcaaa58369bb009c@changeid>



On 07/01/2022 02:31, Knox Chiou wrote:
> sc7180 blow fuses got slightly chances to hit qfprom_reg_write timeout.
> Current timeout is simply too low. Since blowing fuses is a
> very rare operation, so the risk associated with overestimating this
> number is low.
> Increase fuse blow timeout from 1ms to 10ms.
> 
> Signed-off-by: Knox Chiou <knoxchiou@chromium.org>

Applied thanks,

--srini
> ---
> 
>   drivers/nvmem/qfprom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
> index c500d6235bf6b..1840d400fb53c 100644
> --- a/drivers/nvmem/qfprom.c
> +++ b/drivers/nvmem/qfprom.c
> @@ -22,7 +22,7 @@
>   
>   /* Amount of time required to hold charge to blow fuse in micro-seconds */
>   #define QFPROM_FUSE_BLOW_POLL_US	100
> -#define QFPROM_FUSE_BLOW_TIMEOUT_US	1000
> +#define QFPROM_FUSE_BLOW_TIMEOUT_US	10000
>   
>   #define QFPROM_BLOW_STATUS_OFFSET	0x048
>   #define QFPROM_BLOW_STATUS_BUSY		0x1

      parent reply	other threads:[~2022-02-22 17:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07  2:31 Knox Chiou
2022-01-07 14:57 ` Doug Anderson
2022-02-22 16:48   ` Doug Anderson
2022-01-07 16:27 ` Evan Green
2022-02-22 17:30 ` Srinivas Kandagatla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6230f480-a8cb-6807-35eb-b5ee407297f9@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=evgreen@chromium.org \
    --cc=knoxchiou@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®