From: Kunwu Chan <chentao@kylinos.cn>
To: Hamza Mahfooz <hamza.mahfooz@amd.com>,
daniel@ffwll.ch, airlied@gmail.com, tzimmermann@suse.de,
mripard@kernel.org, maarten.lankhorst@linux.intel.com
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
kunwu.chan@hotmail.com
Subject: Re: [PATCH] drm/atomic: Spelling fix in comments
Date: Fri, 27 Oct 2023 10:43:26 +0800 [thread overview]
Message-ID: <6232bb2c-d0b6-4b54-bf29-6f8611542e89@kylinos.cn> (raw)
In-Reply-To: <d4ebae36-265b-4537-ac1b-ae878d236151@amd.com>
Hi Hamza,
Thank you very much for your guidance and advice to me, I have revised
it according to your suggestion.
On 2023/10/25 22:50, Hamza Mahfooz wrote:
> Hi Kunwu,
>
> Can you make the tagline something along the lines of `drm/atomic
> helper: fix spelling mistake "preceeding" -> "preceding"`, in general to
> determine an appropriate prefix, you can see what previous commits used
> when making changes to files in your particular patch, e.g. using the
> following:
>
> $ git log drivers/gpu/drm/drm_atomic_helper.c
> On 10/25/23 04:26, Kunwu Chan wrote:
>> fix a typo in a comments.
>
> For patch descriptions you should try to more descriptive.
>
> So, something like "There is a spelling mistake in
> drm_atomic_helper_wait_for_dependencies()'s kernel doc. Fix it." would
> be better.
>
>>
>> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>> ---
>> drivers/gpu/drm/drm_atomic_helper.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_atomic_helper.c
>> b/drivers/gpu/drm/drm_atomic_helper.c
>> index 2444fc33dd7c..c3f677130def 100644
>> --- a/drivers/gpu/drm/drm_atomic_helper.c
>> +++ b/drivers/gpu/drm/drm_atomic_helper.c
>> @@ -2382,10 +2382,10 @@ int drm_atomic_helper_setup_commit(struct
>> drm_atomic_state *state,
>> EXPORT_SYMBOL(drm_atomic_helper_setup_commit);
>> /**
>> - * drm_atomic_helper_wait_for_dependencies - wait for required
>> preceeding commits
>> + * drm_atomic_helper_wait_for_dependencies - wait for required
>> preceding commits
>> * @old_state: atomic state object with old state structures
>> *
>> - * This function waits for all preceeding commits that touch the same
>> CRTC as
>> + * This function waits for all preceding commits that touch the same
>> CRTC as
>> * @old_state to both be committed to the hardware (as signalled by
>> * drm_atomic_helper_commit_hw_done()) and executed by the hardware
>> (as signalled
>> * by calling drm_crtc_send_vblank_event() on the
>> &drm_crtc_state.event).
next prev parent reply other threads:[~2023-10-27 2:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 8:26 Kunwu Chan
2023-10-25 14:50 ` Hamza Mahfooz
2023-10-27 2:43 ` Kunwu Chan [this message]
2023-10-27 2:44 ` [PATCH v2] drm/atomic-helper: Fix spelling mistake "preceeding" -> "preceding" chentao
2023-10-27 10:26 ` Hamza Mahfooz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6232bb2c-d0b6-4b54-bf29-6f8611542e89@kylinos.cn \
--to=chentao@kylinos.cn \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamza.mahfooz@amd.com \
--cc=kunwu.chan@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®