From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Thara Gopinath <thara.gopinath@linaro.org>,
Peter Zijlstra <peterz@infradead.org>
Cc: mingo@redhat.com, ionela.voinescu@arm.com,
vincent.guittot@linaro.org, rui.zhang@intel.com,
qperret@google.com, daniel.lezcano@linaro.org,
viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
amit.kachhap@gmail.com, javi.merino@kernel.org,
amit.kucheria@verdurent.com
Subject: Re: [Patch v8 1/7] sched/pelt: Add support to track thermal pressure
Date: Mon, 27 Jan 2020 10:28:34 +0100 [thread overview]
Message-ID: <6232d91d-2603-06ca-0e7c-66ec2a137759@arm.com> (raw)
In-Reply-To: <5E2B405A.7040405@linaro.org>
On 24/01/2020 20:07, Thara Gopinath wrote:
> On 01/23/2020 02:15 PM, Dietmar Eggemann wrote:
>> On 16/01/2020 16:17, Peter Zijlstra wrote:
>>> On Tue, Jan 14, 2020 at 02:57:33PM -0500, Thara Gopinath wrote:
[...]
>>>> +#ifdef CONFIG_HAVE_SCHED_THERMAL_PRESSURE
>>
>> I assume your plan is to enable this for Arm and Arm64? Otherwise the
>> code in 3/7 should also be guarded by this.
>
> Yes. I think it should be enabled for arm and arm64. I can submit a
> patch after this series is accepted to enable it.
> Nevertheless , I don't understand why is patch 3/7 tied with this.
> This portion is the averaging of thermal pressure. Patch 3/7 is to store
> and retrieve the instantaneous value.
3/7 is the code which overwrites the scheduler default
arch_cpu_thermal_pressure() [include/linux/sched/topology.h]. I see it
more of the engine to drive thermal pressure tracking in the scheduler.
So all the code in 3/7 only makes sense if HAVE_SCHED_THERMAL_PRESSURE
is selected by the arch. IMHO, 3/7 and enabling it for Arm/Arm64 should
go in together.
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index e688dfad0b72..9eb414b2c8b9 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -164,6 +164,7 @@ config ARM64
>> select HAVE_FUNCTION_ARG_ACCESS_API
>> select HAVE_RCU_TABLE_FREE
>> select HAVE_RSEQ
>> + select HAVE_SCHED_THERMAL_PRESSURE
>> select HAVE_STACKPROTECTOR
>> select HAVE_SYSCALL_TRACEPOINTS
>>
>> Currently it lives in the 'CPU/Task time and stats accounting' of
>> .config which doesn't feel right to me.
>
> It is cpu statistics if you think about it. It is also the same .config
> where CONFIG_HAVE_SCHED_AVG_IRQ is defined.
OK, makes sense.
next prev parent reply other threads:[~2020-01-27 9:28 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 19:57 [Patch v8 0/7] Introduce Thermal Pressure Thara Gopinath
2020-01-14 19:57 ` [Patch v8 1/7] sched/pelt: Add support to track thermal pressure Thara Gopinath
2020-01-16 15:17 ` Peter Zijlstra
2020-01-23 19:15 ` Dietmar Eggemann
2020-01-24 19:07 ` Thara Gopinath
2020-01-27 9:28 ` Dietmar Eggemann [this message]
2020-01-28 13:32 ` Thara Gopinath
2020-01-28 16:15 ` Dietmar Eggemann
2020-02-13 12:03 ` Amit Kucheria
2020-02-13 12:31 ` Amit Kucheria
2020-01-14 19:57 ` [Patch v8 2/7] sched/topology: Add hook to read per cpu " Thara Gopinath
2020-01-14 19:57 ` [Patch v8 3/7] arm,arm64,drivers:Add infrastructure to store and update instantaneous " Thara Gopinath
2020-01-14 19:57 ` [Patch v8 4/7] sched/fair: Enable periodic update of average " Thara Gopinath
2020-01-16 15:15 ` Peter Zijlstra
2020-01-17 11:40 ` Quentin Perret
2020-01-17 12:31 ` Peter Zijlstra
2020-01-17 13:17 ` Vincent Guittot
2020-01-17 13:45 ` Quentin Perret
2020-01-17 13:22 ` Vincent Guittot
2020-01-17 14:55 ` Peter Zijlstra
2020-01-17 15:39 ` Vincent Guittot
2020-01-24 15:37 ` Dietmar Eggemann
2020-01-24 15:45 ` Vincent Guittot
2020-01-27 12:09 ` Dietmar Eggemann
2020-01-27 15:15 ` Vincent Guittot
2020-01-29 15:41 ` Dietmar Eggemann
2020-01-30 9:49 ` Vincent Guittot
2020-01-17 20:20 ` Thara Gopinath
2020-01-14 19:57 ` [Patch v8 5/7] sched/fair: update cpu_capacity to reflect " Thara Gopinath
2020-01-14 19:57 ` [Patch v8 6/7] thermal/cpu-cooling: Update thermal pressure in case of a maximum frequency capping Thara Gopinath
2020-01-14 19:57 ` [Patch v8 7/7] sched/fair: Enable tuning of decay period Thara Gopinath
2020-01-17 11:47 ` Quentin Perret
2020-01-17 15:45 ` Thara Gopinath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6232d91d-2603-06ca-0e7c-66ec2a137759@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=amit.kachhap@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=ionela.voinescu@arm.com \
--cc=javi.merino@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®