From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BA2FC06510 for ; Tue, 2 Jul 2019 15:38:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE2592082F for ; Tue, 2 Jul 2019 15:38:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727036AbfGBPin (ORCPT ); Tue, 2 Jul 2019 11:38:43 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:39951 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725868AbfGBPin (ORCPT ); Tue, 2 Jul 2019 11:38:43 -0400 X-Originating-IP: 81.250.144.103 Received: from [10.30.1.20] (lneuilly-657-1-5-103.w81-250.abo.wanadoo.fr [81.250.144.103]) (Authenticated sender: alex@ghiti.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 57833E0005; Tue, 2 Jul 2019 15:38:32 +0000 (UTC) Subject: Re: [PATCH v3 1/2] x86, arm64: Move ARCH_WANT_HUGE_PMD_SHARE config in arch/Kconfig To: Hanjun Guo , Christoph Hellwig , Mike Kravetz , Catalin Marinas , Will Deacon , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org References: <20190701175900.4034-1-alex@ghiti.fr> <20190701175900.4034-2-alex@ghiti.fr> <18144cc2-f552-b2cc-c41a-47c754de2b0d@huawei.com> From: Alexandre Ghiti Message-ID: <62390cef-2417-3b6d-970d-bddecc4ac005@ghiti.fr> Date: Tue, 2 Jul 2019 17:38:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <18144cc2-f552-b2cc-c41a-47c754de2b0d@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: fr Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/2/19 3:27 AM, Hanjun Guo wrote: > On 2019/7/2 1:58, Alexandre Ghiti wrote: >> ARCH_WANT_HUGE_PMD_SHARE config was declared in both architectures: >> move this declaration in arch/Kconfig and make those architectures >> select it. >> >> Signed-off-by: Alexandre Ghiti >> --- >> arch/Kconfig | 3 +++ >> arch/arm64/Kconfig | 4 +--- >> arch/x86/Kconfig | 4 +--- >> 3 files changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/arch/Kconfig b/arch/Kconfig >> index c47b328eada0..d2f212dc8e72 100644 >> --- a/arch/Kconfig >> +++ b/arch/Kconfig >> @@ -577,6 +577,9 @@ config HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD >> config HAVE_ARCH_HUGE_VMAP >> bool >> >> +config ARCH_WANT_HUGE_PMD_SHARE >> + bool >> + >> config HAVE_ARCH_SOFT_DIRTY >> bool >> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index 697ea0510729..c862575decd3 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -71,6 +71,7 @@ config ARM64 >> select ARCH_SUPPORTS_NUMA_BALANCING >> select ARCH_WANT_COMPAT_IPC_PARSE_VERSION if COMPAT >> select ARCH_WANT_FRAME_POINTERS >> + select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) >> select ARCH_HAS_UBSAN_SANITIZE_ALL >> select ARM_AMBA >> select ARM_ARCH_TIMER >> @@ -901,9 +902,6 @@ config HW_PERF_EVENTS >> config SYS_SUPPORTS_HUGETLBFS >> def_bool y >> >> -config ARCH_WANT_HUGE_PMD_SHARE >> - def_bool y if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) >> - > Reviewed-by: Hanjun Guo Thanks for catching the previous mistake again and thanks for that, Alex > > Thanks > Hanjun > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv