From: "Powen Kao (高伯文)" <Powen.Kao@mediatek.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "Peter Wang (王信友)" <peter.wang@mediatek.com>,
"Eddie Huang (黃智傑)" <eddie.huang@mediatek.com>,
"CC Chou (周志杰)" <cc.chou@mediatek.com>,
"Alice Chao (趙珮均)" <Alice.Chao@mediatek.com>,
"Ed Tsai (蔡宗軒)" <Ed.Tsai@mediatek.com>,
wsd_upstream <wsd_upstream@mediatek.com>,
"Chun-Hung Wu (巫駿宏)" <Chun-hung.Wu@mediatek.com>,
"Naomi Chu (朱詠田)" <Naomi.Chu@mediatek.com>,
"Stanley Chu (朱原陞)" <stanley.chu@mediatek.com>
Subject: Re: [PATCH v2 1/1] scsi: ufs: core: Make UFS_MCQ_NUM_DEV_CMD_QUEUES a module parameter
Date: Tue, 30 May 2023 10:04:21 +0000 [thread overview]
Message-ID: <623ced08cabcb92763f75f13cd9a6c67d8b10fc6.camel@mediatek.com> (raw)
In-Reply-To: <fc5b8f88-23ec-4f15-9b24-947f3cec4471@collabora.com>
On Tue, 2023-05-30 at 09:24 +0200, AngeloGioacchino Del Regno wrote:
>
> I imagine that MediaTek's UFS IP does not support dev_cmd_queues=1,
> does it?
>
> In that case, this should not be a UFS module parameter, but a
> setting that
> you provide from ufs-mediatek instead.
>
> Regards,
> Angelo
Hi Angelo
Our IP do work with dev_cmd_queues=1, but sacrifice one hwq
specifically for dev commands leaving (N-1) hwq to (N) CPUs for
submission doesn't make much sense.
Actually I would prefer making it a dts property than module parameter,
however, to match convention like `poll_queues` module parameters is
chosen.
Po-Wen
next prev parent reply other threads:[~2023-05-30 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 2:35 Po-Wen Kao
2023-05-30 7:24 ` AngeloGioacchino Del Regno
2023-05-30 10:04 ` Powen Kao (高伯文) [this message]
2023-05-30 23:50 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=623ced08cabcb92763f75f13cd9a6c67d8b10fc6.camel@mediatek.com \
--to=powen.kao@mediatek.com \
--cc=Alice.Chao@mediatek.com \
--cc=Chun-hung.Wu@mediatek.com \
--cc=Ed.Tsai@mediatek.com \
--cc=Naomi.Chu@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cc.chou@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®