From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FBCE3EDAC2 for ; Wed, 18 Mar 2026 19:28:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773862109; cv=none; b=cKAbkFmgF3cSObYCOVywQ14E9jvDWzz3LF8gqRaJmJvn9TrPy+MTgjFUodKI1CrN8OfFl0vrsV9tl9SG00vE486UFU8AU8RMS4W4HUbaQgxBkgyaS1FZ0oxkqLhIH5jrmMQdYZdPsULSd6WFjWNW3LEBmdLLvVRXzvp2uDY14jY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773862109; c=relaxed/simple; bh=rQgzNmdeBzkuUi68LwdSFXfsPmmfyRBvSJC88y6enxw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KOrP8D2rOrTegAPE6rZDouR31uOfWVqC0gc4Nia6vRHExyxPzTL8cVfRCao+KToPZTQUw5DH5InsDotsgDBc8MdTs+SXSqOiMlvfJpBiSSlhouTj3dIMqcLHndGMJjXl3ozPBVOeJjGHxl3QE6j5pzXTTPahN/Pe7ktWBn594Sw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L+/zVigX; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L+/zVigX" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-439cd6b0aedso120326f8f.1 for ; Wed, 18 Mar 2026 12:28:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773862106; x=1774466906; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Wv6jP1e3M1+PHnQU5Hq+FG1C5SwOP02k/za1P8Uz0WI=; b=L+/zVigX0xm5Q7TrsFxyn/+xri613+t9/hSxe0ys+NWMcRFzonJBwGdl7QVJxmhAzb nsvwAwnVWCejY+Qp6KUhIw3UgnuLsJ9RuzkIQmRPaakZWO77sEXEZdtM+Ks2nswyJZQc N4flB3UFJ+rjGbWD/aU1FzmAxFEpsOynPwInQCpq65ZeMHn775orWuWMBYdgs+bLEqVX 9hWIUpOffOQMTQU55tnNnv2DMfrrAXsr3rZub/qxSq//BW6VeaqsoCP/cc6oZnJM8Y6V GfAxsr8AVSZi+eetNVipM+kCsi8KytzzuVRK2a/aI0r3tB93/lxaPnbPZznE5l0rqyBU AQVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773862106; x=1774466906; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Wv6jP1e3M1+PHnQU5Hq+FG1C5SwOP02k/za1P8Uz0WI=; b=Hp7ObECJdnlIe2xXcbxsrU9F4a5RFzvSfYQS9d9dBLn4oZ/zXwTit0BKfmZI049kD0 OKr5am+lhA5eauPg6JisP3W4tapz3oVSQ2GDPY8OKbpa/OlnBXgWtSao/3XDTYKrusMS /vLzdDFh3dOb256J0fAHTMN9tkKmc1CsFGFMvnqH6BzDD6oHM8KLnHCVrEjtPY0Y3/0+ LvXTqDyL4IYaFTi4/8p0MgdJvtlyUNzwi4vUXRbaKfwXkzTAEZ/s75kQGiewhKNu+3Ou 0vEFYVf2ZITI0da7obnqlmOp+ENgFIY2HUgf7b2fGXZczYglnogNz8hf91Dmzd2z8b0q JWjQ== X-Forwarded-Encrypted: i=1; AJvYcCWTKm0EQh6eHpGZ6/W2fhJmEh/WO4RVT0oOtBGamtMzSsWSuo0AW5iha7Mf9fEDk19yi6lWAfXsJaqXWhU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6b7HppjsYp1dYISrfSTgoHL6Qy+q4qtnEQBP2iyOD6l6scZWC eIBZ473ZO8Ue45uxlySm6n/i3sLKylZw1kFJex5TO8xHV3rkGfXGbOiE X-Gm-Gg: ATEYQzwRCmhAzO9j9dTxkalWCsy2F9RYY6pkTGg0bVqvWo8WJNRXncCLJOG0k8tF+ZG e75RCYim2Pciwf/ZG5m8YJrUvxZuaiukVnZON6jvHSzGwFy3dFEiOMJFmM/nzR/fQETnWpIl3zF gEkXwtdb7SKdJ+id8Lr01N6BGpt+mjdxV8TfboKxSXtm2yLoQhhXY2sJK7o6R9hWJ//BcBxfnfl 9M38FcRtdXLH9DtCA/Hy/mtuH4u4AbhgP6o29dbqEPOlaC1q0czcgCCQQlY/G4ZLf7JEQr5rHAL 77i31yWbB2nweDM/a/ZC+5PFdkoxDGo1jqU+Zte/27ZXfGD4ebF7OdeR2vEXf532SsZ9rjQndF9 SV1kXkhOQpSIfG8B/Cp8Wbd97iToMjn+/ShoHnE9dKl2QyHOYuTOUx4HUp1zqVYFkKx8m/h4Ize Qp0bqnYl79L1HdQGP8Zl3WpcakUOXblla+sZhYhR+/br1PezJznrWg92XO1pNAN/sAiZSM5aKL+ BACyDsj X-Received: by 2002:a05:6000:400a:b0:439:bcdb:95a8 with SMTP id ffacd0b85a97d-43b52648c7cmr7805238f8f.0.1773862105581; Wed, 18 Mar 2026 12:28:25 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-12-248.dynamic.telemach.net. [82.149.12.248]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b51899617sm10663715f8f.31.2026.03.18.12.28.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 12:28:25 -0700 (PDT) From: Jernej =?UTF-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , wens@kernel.org Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , linux-sunxi@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/sun4i: layers: Use drm_fb_dma_get_gem_addr() to get display memory Date: Wed, 18 Mar 2026 20:28:23 +0100 Message-ID: <6247601.lOV4Wx5bFT@jernej-laptop> In-Reply-To: References: <20260309165635.1138413-1-wens@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Dne sreda, 18. marec 2026 ob 10:35:35 Srednjeevropski standardni =C4=8Das j= e Chen-Yu Tsai napisal(a): > Hi, >=20 > On Tue, Mar 10, 2026 at 12:56=E2=80=AFAM Chen-Yu Tsai w= rote: > > > > Commit 4636ce93d5b2 ("drm/fb-cma-helper: Add drm_fb_cma_get_gem_addr()") > > adds a new helper, which covers fetching a drm_framebuffer's GEM object > > and calculating the buffer address for a given plane. > > > > This patch uses this helper to replace our own open coded version of the > > same function. > > > > Signed-off-by: Chen-Yu Tsai > > --- > > drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 16 ++------------- > > drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 27 ++------------------------ > > 2 files changed, 4 insertions(+), 39 deletions(-) > > > > diff --git a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c b/drivers/gpu/drm/s= un4i/sun8i_ui_layer.c > > index f08f6da55dd0..72c92203ae63 100644 > > --- a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > > +++ b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > > @@ -124,25 +124,13 @@ static void sun8i_ui_layer_update_buffer(struct s= un8i_layer *layer, > > { > > struct drm_plane_state *state =3D plane->state; > > struct drm_framebuffer *fb =3D state->fb; > > - struct drm_gem_dma_object *gem; > > dma_addr_t dma_addr; > > u32 ch_base; > > - int bpp; > > > > ch_base =3D sun8i_channel_base(layer); > > > > - /* Get the physical address of the buffer in memory */ > > - gem =3D drm_fb_dma_get_gem_obj(fb, 0); > > - > > - DRM_DEBUG_DRIVER("Using GEM @ %pad\n", &gem->dma_addr); > > - > > - /* Compute the start of the displayed memory */ > > - bpp =3D fb->format->cpp[0]; > > - dma_addr =3D gem->dma_addr + fb->offsets[0]; > > - > > - /* Fixup framebuffer address for src coordinates */ > > - dma_addr +=3D (state->src.x1 >> 16) * bpp; > > - dma_addr +=3D (state->src.y1 >> 16) * fb->pitches[0]; > > + /* Get the start of the displayed memory */ > > + dma_addr =3D drm_fb_dma_get_gem_addr(fb, state, 0); >=20 > I just realized while reading more code that there's a subtle difference > here. >=20 > The original code used state->src.x1, which is the "clipped" coordinates, > while drm_fb_dma_get_gem_addr() uses state->src_x, which is the original > coordinates. >=20 > Jernej, do you know which one the driver is supposed to use? Or maybe > it doesn't matter? I would say that it doesn't matter for point of origin. Original coordinates use uint32_t values which means origin cannot be out of screen (negative numbers). What I found interesting is that clipped coordinates are int, e.g. they can be negative. Best regards, Jernej