From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D01937F8A6 for ; Mon, 23 Mar 2026 21:34:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774301657; cv=none; b=U8M4teCBLnJK39gW1HWQB7RIggH5/yRhgzdhQbN/YoWJl+10wf3jMeTPlqTqZAk1UUh+D57OiQlTtZ3V9QHtqRiBOgcdwf6rUFXvV1+2q0a4q3SqAOxbTeFEOXRDqa7Z0lTX0JmAo3G/djwycWB9R3gXdyK75mNqig+o0BhmNhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774301657; c=relaxed/simple; bh=wZnyTC1cxmFnDFRhNyKK32ZOkfQPMZymv9huKfcg/C4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nQJr6vSWYZsdPhlvC2rhdR3JOXgOYlElf/mcbHHE3AdAtcyLyLScbQBNQD7/cMq1mbPkKq4UQtLO9GBxKDPzaO2n6ag+a+WwTLxcW5x82SmkAlQnq4fVSez6W64dRrqEo9ydj1T1mWuOobTfsZQrP0pmo2CRqE38s//QmM/UxMA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=onFnQJqd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UycaQM7v; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="onFnQJqd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UycaQM7v" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NIYuFP1909250 for ; Mon, 23 Mar 2026 21:34:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YEv3TpmBWdZCzDldOTrF3vertS4FiegdmYw0vOk6kko=; b=onFnQJqd4fEKGdeN 86+hxSTsWm3ZZbxdfHeJGIDmBJhRGb2A4J8MyrZIZ5qGh171GXNP0cotGgXeNYAB Nh6euS1M39v3ez4lE5prge6HP2zTAz/wEZU7mInocGYk5jYJkmqg1RaRUdnYAM3z bi8M/tK+8j5GuxWFJyTlCsj3l6tCmk5LHYhM+0UQs9Yt/bq6gewcBB0UEwC4BcIU NxeZ2/Au7SkZ0hMvcekoASfc1hrceG1zdPFN1craBCytHoFGMlotJ/3GpbhTEPUy thPa4JkYqUpTJKkPo5foDYSLoMYBKzhU17SE1tfFPO/N+3kCrxhF7P7T/OgitBv1 3+E1Ag== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d3awyrgtd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 21:34:15 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b0601ff3d9so11406925ad.2 for ; Mon, 23 Mar 2026 14:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774301655; x=1774906455; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YEv3TpmBWdZCzDldOTrF3vertS4FiegdmYw0vOk6kko=; b=UycaQM7v0p4RcsB+UmNYf5s0OBvNdS0s3eCAruSK4MT2uU1TaqkrFrGbYFwpJu++yf L/0OqH4oDzSc900Djj4Bx8Vg979qeiuq2XROuaCOO4jq+ZXXIFm36CeHvh9mHvqFzQqS sEv+kthJQje074pdQB+FrAVwf4xGqAcnR0CQRPk352MfxsskQMIk871fdI7ZSzjwpMV2 rcweecL+b8OGHcu1kE4GT2gbtXfsTvU3fWkq30XUSACHD89uFlXCT+yymR22AwhNd064 5o4rOs3xmONzftysTKEPIB23EUheOR0n6NJ8KQgmfNDUui5qkzHeOo3RBkxi1Ky0RwXE 1Odw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774301655; x=1774906455; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YEv3TpmBWdZCzDldOTrF3vertS4FiegdmYw0vOk6kko=; b=Cg9bCYNS/2ebxWFaYsv1vobWJYDGaDNHjDZMdz1L18D0h30I4LFVeioT3vQOxUIljG bTVxyou64zOVurvSNv+7U1CE8s7CMe6SA518u1BuSstBXJYr4hBUG9Lj6yJOel+t3vRN UIye7phH/LOJz294MyjdN7wqA0IAyNTLX51NvNUS0gRMz8pQsnQUBhqIp7DpVhZSkaNP Rm61Gr9sELZkpFhDkWP5CaDuKZjpU1//f2tio6vtkhpRvK49woCNOioZVhDZ1LW4EtOP 4ZIJiqZ0RAUVz8X5OAjMjYoPyYuEb3y0oensK34IFwcPm9ZI4eKSZWrMRyAQxxPBCDG1 Xh5w== X-Forwarded-Encrypted: i=1; AJvYcCX9/lLBtXxl37WYqp5Z20lxMUTVYft6KUCOeVZBGGVb08XafskZZFVSQLuC9751DH9nvAy3kwzSZnSGCWM=@vger.kernel.org X-Gm-Message-State: AOJu0YyBobvER4AEJvCPuo1tDfR5/0sQrAN9L1O0XnaoogmHMabVGXrX nzY7f4XOAo1Yjd47jfYaB/hkrIPnKm7nLBiVm9QBIDoDi625Ia2mOcMBNMZlGQCiUJwWn30E2dK ynpJv9B7dFTG4M0skDQV9oiTLbBNBIa8yemsRNC30RwexNG3rGBhNJQjuNdDHs8uVZ8A= X-Gm-Gg: ATEYQzygqppIeQ78SzJ5B9sFZwN105qCmAbn1zj3V/VVCbEa2GQ7TIMDzDyPPHOYf51 3J7mk3zYoE5ayTQDPLl1rshUjIEPimkV21uoGHh2DgU/pLQFsfMCaP0iCHL/jAi1RvUgHIjpK3M 8ghcv6x9BgYEmlCyi0QZkVJzxncretwp9dkTexKBQ2pgrFm56sZSCJFczjGaLGetqQr33OZ7U/C Fm9oMyOUjm0+nQ3DAP1rEi3guxE9kFl6YLDzwS3gJtzfcpb+3ZQenZg6kFJfJANDXGWr6YnL+O9 LbY4TsaEnq83ryZDkNgqPTNsmMmohPt0Db+UzXeFC+dmyBEqjj45RFuplE+zZ5neyL2cA/HRbF6 qrlcvslMGFhRT0sL62xzTabX5lshBAzrHuMCSogXv/LUhj4k= X-Received: by 2002:a17:902:d582:b0:2b0:708f:4dc7 with SMTP id d9443c01a7336-2b08278afb0mr124510695ad.29.1774301655220; Mon, 23 Mar 2026 14:34:15 -0700 (PDT) X-Received: by 2002:a17:902:d582:b0:2b0:708f:4dc7 with SMTP id d9443c01a7336-2b08278afb0mr124510355ad.29.1774301654732; Mon, 23 Mar 2026 14:34:14 -0700 (PDT) Received: from [192.168.1.12] ([106.222.230.237]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b083516189sm127038525ad.16.2026.03.23.14.34.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 14:34:14 -0700 (PDT) Message-ID: <6249ba79-e223-439d-8606-69df24758c95@oss.qualcomm.com> Date: Tue, 24 Mar 2026 03:04:06 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/16] drm/msm/a6xx: Add SKU detection support for X2-85 To: rob.clark@oss.qualcomm.com Cc: Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> <20260324-a8xx-gpu-batch2-v1-12-fc95b8d9c017@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDE2MCBTYWx0ZWRfX3j8wiM+BKCG2 T1znoUkFxCCXBbcd9f33WqyPO2degG+QleV+BhF0GSVvb7cXVsEM5OKr2ff0uzRagsqwWZVGWyY 5KgPLkIF+JKC3YWI+85Wj0Ot83O0ZoSqkULz0wKSJi0D+d5TN5dpLzFM3vB9Q/OY5dlPbKCS8IG qbbd9vWh8Wo0HA421JLdTHwQhNlIlniKgbtQPGy4fqQcYv5hP2dIEpMUts86DvaEoyVgpVVK24C GNw3J0a0FpjuJXfn2HO4QhOjcayctiQ4wTo9wnS9pYE0gIYMQz0H6RePyBsygRTSPQeFmHNsz0K +F5FPy+wPoFuF0HZ/Brz3S5UaLf/Gtt5FKy7HKvc+XVGqkaQqhOoKAV2W4K2xihe2LWUuHtr6Ed SsvZ9gB7zJfGAsrP8AmV+mQFE+gFlc550lTcwEmIlnHJUK0IvrRbuNe7PCJbbg4NRhYcBM1Np/T muQ0piMzcY70fpwRRCA== X-Proofpoint-ORIG-GUID: MQOQReeIXlykmmECgZ8OsCK6DQxNog7Z X-Authority-Analysis: v=2.4 cv=KuhAGGWN c=1 sm=1 tr=0 ts=69c1b1d7 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=WRfdsTvTEh9BIu3+I5rxZw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=7GsrDj-skTPUI7dcwhIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: MQOQReeIXlykmmECgZ8OsCK6DQxNog7Z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_05,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 phishscore=0 priorityscore=1501 impostorscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230160 On 3/24/2026 2:07 AM, Rob Clark wrote: > On Mon, Mar 23, 2026 at 1:13 PM Akhil P Oommen wrote: >> >> Adreno X2-85 series present in Glymur chipset supports a new mechanism >> for SKU detection. A new CX_MISC register exposes the combined (or >> final) speedbin value from both HW fuse register and the Soft Fuse >> register. >> >> Implement this new SKU detection along with a new quirk to identify the >> GPUs that has SOFT SKU support. Also, enable this quirk for Adreno X2-85 >> and add its SKU table to the catalog. >> >> Signed-off-by: Akhil P Oommen >> --- >> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 6 ++++ >> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 9 +++++- >> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 41 ++++++++++++++++++++++----- >> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 5 ---- >> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 1 + >> drivers/gpu/drm/msm/registers/adreno/a6xx.xml | 4 +++ >> 6 files changed, 53 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c >> index 79a441e91fa1..d7ed3225f635 100644 >> --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c >> +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c >> @@ -1731,6 +1731,7 @@ static struct msm_gpu *a5xx_gpu_init(struct drm_device *dev) >> struct adreno_gpu *adreno_gpu; >> struct msm_gpu *gpu; >> unsigned int nr_rings; >> + u32 speedbin; >> int ret; >> >> a5xx_gpu = kzalloc(sizeof(*a5xx_gpu), GFP_KERNEL); >> @@ -1757,6 +1758,11 @@ static struct msm_gpu *a5xx_gpu_init(struct drm_device *dev) >> return ERR_PTR(ret); >> } >> >> + /* Set the speedbin value that is passed to userspace */ >> + if (adreno_read_speedbin(&pdev->dev, &speedbin) || !speedbin) >> + speedbin = 0xffff; >> + adreno_gpu->speedbin = (uint16_t) (0xffff & speedbin); >> + > > I will confess to not expecting to see a5xx changes in a patch adding > x2-85 sku detection :-) > > Maybe split the code-motion out of adreno_gpu_init() into it's own commit? > I forgot to mention the refactor part in the commit message. Ack. Will split this patch. -Akhil > BR, > -R >