From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: "Christian Heusel" <christian@heusel.eu>,
"Jens Axboe" <axboe@kernel.dk>,
"Dave Chinner" <dchinner@redhat.com>, "Jan Kara" <jack@suse.cz>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Christian Brauner" <brauner@kernel.org>,
"Min Li" <min15.li@samsung.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Damien Le Moal" <dlemoal@kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "dan.carpenter@linaro.org" <dan.carpenter@linaro.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] block: print symbolic error name instead of error code
Date: Fri, 12 Jan 2024 04:34:42 +0000 [thread overview]
Message-ID: <624aac65-6162-4ba7-b891-694c6044d235@nvidia.com> (raw)
In-Reply-To: <20240111231521.1596838-1-christian@heusel.eu>
On 1/11/24 15:15, Christian Heusel wrote:
> Utilize the %pe print specifier to get the symbolic error name as a
> string (i.e "-ENOMEM") in the log message instead of the error code to
> increase its readablility.
>
> This change was suggested in
> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
>
> Signed-off-by: Christian Heusel <christian@heusel.eu>
> ---
>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2024-01-12 4:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 23:15 Christian Heusel
2024-01-11 23:37 ` Damien Le Moal
2024-01-11 23:56 ` Christian Heusel
2024-01-12 0:12 ` Jens Axboe
2024-01-12 4:34 ` Chaitanya Kulkarni [this message]
2024-01-12 16:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=624aac65-6162-4ba7-b891-694c6044d235@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=christian@heusel.eu \
--cc=dan.carpenter@linaro.org \
--cc=dchinner@redhat.com \
--cc=dlemoal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=min15.li@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®