From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Rae Moar <rmoar@google.com>, skhan@linuxfoundation.org
Cc: davidgow@google.com, brendan.higgins@linux.dev,
rdlatypov@google.com, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] Documentation: kunit: improve example on testing static functions
Date: Tue, 20 May 2025 11:55:12 +0200 [thread overview]
Message-ID: <62602f2b-1f87-4510-a27b-cd0755cdfae2@t-8ch.de> (raw)
In-Reply-To: <20250516190631.1214081-1-rmoar@google.com>
On 2025-05-16 19:06:31+0000, Rae Moar wrote:
<snip>
> -Alternatively, you could conditionally ``#include`` the test file at the end of
> -your .c file. For example:
> + /* In the KUnit test file "my_file_test.c" */
> +
> + #include <kunit/visibility.h>
> + #include <my_file.h>
> + ...
> + MODULE_IMPORT_NS(EXPORTED_FOR_KUNIT_TESTING);
This should to be MODULE_IMPORT_NS("EXPORTED_FOR_KUNIT_TESTING").
See commit cdd30ebb1b9f ("module: Convert symbol namespace to string literal")
Can this still be fixed up?
> + ...
> + // Use do_interesting_thing() in tests
<snip>
prev parent reply other threads:[~2025-05-20 9:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 19:06 Rae Moar
2025-05-17 9:32 ` David Gow
2025-05-20 9:55 ` Thomas Weißschuh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62602f2b-1f87-4510-a27b-cd0755cdfae2@t-8ch.de \
--to=linux@weissschuh.net \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rdlatypov@google.com \
--cc=rmoar@google.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®