From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753557AbbJGLEQ (ORCPT ); Wed, 7 Oct 2015 07:04:16 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:58686 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752551AbbJGLEP (ORCPT ); Wed, 7 Oct 2015 07:04:15 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Russell King - ARM Linux , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, Gerd Hoffmann , Dave Airlie Subject: Re: [PATCH] drm/virtio: use %llu format string form atomic64_t Date: Wed, 07 Oct 2015 13:04:06 +0200 Message-ID: <6260324.3MlUEc3veg@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151007104502.GH21513@n2100.arm.linux.org.uk> References: <5082760.FgB9zHNfte@wuerfel> <20151007104502.GH21513@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Dwsj+u/q+ufiPMTfhQbv4dnawNHJmLWWrsX3iqv1hGYQOA6faNy F2vQovLp2UanCp8Qk+JUQV0ImoM1+UvIaUgLgSZO1U3UX1WP7f6xjuODVT9tAFCvjV5ZKnI 08rR2un5JSroVQsqiSDj5VJxg7FnqzKymfNz6u+kVXVeBR4Tm1g4DG47a+/V+YOPPf1KZFF orkAUXFGIUU51+HXsyF4w== X-UI-Out-Filterresults: notjunk:1;V01:K0:9U7zgHWXQLo=:j19KKgsduaJ/e7tbeSwF2D on/KpADWdcilDkVQrWpbzDDa+Kp8INZnDkBJ6fUcH8jsQt+hKYBjWry9378OUxPnA4M2cyi3B pIuRI9MprYZwNarOdUKx/VYUKd3xiM6cLYjm/XjHRPfMsey55fJntSjj6I3RyGI/ASMdL70XG MwicP1VYZujxDf0hbdAr8GQzFbkep751rpmraHOR7iojtAgdyMdpJx9xqMBGq9SbxZsDFgpCN o22MHBhrh5XIkU718M1S00cQO2b35DSXSpyR/Fy7oHuZeuI63TpZG4VlPLb46nChcLVabPnvc e3Xq0zKRcqKD6N8k/qhts4qopK8DUEGODD/obp9s3mEWd9RMLHryl/NJuEG2vz/FmX3oWkO1n Kc4j8KzTwPK6jRqPzO05MButfn50Tjf5q0VX+/H303iNE8V5umLQiSR/jEeaItMH62feembix zen7ZBtdsXDfPRgToO6pqJlN2vYkO6QwFMwIkIn8oHBYnVGP2sMocoipUPYswQ1z54aIouero cu9Vv8U21Vnb1u6qCUkmWJTgjJBn9y51cRAtZaG3gVX27A8UEUNrfsLWaP8aV/ZXQRK2yI6PZ JTYvp6S8KqfA0y/xyUamyo2EZtt2g5Iww7azkN8GMqk+KPQpkHSA2fTRv27vJAjMNUP8Gn1nI zi32X4MHy+HmXpXAJX9xh7PlcBF+pZ+pZ88xeVcCMV/Nz5LHC1M+6ZZZd+Nep/+dpYeGZmZ0A Im2SpRzZOeWADCOi Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 07 October 2015 11:45:02 Russell King - ARM Linux wrote: > On Wed, Oct 07, 2015 at 12:41:21PM +0200, Arnd Bergmann wrote: > > The virtgpu driver prints the last_seq variable using the %ld or > > %lu format string, which does not work correctly on all architectures > > and causes this compiler warning on ARM: > > > > drivers/gpu/drm/virtio/virtgpu_fence.c: In function 'virtio_timeline_value_str': > > drivers/gpu/drm/virtio/virtgpu_fence.c:64:22: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'long long int' [-Wformat=] > > snprintf(str, size, "%lu", atomic64_read(&fence->drv->last_seq)); > > ^ > > drivers/gpu/drm/virtio/virtgpu_debugfs.c: In function 'virtio_gpu_debugfs_irq_info': > > drivers/gpu/drm/virtio/virtgpu_debugfs.c:37:16: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'long long int' [-Wformat=] > > seq_printf(m, "fence %ld %lld\n", > > ^ > > > > In order to avoid the warnings, this changes the format strings to %llu > > and adds a cast to u64, which makes it work the same way everywhere. > > You have to wonder why atomic64_* functions do not use u64 types. > If they're not reliant on manipulating 64-bit quantities, then what's > the point of calling them atomic _64_. I haven't checked all architectures, but I assume what happens is that 64-bit ones just #define atomic64_t atomic_long_t, so they don't have to provide three sets of functions. Arnd