From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D416B8834 for ; Fri, 23 Jan 2026 12:40:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769172026; cv=none; b=R+o4oTnrA9Ipe521cwNZQzYQFH6Bf5h881rK4hnSLVkVVc0nysRmbzrr6kGY7/xpIv3pSobv2pZwMDaOI63/nrmC5KfyYVyKV+zzTH0teg0FNwuozhQELehtxbf95YSi4cailma2wD6La9nCuH3l/aXUvpJI8uGgwrZykDWviK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769172026; c=relaxed/simple; bh=YVCAZIB8zqL52iu0gTAht+hoki1UkBjm4fZwghyslZA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C239v1Ijhy4A0g+3jKCQwSo/6e2NSY9ZItYSud2UgLaUBUpB0CSx5+CSt5/dhgMkYQCXWZhk84pmRJzx9Cpm1sriKCsh84NGvi+p+w6wYXGKV2EZDndbWp7f1xcbhXoO6eJKE3AZIV9R4NCRsivTC9hHfvTOq7fp7O5aj44BHNc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AD72D1476; Fri, 23 Jan 2026 04:40:17 -0800 (PST) Received: from [10.164.136.38] (unknown [10.164.136.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F3D8C3F740; Fri, 23 Jan 2026 04:40:20 -0800 (PST) Message-ID: <626132d6-360d-4655-804c-f36220b6f669@arm.com> Date: Fri, 23 Jan 2026 18:10:11 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-new v5 5/5] mm: khugepaged: set to next mm direct when mm has MMF_DISABLE_THP_COMPLETELY To: Vernon Yang , akpm@linux-foundation.org, david@kernel.org Cc: lorenzo.stoakes@oracle.com, ziy@nvidia.com, baohua@kernel.org, lance.yang@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vernon Yang References: <20260123082232.16413-1-vernon2gm@gmail.com> <20260123082232.16413-6-vernon2gm@gmail.com> Content-Language: en-US From: Dev Jain In-Reply-To: <20260123082232.16413-6-vernon2gm@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 23/01/26 1:52 pm, Vernon Yang wrote: > From: Vernon Yang > > When an mm with the MMF_DISABLE_THP_COMPLETELY flag is detected during > scanning, directly set khugepaged_scan.mm_slot to the next mm_slot, > reduce redundant operation. > > Without this patch, entering khugepaged_scan_mm_slot() next time, we > will set khugepaged_scan.mm_slot to the next mm_slot. > > With this patch, we will directly set khugepaged_scan.mm_slot to the > next mm_slot. > > Signed-off-by: Vernon Yang > Acked-by: David Hildenbrand (Red Hat) > Reviewed-by: Lance Yang > --- > mm/khugepaged.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index be1c09842ea2..1dc19c1b1f97 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -2558,7 +2558,7 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, enum scan_result > * Release the current mm_slot if this mm is about to die, or > * if we scanned all vmas of this mm. > */ Need to update comment: "...or THP got disabled". Reviewed-by: Dev Jain > - if (hpage_collapse_test_exit(mm) || !vma) { > + if (hpage_collapse_test_exit_or_disable(mm) || !vma) { > /* > * Make sure that if mm_users is reaching zero while > * khugepaged runs here, khugepaged_exit will find