From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C9DC367B9B for ; Tue, 15 Sep 2026 22:30:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789511441; cv=none; b=PUMZS2fhoLFzrm++UZ/cV6sRewN1HdqrMu0i9JWvSz/F8NfkR6FrgTqtkAugK+YpCA+/mmWYNtlGBok+M/a+bpbZiTJ9CRNSwVH1k2BYQHxPrALctdSaumYD08Ajem8X9HKV6aXZxy7bdMHmWRWBlNB6nIIfhJd+XdKW9nsV5V4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789511441; c=relaxed/simple; bh=vVmTWSLMVujJSG3CQY6fFBRFGflHp4JcNvvw1BRS2so=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fPnr0I0RA+20KyC2Y6HwcDScLcUKAP71gP2DR6QzuJhNKPMiJ/qqUhi9og1SUvHL+mZR0ZYTA1cIED0I9H+PiuXVfLLE/DrxJbkVbIcbFMGFmPzdXRCZjVugjv0DDnG2qt8KuT68zjRaRa9KQTrnTuge1qLQ+eLam+HReKhMY2g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZVDAdXDo; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gR7t7Y7c; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZVDAdXDo"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gR7t7Y7c" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68FLYkCg721224 for ; Tue, 15 Sep 2026 22:30:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OoaUvNij8YmbcFsxH3lXmPdyT4LUwKvkwpbwWWFHxPE=; b=ZVDAdXDo0ulVpyXb g8NopG2tbvKSgTtcqDpDuO4nio/SQwZ0JzyDXFJ0rGtBNkZo/LmUNoa3jT7hlceo 6w7Mhbw6AfmN2EdU3pRwH6JZ9HqJlcU2PLDuqBZfaykiIb6ShRxb8EfEYcFwkDZ5 PTIdh17Y96kV5BeHTk50zBiw3iogDbOVtK/yfZI17mAHitg7rRfbAF1pLDmEKcDh WNSX/EDeIRPcXhVy0VN6MPcC7ly6233oHvBDjJH9KN56YDulhUgZeqDfBV9woUfy 2hc2LKssaAgonXCEHqjV+37z/2SQKBIyXBgmz/uCg3bMHzabGv73qApnxcTBCIdj brA15w== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqah9s5f7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 15 Sep 2026 22:30:38 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-9104c2ce026so162367506d6.3 for ; Tue, 15 Sep 2026 15:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789511438; x=1790116238; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OoaUvNij8YmbcFsxH3lXmPdyT4LUwKvkwpbwWWFHxPE=; b=gR7t7Y7cyhJpDp2CnGQzkQB2fpHzSWv+qO/P7VaDyKbSGmyDIa4D3pq+v2ITaWYWrz AsdybGRP5rr45idNI5z7xjnBCjeQDH8WALE7MZbfTkSQMejGg7d3r6lMYP01VU52xBaR x+pd84S3u8qHC+ahal39qCMu01RLVN+PlpE2YSAAJGU4sqdK4fXVi3ArpyM7jOyh/qk0 Uudpu5rjlYWVg3pgACvcUYr7KR/l0JHbCcLHGwAhp7tWT5NWKwDEU8cnQHcwXMmsGeSJ vQ8jI+eOrja3E7X5fsDbcqziaE3lPN4gE6/ZOceoOpdK435nP4ld+bgbLtvjzrt+8F2a PztA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789511438; x=1790116238; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OoaUvNij8YmbcFsxH3lXmPdyT4LUwKvkwpbwWWFHxPE=; b=BLDXrjcEI95UV94dYCnBZ+WtGCObmN23M4eWwOO8gguFEmTVi5o0Zo9uBt/mn739PZ 72RHiuBPRFzoo4K39wzrfrlsj0V1p8wapQTJe/IIXxalZOVTIC/eHnz4IAh7VxTZ5tGg WxnCgVVTQQMDwMnjmDEhhrBGsgmol6xvlqm7PaG3k+pG/O4GbUh5gQH7GDFfbdvwo2G2 h3MbmpdL5h0o//8E1wms7bZhyFe/KJUYrJu6k79Iqh46DjRFPNt3/D80CdlpMXakhZsk koI2P//cMAyedCQBRunkw/n2o3bd3ed0jXBFQd/l3lHZO9O+RC3kKm3BIHwCGBxaEwUz 26wg== X-Forwarded-Encrypted: i=1; AKwUvBzyzrIIV/F0ls3SY33Y4ze1SSsdZQCXo/vfFf4pFxOAjYC3Tqqb1ZBVLym0rQGo3SNJ6GhPPVc52kxGnF4=@vger.kernel.org X-Gm-Message-State: AFuF++k+l9gUVw0mBHXzfInjd1Ol3QuxzhtQphiaQer6Xh59sBrWjYgx rdatjePpDdk9LRaa4jNno9ylBy8vOhYWhgKOWXY4TbpxgpZbDV6te1YOgYEWE6lkY8gwWRzz4wk 8ei6rKB8JjPxtSYIprKnDVW6B55Wlb3wcbX2RDZEHfDc8Rtqt++zn66vdCIhXXWXuzBQ= X-Gm-Gg: AYBFou35SGt8Gdzh4LRW4CbFltv0qSDM7M+bLuVop8fRLZXCCJdzuNm6P5kWpxEaJa6 RFj6cvzQtKnqksCIyCcX1pYo4L8HiejMUkURlqJKLP4IpXIIa/XO1P8I0xIbT/GIQ9NZL6E3Jgf w5B2zgkkGG7QS4GgVz0T98c1P0b4hYkrqCtsaJ/tqde7twl/UoySNSfysZPx6fSC8y/epkxsFTI XgmeyggyNAOZ5Zcs8E0Pb+/ebYfLbR+zZxJ2crNGp7bt29z/WqfKTk+g16KTEvwzL6gECQ2+sUN QO9LgrE9XBZzkv48wJNBXjZmegaZbfhaxOuJatpwxOFXokO+1WOOMB1n9AoftwgR6A5/5flSk4g +Mt6k++sNYaAs1U/quc1vBqasSVo= X-Received: by 2002:a05:620a:1a03:b0:939:7c8:78b1 with SMTP id af79cd13be357-93bb789cc86mr30101885a.24.1789511438169; Tue, 15 Sep 2026 15:30:38 -0700 (PDT) X-Received: by 2002:a05:620a:1a03:b0:939:7c8:78b1 with SMTP id af79cd13be357-93bb789cc86mr30097185a.24.1789511437739; Tue, 15 Sep 2026 15:30:37 -0700 (PDT) Received: from [192.168.68.120] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm24618435e9.14.2026.09.15.15.30.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Sep 2026 15:30:36 -0700 (PDT) Message-ID: <6266fd8c-d941-4eb4-bcf2-fbd54d093186@oss.qualcomm.com> Date: Tue, 15 Sep 2026 23:30:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 8/8] ASoC: codecs: add Qualcomm Tambora (WCD9378) SDCA codec To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Cc: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Pierre-Louis Bossart , Charles Keepax , Maciej Strozek , Bard Liao , Rob Herring , Krzysztof Kozlowski , Conor Dooley , patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260915165652.914893-1-srinivas.kandagatla@oss.qualcomm.com> <20260915165652.914893-9-srinivas.kandagatla@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=BtkIUoX5 c=1 sm=1 tr=0 ts=6aa9c70e cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=ohbBbs68x0cw2nEFerEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-ORIG-GUID: 0MLtLHfbZMnR4M3IO_WzfxhF9kyiURGd X-Proofpoint-GUID: 0MLtLHfbZMnR4M3IO_WzfxhF9kyiURGd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDMyOSBTYWx0ZWRfX1kLiE+1qcUAg xM2MRO0s6N54KKz5DQaHbgtPAJzH0XiXG9E5VqvsmgDUxi2OTYtS4qk/bEDt6MZx7ikEK8CXNO0 3fp+zpwsAIg5IJEcE1WS5WvxckkGlUmNYz3/6+pTzUwnzBO4twQvQh7zhj4fY9EKW00Sj8AjXW2 MCPIXHtBR3H+5Wtq6Hs79ofeOThtrV6LvVEoM5Gl610VY8eB118zlqGjxuI35tEwUFCGtzbTHj3 LAo1nd7NyaXsJj4mX4bBWPlDprD8HFoxScqiOckTWeKPap82kc0MTwHfDpg8XflothkOGHu0SQ/ 3kgQUXOwYU1madja0hY4oXSeCSrfkbCmH6u9I2GP+rJjxtI6BA0stMBuBBJH04yr3sFrlgaAgaN cHsYejr8i3gTXkcs6hCHF8ZhC6QjO+iplPX5HoGHFiCqmWk0FDD5OOMyk/2B6KVuiTPSfJQQQCI ugZ/KoCPWD37gigUV/A== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDMyOSBTYWx0ZWRfX+mKHMM099cwi zVGe/gZJmkktiWexBrbt19rdDLm/1I7/Il3LwjnTFRExJhV+aVBBdqAMhRO13A4NZxgV7JXbReu LnHX4bStuCS+bWpEV5p3g2SMXQpplss= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150329 On 9/15/26 6:22 PM, Uwe Kleine-König wrote: > Hello, > > On Tue, Sep 15, 2026 at 05:56:50PM +0100, Srinivas Kandagatla wrote: >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > > You can and should rely on sdw_device_id being provided by > . So please drop which > makes a bunch of useless build dependencies go away with it. > thanks for the comments both fixed in new version. --srini >> +#include "wcd9378-sdca.h" >> + >> +static const struct dev_pm_ops wcd9378_sdw_pm_ops = { >> + SYSTEM_SLEEP_PM_OPS(wcd9378_sdca_system_suspend, >> + wcd9378_sdca_system_resume) >> + RUNTIME_PM_OPS(wcd9378_sdca_runtime_suspend, >> + wcd9378_sdca_runtime_resume, NULL) >> +}; >> + >> +static const struct sdw_slave_ops wcd9378_sdw_ops = { >> + .read_prop = wcd9378_sdca_read_prop, >> +}; >> + >> +static const struct sdw_device_id wcd9378_sdw_id[] = { >> + SDW_SLAVE_ENTRY(0x0217, 0x0110, 0), >> + {} >> +}; > > s/{}/{ }/ please > > Best regards > Uwe