From: "Arnd Bergmann" <arnd@arndb.de>
To: "Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
"Kalle Valo" <kvalo@kernel.org>,
libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: libertas: fix config name in dependency for SDIO support
Date: Wed, 22 Nov 2023 10:21:57 +0100 [thread overview]
Message-ID: <6270c14a-6b65-44f5-a820-43cb72f8f2b7@app.fastmail.com> (raw)
In-Reply-To: <20231122083047.12774-1-lukas.bulwahn@gmail.com>
On Wed, Nov 22, 2023, at 09:30, Lukas Bulwahn wrote:
> Commit 4b478bf6bdd8 ("wifi: libertas: drop 16-bit PCMCIA support") reworks
> the dependencies for config LIBERTAS, and adds alternative dependencies for
> USB, SDIO and SPI.
>
> The config option SDIO however does not exist in the kernel tree. It was
> probably intended to refer to the config option MMC, which represents
> "MMC/SD/SDIO card support" and is used as dependency by various other
> drivers that use SDIO.
>
> Fix the dependency to the config option MMC for declaring the requirement
> on provision of SDIO support.
>
> Fixes: 4b478bf6bdd8 ("wifi: libertas: drop 16-bit PCMCIA support")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Good catch
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2023-11-22 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 8:30 Lukas Bulwahn
2023-11-22 9:21 ` Arnd Bergmann [this message]
2023-11-30 19:21 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6270c14a-6b65-44f5-a820-43cb72f8f2b7@app.fastmail.com \
--to=arnd@arndb.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@kernel.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®