From: Dan Carpenter <dan.carpenter@linaro.org>
To: Calvince Otieno <calvncce@gmail.com>
Cc: outreachy@lists.linux.dev, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Luke Koch <lu.ale.koch@gmail.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Simon Horman <horms@kernel.org>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: wlan-ng: remove unused functions
Date: Fri, 13 Oct 2023 12:02:30 +0300 [thread overview]
Message-ID: <62778e4d-cc2e-4310-b334-52b54cfe7e79@kadam.mountain> (raw)
In-Reply-To: <ZSjpQlUcyOoYv4Yh@lab-ubuntu>
On Fri, Oct 13, 2023 at 09:52:50AM +0300, Calvince Otieno wrote:
> The following functions were defined in the prism2mgmt.h file but neither
> declared nor used anywhere. It is recommended that they be removed.
>
> - void prism2mgmt_get_grpaddr(u32 did, struct p80211pstrd *pstr,
> struct hfa384x *priv);
> - int prism2mgmt_set_grpaddr(u32 did,
> u8 *prism2buf, struct p80211pstrd *pstr,
> struct hfa384x *priv);
> - int prism2mgmt_get_grpaddr_index(u32 did);
>
Could you look up when the functions were deleted and add that
information to the commit message?
These functions were removed five years ago in commit 123412341234
("delete functions").
regards,
dan carpenter
next prev parent reply other threads:[~2023-10-13 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 6:52 Calvince Otieno
2023-10-13 9:02 ` Dan Carpenter [this message]
2023-10-15 7:39 ` Calvince Otieno
2023-10-15 9:24 ` Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62778e4d-cc2e-4310-b334-52b54cfe7e79@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=bagasdotme@gmail.com \
--cc=calvncce@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lu.ale.koch@gmail.com \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®