mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Daniel J Blueman" <daniel.blueman@gmail.com>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: "Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: [2.6.26-rc6] section/warning fixes...
Date: Sun, 15 Jun 2008 12:32:15 +0100	[thread overview]
Message-ID: <6278d2220806150432i6f8265bfra7d0e5ff6e130303@mail.gmail.com> (raw)

This fixes [2] some warnings [1] introduced in recent -rc series; please apply.

Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>

--- [1]

WARNING: arch/x86/mm/built-in.o(.text+0x3a1): Section mismatch in
reference from the function set_pte_phys() to the function
.init.text:spp_getpage()
The function set_pte_phys() references
the function __init spp_getpage().
This is often because set_pte_phys lacks a __init
annotation or the annotation of spp_getpage is wrong.

arch/x86/mm/init_64.c: In function 'early_memtest':
arch/x86/mm/init_64.c:520: warning: passing argument 2 of
'find_e820_area_size' from incompatible pointer type

--- [2]

diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index 156e6d7..f6d20be 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -135,7 +135,7 @@ static __init void *spp_getpage(void)
 	return ptr;
 }

-static void
+static __init void
 set_pte_phys(unsigned long vaddr, unsigned long phys, pgprot_t prot)
 {
 	pgd_t *pgd;
@@ -214,7 +214,7 @@ void __init cleanup_highmap(void)
 }

 /* NOTE: this is meant to be run only at boot */
-void __set_fixmap(enum fixed_addresses idx, unsigned long phys, pgprot_t prot)
+void __init __set_fixmap(enum fixed_addresses idx, unsigned long
phys, pgprot_t prot)
 {
 	unsigned long address = __fix_to_virt(idx);

@@ -506,7 +506,7 @@ early_param("memtest", parse_memtest);

 static void __init early_memtest(unsigned long start, unsigned long end)
 {
-	u64 t_start, t_size;
+	unsigned long t_start, t_size;
 	unsigned pattern;

 	if (!memtest_pattern)
@@ -525,7 +525,7 @@ static void __init early_memtest(unsigned long
start, unsigned long end)
 			if (t_start + t_size > end)
 				t_size = end - t_start;

-			printk(KERN_CONT "\n  %016llx - %016llx pattern %d",
+			printk(KERN_CONT "\n  %016lx - %016lx pattern %d",
 				t_start, t_start + t_size, pattern);

 			memtest(t_start, t_size, pattern);
-- 
Daniel J Blueman

             reply	other threads:[~2008-06-15 11:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-15 11:32 Daniel J Blueman [this message]
2008-07-03 12:13 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6278d2220806150432i6f8265bfra7d0e5ff6e130303@mail.gmail.com \
    --to=daniel.blueman@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®