From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50F7338756D for ; Thu, 29 Jan 2026 11:46:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769687214; cv=none; b=bpoB9j+5bY06X/IXV0WS+rgl3mzytZDSIXriQh6q2n6hVR4Uw3sSduAjfGPVCG+Y6M3v/+TYseg/Bo87xcHNLAfufIv/ICfp8jMa+IsDzqI/nfBqcImp1aYenexQJJhncKrBb5On9jR2xIbHRmcw4UIo90OzUHybI8trh6knOk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769687214; c=relaxed/simple; bh=jSw/u7S8eCN5NKIw+gpHjTuW9Esip6V4dfxS2M/EkY0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o62zzs1E58M3uFil0VJDw5rBsgSFuRcFJPmlLED8/gVyVmicac4sjlcdaIYa3u93+Pgg32/z06CiqVeudOWRN8Wo9rZTj3o5q5rFzTFwZEWgB4/8xlloxy5rTPfVKrtsxTVsPxM4AFkrNtg904MsngY6xyeZIpoqc54bHp4yluA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SXtCkTKQ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=e7FoknhQ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SXtCkTKQ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="e7FoknhQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769687212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jpvdzmSa+i+pWFFmFsuGVs+kLgJBr+cyfmxqCcSStVY=; b=SXtCkTKQehtcm59zBb5hj3XnuAx7Z+lnfnosnCdqARTXjSUjbRMlc5j95NPQaFwbdIJnPK 3WTbCN38s0wmwjz/IH1+6QY4V4bi4sHRJgm28MspleIbedl1ZkXRVecz0dtcWvTbwqvkVV Yi5euvs2N66dFRFkCOBEoFyNgQ1IrOg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-unbBeGy0Olqw45jPDLc-Pg-1; Thu, 29 Jan 2026 06:46:51 -0500 X-MC-Unique: unbBeGy0Olqw45jPDLc-Pg-1 X-Mimecast-MFC-AGG-ID: unbBeGy0Olqw45jPDLc-Pg_1769687210 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4801bceb317so8876595e9.1 for ; Thu, 29 Jan 2026 03:46:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769687210; x=1770292010; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jpvdzmSa+i+pWFFmFsuGVs+kLgJBr+cyfmxqCcSStVY=; b=e7FoknhQGAGaPg/rksxKD+eg/MpIJMnaJ3gTKUXbMkfUtMVpVGjUolM5efo1aVtZx4 wLjXoeHg63n6jJpy1gFgm6sKvNCnPxgpHFBFc8G3GxnV0RnOcxb9CcKqL6DPPJ55Eux9 MuBCNUqCv0G2dB9OK4WbPa6RcvbA/dvStFmlL6NUmM/OyLiJmK5XGJvwPoW+9RWb7gHU WTjl2jkVvLbLQtchK6FL9gqrfjgsjCRcFTUX1s6etL8zMiLH7MwzO+JkiB/qwYWlCHKe tyFtt3SnytoXy/NBgEWiOLzslRefJA4kOFZ5hX3xrl07I9jjbuLQ9swCyHjmMmUScIBm B5Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769687210; x=1770292010; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jpvdzmSa+i+pWFFmFsuGVs+kLgJBr+cyfmxqCcSStVY=; b=l5fogK3KqzLbG+F9Znd3rUdIvFgaBd4VznP1A9MyWLBN9rtC/PtnPj2ox7fhZeyUN4 e+EZt3PoM4Y5UixkoAyCBwZlaWdcyqvSPXGpg9ZrE0imw6VpZUhUqWg3yVLWfeB3Y9Sy vFqBqtU0G8zrVXhiZNppeCnZGF9RJRMilJhlX4ducxCrdH4Znuv4hVsfntHD6Ss/ue1A GEWtVaX9FZ5N0zKgGSfQ0eqxgQJLjTiRE7ClkrO58yuccohRWWELVsD5Kp1iIeIWH5ML cBRw591uWHKoMyZgzDHdZ/d3Xcqh1Ah/Cpa1kE7DkpBVpkd04rcn/uxSwNAjj13iz0Su ZOww== X-Forwarded-Encrypted: i=1; AJvYcCWh++h4ElLd2cYfP4RDCsHWQC3aisUQXTRpVtcVLW9GVM4lAhSamJ4vpvw14BH9UHDXORxaOt6Yqn/ng1A=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1jHU6y/2UA4A+1VnF7i43L1o46f7nGWHaehyhdkZ41iXehQPQ 5w1ofEx0DtbBoc5KQ1mikjwDSRqLPv08M2Mny4/EAwX3JiFch2u3DTGtPg1QMEpaNF0Y1YBvpr2 CeWZTVtN5aApdSAiKyQdAwcNzHwUxshG8EiOHjjO6MrKCQ/lDVhAl3/+KWav4zqPrDA== X-Gm-Gg: AZuq6aJYHVSE7rqNoPZroUkKmtqb+A7hshE5CZhhSP32KALVZ2O2mImEPLYpMc0Avhp QrKB5wiLoQeKGGCQCdZ/sXhpCSt9sT8i+V1OWuUvZ7LyrLaiP2g7dnttWYg7IHQwu8LvXVwhD1t r3ZrWvu4N0ohh8LTDBh6n/iC4mB6o0FIuosIhf0C0nG6ce2WtN/WYgB4Efx4nyVJLratddGHCJo lKQFEdtdkJVu7jEGSG7tCAI8qWm/l7DISwV1lNhhPslyaKg+2UKjHmNSFl4UmNgUFGnJ90CndBB x6NfulhiogPD+q/gbvdgqq15/JpJElf8oHHJ0HlAFN92W9G/yH5lyounWtT9IN1k/EAV09+XtW5 GymqkRiTgGLhQ X-Received: by 2002:a05:600c:8b24:b0:477:5c58:3d42 with SMTP id 5b1f17b1804b1-48069c20e88mr107550385e9.10.1769687209769; Thu, 29 Jan 2026 03:46:49 -0800 (PST) X-Received: by 2002:a05:600c:8b24:b0:477:5c58:3d42 with SMTP id 5b1f17b1804b1-48069c20e88mr107550105e9.10.1769687209355; Thu, 29 Jan 2026 03:46:49 -0800 (PST) Received: from [192.168.88.32] ([212.105.153.56]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806cd8fadfsm123063015e9.0.2026.01.29.03.46.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 03:46:48 -0800 (PST) Message-ID: <62793715-5fcb-470d-85dd-77472e410df3@redhat.com> Date: Thu, 29 Jan 2026 12:46:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next v8 3/8] net: wwan: core: split port creation and registration To: Slark Xiao , loic.poulain@oss.qualcomm.com, ryazanov.s.a@gmail.com, johannes@sipsolutions.net, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, mani@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260126062158.308598-1-slark_xiao@163.com> <20260126062158.308598-4-slark_xiao@163.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260126062158.308598-4-slark_xiao@163.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/26/26 7:21 AM, Slark Xiao wrote: > From: Sergey Ryazanov > > Upcoming GNSS (NMEA) port type support requires exporting it via the > GNSS subsystem. On another hand, we still need to do basic WWAN core > work: find or allocate the WWAN device, make it the port parent, etc. To > reuse as much code as possible, split the port creation function into > the registration of a regular WWAN port device, and basic port struct > initialization. > > To be able to use put_device() uniformly, break the device_register() > call into device_initialize() and device_add() and call device > initialization earlier. > > While at it, fix a minor number leak upon WWAN port registration > failure. > > Signed-off-by: Sergey Ryazanov The series LGTM, but waiting a bit more for Loic's explicit ack here. Thanks, Paolo